All of lore.kernel.org
 help / color / mirror / Atom feed
From: rabin@rab.in (Rabin Vincent)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: Omit fixmap calls in text patching code if CONFIG_MMU=n
Date: Mon, 26 Oct 2015 18:17:50 +0100	[thread overview]
Message-ID: <20151026171750.GA30888@debian> (raw)
In-Reply-To: <1445846092-1979-1-git-send-email-geert@linux-m68k.org>

On Mon, Oct 26, 2015 at 08:54:52AM +0100, Geert Uytterhoeven wrote:
> Protect the calls to set_fixmap() and clear_fixmap() by #ifdef >
> CONFIG_MMU to fix this.
> 
> Fixes: commit ab0615e2d6fb0747 ("arm: use fixmap for text patching when text is RO")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Since both DEBUG_SET_MODULE_RONX and DEBUG_RODATA depend on MMU, we'll
never get to this code on !MMU so this ifdef build fix should be ok.

Acked-by: Rabin Vincent <rabin@rab.in>

Thanks.

WARNING: multiple messages have this Message-ID (diff)
From: Rabin Vincent <rabin@rab.in>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Russell King <linux@arm.linux.org.uk>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm: Omit fixmap calls in text patching code if CONFIG_MMU=n
Date: Mon, 26 Oct 2015 18:17:50 +0100	[thread overview]
Message-ID: <20151026171750.GA30888@debian> (raw)
In-Reply-To: <1445846092-1979-1-git-send-email-geert@linux-m68k.org>

On Mon, Oct 26, 2015 at 08:54:52AM +0100, Geert Uytterhoeven wrote:
> Protect the calls to set_fixmap() and clear_fixmap() by #ifdef >
> CONFIG_MMU to fix this.
> 
> Fixes: commit ab0615e2d6fb0747 ("arm: use fixmap for text patching when text is RO")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Since both DEBUG_SET_MODULE_RONX and DEBUG_RODATA depend on MMU, we'll
never get to this code on !MMU so this ifdef build fix should be ok.

Acked-by: Rabin Vincent <rabin@rab.in>

Thanks.

  reply	other threads:[~2015-10-26 17:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-26  7:54 [PATCH] arm: Omit fixmap calls in text patching code if CONFIG_MMU=n Geert Uytterhoeven
2015-10-26  7:54 ` Geert Uytterhoeven
2015-10-26 17:17 ` Rabin Vincent [this message]
2015-10-26 17:17   ` Rabin Vincent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151026171750.GA30888@debian \
    --to=rabin@rab.in \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.