All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aristeu Rozanski <arozansk-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Michal Hocko <mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Greg Thelen <gthelen-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
	Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
	linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] oom_kill: add option to disable dump_stack()
Date: Mon, 26 Oct 2015 13:40:49 -0400	[thread overview]
Message-ID: <20151026174048.GP15046@redhat.com> (raw)
In-Reply-To: <20151026172012.GC9779-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>

Hi Michal,
On Mon, Oct 26, 2015 at 06:20:12PM +0100, Michal Hocko wrote:
> I can see why you want to reduce the amount of information, I guess you
> have tried to reduce the loglevel but this hasn't helped because
> dump_stack uses default log level which is too low to be usable, right?
> Or are there any other reasons?

One would be that the stack trace isn't very useful for users IMHO.

> I am not sure sysctl is a good way to tell this particular restriction
> on the output. What if somebody else doesn't want to see the list of
> eligible tasks? Should we add another knob?
>
> Would it make more sense to distinguish different parts of the OOM
> report by loglevel properly?
> pr_err - killed task report
> pr_warning - oom invocation + memory info
> pr_notice - task list
> pr_info - stack trace

That'd work, yes, but I'd think the stack trace would be pr_debug. At a
point that you suspect the OOM killer isn't doing the right thing picking
up tasks and you need more information.

-- 
Aristeu

WARNING: multiple messages have this Message-ID (diff)
From: Aristeu Rozanski <arozansk@redhat.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: linux-kernel@vger.kernel.org, Greg Thelen <gthelen@google.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	linux-mm@kvack.org, cgroups@vger.kernel.org
Subject: Re: [PATCH] oom_kill: add option to disable dump_stack()
Date: Mon, 26 Oct 2015 13:40:49 -0400	[thread overview]
Message-ID: <20151026174048.GP15046@redhat.com> (raw)
In-Reply-To: <20151026172012.GC9779@dhcp22.suse.cz>

Hi Michal,
On Mon, Oct 26, 2015 at 06:20:12PM +0100, Michal Hocko wrote:
> I can see why you want to reduce the amount of information, I guess you
> have tried to reduce the loglevel but this hasn't helped because
> dump_stack uses default log level which is too low to be usable, right?
> Or are there any other reasons?

One would be that the stack trace isn't very useful for users IMHO.

> I am not sure sysctl is a good way to tell this particular restriction
> on the output. What if somebody else doesn't want to see the list of
> eligible tasks? Should we add another knob?
>
> Would it make more sense to distinguish different parts of the OOM
> report by loglevel properly?
> pr_err - killed task report
> pr_warning - oom invocation + memory info
> pr_notice - task list
> pr_info - stack trace

That'd work, yes, but I'd think the stack trace would be pr_debug. At a
point that you suspect the OOM killer isn't doing the right thing picking
up tasks and you need more information.

-- 
Aristeu

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Aristeu Rozanski <arozansk@redhat.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: linux-kernel@vger.kernel.org, Greg Thelen <gthelen@google.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	linux-mm@kvack.org, cgroups@vger.kernel.org
Subject: Re: [PATCH] oom_kill: add option to disable dump_stack()
Date: Mon, 26 Oct 2015 13:40:49 -0400	[thread overview]
Message-ID: <20151026174048.GP15046@redhat.com> (raw)
In-Reply-To: <20151026172012.GC9779@dhcp22.suse.cz>

Hi Michal,
On Mon, Oct 26, 2015 at 06:20:12PM +0100, Michal Hocko wrote:
> I can see why you want to reduce the amount of information, I guess you
> have tried to reduce the loglevel but this hasn't helped because
> dump_stack uses default log level which is too low to be usable, right?
> Or are there any other reasons?

One would be that the stack trace isn't very useful for users IMHO.

> I am not sure sysctl is a good way to tell this particular restriction
> on the output. What if somebody else doesn't want to see the list of
> eligible tasks? Should we add another knob?
>
> Would it make more sense to distinguish different parts of the OOM
> report by loglevel properly?
> pr_err - killed task report
> pr_warning - oom invocation + memory info
> pr_notice - task list
> pr_info - stack trace

That'd work, yes, but I'd think the stack trace would be pr_debug. At a
point that you suspect the OOM killer isn't doing the right thing picking
up tasks and you need more information.

-- 
Aristeu


  parent reply	other threads:[~2015-10-26 17:40 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-23 21:02 [PATCH] oom_kill: add option to disable dump_stack() Aristeu Rozanski
2015-10-23 21:02 ` Aristeu Rozanski
     [not found] ` <1445634150-27992-1-git-send-email-arozansk-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-10-26 16:01   ` Johannes Weiner
2015-10-26 16:01     ` Johannes Weiner
2015-10-26 16:01     ` Johannes Weiner
2015-10-26 17:46     ` Aristeu Rozanski
2015-10-26 17:46       ` Aristeu Rozanski
2015-10-26 17:20   ` Michal Hocko
2015-10-26 17:20     ` Michal Hocko
2015-10-26 17:20     ` Michal Hocko
     [not found]     ` <20151026172012.GC9779-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2015-10-26 17:40       ` Aristeu Rozanski [this message]
2015-10-26 17:40         ` Aristeu Rozanski
2015-10-26 17:40         ` Aristeu Rozanski
     [not found]         ` <20151026174048.GP15046-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-10-27  8:09           ` Michal Hocko
2015-10-27  8:09             ` Michal Hocko
2015-10-27  8:09             ` Michal Hocko
     [not found]             ` <20151027080920.GA9891-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2015-10-27 15:43               ` Aristeu Rozanski
2015-10-27 15:43                 ` Aristeu Rozanski
2015-10-27 15:43                 ` Aristeu Rozanski
     [not found]                 ` <20151027154341.GA14722-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-10-27 16:20                   ` Michal Hocko
2015-10-27 16:20                     ` Michal Hocko
2015-10-27 16:20                     ` Michal Hocko
2015-10-27 17:51                     ` Aristeu Rozanski
2015-10-27 17:51                       ` Aristeu Rozanski
2015-10-28 23:55                       ` David Rientjes
2015-10-28 23:55                         ` David Rientjes
2015-10-26 21:38 ` David Rientjes
2015-10-26 21:38   ` David Rientjes
2015-12-01 23:43 ` Andrew Morton
2015-12-01 23:43   ` Andrew Morton
     [not found]   ` <20151201154353.87e2200b5cd1a99289ce6653-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2015-12-02  0:02     ` David Rientjes
2015-12-02  0:02       ` David Rientjes
2015-12-02  0:02       ` David Rientjes
2015-12-02  8:18     ` Michal Hocko
2015-12-02  8:18       ` Michal Hocko
2015-12-02  8:18       ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151026174048.GP15046@redhat.com \
    --to=arozansk-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=gthelen-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
    --cc=mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.