All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Burcin Akalin <brcnakalin@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] staging: xgifb:Block comments edited.
Date: Tue, 27 Oct 2015 16:52:19 +0900	[thread overview]
Message-ID: <20151027075219.GA18185@kroah.com> (raw)
In-Reply-To: <1445853740-8215-1-git-send-email-brcnakalin@gmail.com>

On Mon, Oct 26, 2015 at 01:02:20PM +0300, Burcin Akalin wrote:
> Alignment of block comments should be correct.Fix checkpatch.pl
> WARNING: Block comments use a trailing */ on a separate
> line
> 
> Signed-off-by: Burcin Akalin <brcnakalin@gmail.com>
> ---
>  drivers/staging/xgifb/vb_setmode.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c
> index c886dd2..f519fd2 100644
> --- a/drivers/staging/xgifb/vb_setmode.c
> +++ b/drivers/staging/xgifb/vb_setmode.c
> @@ -1997,8 +1997,10 @@ static void XGI_GetVBInfo(unsigned short ModeIdIndex,
>  				tempbx |= (SetInSlaveMode | SetSimuScanMode);
>  		}
>  
> -		/* LCD+TV can't support in slave mode
> -		 * (Force LCDA+TV->LCDB) */
> +		/* 
> +		 * LCD+TV can't support in slave mode
> +		 * (Force LCDA+TV->LCDB) 

Trailing whitespace :(

Always check your patches with checkpatch.pl before you send them out.

thanks,

greg k-h


  reply	other threads:[~2015-10-27  7:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-26 10:02 [PATCH] staging: xgifb:Block comments edited Burcin Akalin
2015-10-27  7:52 ` Greg KH [this message]
2015-10-27  7:52 ` [Outreachy kernel] " Sudip Mukherjee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151027075219.GA18185@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=brcnakalin@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.