* [PATCH] staging: xgifb:Block comments edited.
@ 2015-10-26 10:02 Burcin Akalin
2015-10-27 7:52 ` [Outreachy kernel] " Greg KH
2015-10-27 7:52 ` Sudip Mukherjee
0 siblings, 2 replies; 3+ messages in thread
From: Burcin Akalin @ 2015-10-26 10:02 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Burcin Akalin
Alignment of block comments should be correct.Fix checkpatch.pl
WARNING: Block comments use a trailing */ on a separate
line
Signed-off-by: Burcin Akalin <brcnakalin@gmail.com>
---
drivers/staging/xgifb/vb_setmode.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c
index c886dd2..f519fd2 100644
--- a/drivers/staging/xgifb/vb_setmode.c
+++ b/drivers/staging/xgifb/vb_setmode.c
@@ -1997,8 +1997,10 @@ static void XGI_GetVBInfo(unsigned short ModeIdIndex,
tempbx |= (SetInSlaveMode | SetSimuScanMode);
}
- /* LCD+TV can't support in slave mode
- * (Force LCDA+TV->LCDB) */
+ /*
+ * LCD+TV can't support in slave mode
+ * (Force LCDA+TV->LCDB)
+ */
if ((tempbx & SetInSlaveMode) && (tempbx & XGI_SetCRT2ToLCDA)) {
tempbx ^= (SetCRT2ToLCD | XGI_SetCRT2ToLCDA |
SetCRT2ToDualEdge);
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Outreachy kernel] [PATCH] staging: xgifb:Block comments edited.
2015-10-26 10:02 [PATCH] staging: xgifb:Block comments edited Burcin Akalin
@ 2015-10-27 7:52 ` Greg KH
2015-10-27 7:52 ` Sudip Mukherjee
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2015-10-27 7:52 UTC (permalink / raw)
To: Burcin Akalin; +Cc: outreachy-kernel
On Mon, Oct 26, 2015 at 01:02:20PM +0300, Burcin Akalin wrote:
> Alignment of block comments should be correct.Fix checkpatch.pl
> WARNING: Block comments use a trailing */ on a separate
> line
>
> Signed-off-by: Burcin Akalin <brcnakalin@gmail.com>
> ---
> drivers/staging/xgifb/vb_setmode.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c
> index c886dd2..f519fd2 100644
> --- a/drivers/staging/xgifb/vb_setmode.c
> +++ b/drivers/staging/xgifb/vb_setmode.c
> @@ -1997,8 +1997,10 @@ static void XGI_GetVBInfo(unsigned short ModeIdIndex,
> tempbx |= (SetInSlaveMode | SetSimuScanMode);
> }
>
> - /* LCD+TV can't support in slave mode
> - * (Force LCDA+TV->LCDB) */
> + /*
> + * LCD+TV can't support in slave mode
> + * (Force LCDA+TV->LCDB)
Trailing whitespace :(
Always check your patches with checkpatch.pl before you send them out.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: xgifb:Block comments edited.
2015-10-26 10:02 [PATCH] staging: xgifb:Block comments edited Burcin Akalin
2015-10-27 7:52 ` [Outreachy kernel] " Greg KH
@ 2015-10-27 7:52 ` Sudip Mukherjee
1 sibling, 0 replies; 3+ messages in thread
From: Sudip Mukherjee @ 2015-10-27 7:52 UTC (permalink / raw)
To: Burcin Akalin; +Cc: outreachy-kernel
On Mon, Oct 26, 2015 at 01:02:20PM +0300, Burcin Akalin wrote:
> Alignment of block comments should be correct.Fix checkpatch.pl
> WARNING: Block comments use a trailing */ on a separate
> line
>
> Signed-off-by: Burcin Akalin <brcnakalin@gmail.com>
> ---
> drivers/staging/xgifb/vb_setmode.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c
> index c886dd2..f519fd2 100644
> --- a/drivers/staging/xgifb/vb_setmode.c
> +++ b/drivers/staging/xgifb/vb_setmode.c
> @@ -1997,8 +1997,10 @@ static void XGI_GetVBInfo(unsigned short ModeIdIndex,
> tempbx |= (SetInSlaveMode | SetSimuScanMode);
> }
>
> - /* LCD+TV can't support in slave mode
> - * (Force LCDA+TV->LCDB) */
> + /*
Trailing whitespace
> + * LCD+TV can't support in slave mode
> + * (Force LCDA+TV->LCDB)
and also here.
regards
sudip
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-27 7:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-26 10:02 [PATCH] staging: xgifb:Block comments edited Burcin Akalin
2015-10-27 7:52 ` [Outreachy kernel] " Greg KH
2015-10-27 7:52 ` Sudip Mukherjee
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.