Re: checking if a patch was approved

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2253 bytes --]

On Tue, Oct 27, 2015 at 11:40:58AM +0100, Ivan Sergio Borgonovo wrote:
> On 10/27/2015 08:12 AM, Nicolas Dechesne wrote:
> > On Tue, Oct 27, 2015 at 12:12 AM, Ivan Sergio Borgonovo
> > <mail@webthatworks.it> wrote:
> >> I saw many patch passing by and I submitted a couple about
> >> meta-toolchain-qt5.
> >> I didn't see any message from Otavio or Martin "approving" a patches.
> >>
> >> How can I check if it was approved other than pulling from the repo/checking
> >> github?
> >>
> >> Or if there is no place to check... consider this a ping ;)
> 
> > all commits are published on
> > openembedded-commits@lists.openembedded.org mailing list, and in
> 
> thanks, actually my commit was for meta-qt5.
> But still I haven't seen any feedback on this mailing list to guess if 
> the commit was actually approved or not.
> 
> I haven't seen any "approval" feedback even for other commits. Maybe 
> because the patches submitted were coming from known developers and the 
> assumption is that if there is no request to fix something the patches 
> are going to be queued to be committed by default.
> 
> I'm really not asking for any special attention, I just would like to 
> know what I've to expect and check if I did the right thing and if I've 
> to do anything else to see my patch committed.

meta-oe and meta-qt5 patches are managed in Patchwork as described here:
http://www.openembedded.org/wiki/Patchwork

You can see the status here.

> Martin Jansa actually noticed a first revision of my patch and gave some 
> feedback to fix stuff and things have been fixed (hopefully) and I 
> submitted a second release.

I've noticed second revision as well, it's in master-next, but it
haven't finished even the automated jenkins build yet and because I
don't use qt5 SDK I was hoping that someone else will review them as
well. There are 2 formal issues, I've fixed commit message summary to
match our guidelines:
http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines

But both are also missing SOB line, please confirm that I can add your
SOB or resend both patches with SOB (and commit message from
master-next).

Regards,

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]