checking if a patch was approved

checking if a patch was approved

[Ivan Sergio Borgonovo]

I saw many patch passing by and I submitted a couple about 
meta-toolchain-qt5.
I didn't see any message from Otavio or Martin "approving" a patches.

How can I check if it was approved other than pulling from the 
repo/checking github?

Or if there is no place to check... consider this a ping ;)

thanks

-- 
Ivan Sergio Borgonovo
http://www.webthatworks.it

Re: checking if a patch was approved

[Nicolas Dechesne]

On Tue, Oct 27, 2015 at 12:12 AM, Ivan Sergio Borgonovo
<mail@webthatworks.it> wrote:
> I saw many patch passing by and I submitted a couple about
> meta-toolchain-qt5.
> I didn't see any message from Otavio or Martin "approving" a patches.
>
> How can I check if it was approved other than pulling from the repo/checking
> github?
>
> Or if there is no place to check... consider this a ping ;)

all commits are published on
openembedded-commits@lists.openembedded.org mailing list, and in
general you see when it's pushed in master-next, then in master.. i
have a mail filter that checks my name there.. it's the poor man
solution.. but it works. Note that the email trigger has been broken
for 2 weeks.. but i suspect this is a temporary issue that should be
fixed..

Re: checking if a patch was approved

[Ivan Sergio Borgonovo]

On 10/27/2015 08:12 AM, Nicolas Dechesne wrote:
> On Tue, Oct 27, 2015 at 12:12 AM, Ivan Sergio Borgonovo
> <mail@webthatworks.it> wrote:
>> I saw many patch passing by and I submitted a couple about
>> meta-toolchain-qt5.
>> I didn't see any message from Otavio or Martin "approving" a patches.
>>
>> How can I check if it was approved other than pulling from the repo/checking
>> github?
>>
>> Or if there is no place to check... consider this a ping ;)

> all commits are published on
> openembedded-commits@lists.openembedded.org mailing list, and in

thanks, actually my commit was for meta-qt5.
But still I haven't seen any feedback on this mailing list to guess if 
the commit was actually approved or not.

I haven't seen any "approval" feedback even for other commits. Maybe 
because the patches submitted were coming from known developers and the 
assumption is that if there is no request to fix something the patches 
are going to be queued to be committed by default.

I'm really not asking for any special attention, I just would like to 
know what I've to expect and check if I did the right thing and if I've 
to do anything else to see my patch committed.

Martin Jansa actually noticed a first revision of my patch and gave some 
feedback to fix stuff and things have been fixed (hopefully) and I 
submitted a second release.

thanks

-- 
Ivan Sergio Borgonovo
http://www.webthatworks.it

Re: checking if a patch was approved

[Otavio Salvador]

On Tue, Oct 27, 2015 at 8:40 AM, Ivan Sergio Borgonovo
<mail@webthatworks.it> wrote:
> On 10/27/2015 08:12 AM, Nicolas Dechesne wrote:
>>
>> On Tue, Oct 27, 2015 at 12:12 AM, Ivan Sergio Borgonovo
>> <mail@webthatworks.it> wrote:
>>>
>>> I saw many patch passing by and I submitted a couple about
>>> meta-toolchain-qt5.
>>> I didn't see any message from Otavio or Martin "approving" a patches.
>>>
>>> How can I check if it was approved other than pulling from the
>>> repo/checking
>>> github?
>>>
>>> Or if there is no place to check... consider this a ping ;)
>
>
>> all commits are published on
>> openembedded-commits@lists.openembedded.org mailing list, and in
>
>
> thanks, actually my commit was for meta-qt5.
> But still I haven't seen any feedback on this mailing list to guess if the
> commit was actually approved or not.
>
> I haven't seen any "approval" feedback even for other commits. Maybe because
> the patches submitted were coming from known developers and the assumption
> is that if there is no request to fix something the patches are going to be
> queued to be committed by default.
>
> I'm really not asking for any special attention, I just would like to know
> what I've to expect and check if I did the right thing and if I've to do
> anything else to see my patch committed.
>
> Martin Jansa actually noticed a first revision of my patch and gave some
> feedback to fix stuff and things have been fixed (hopefully) and I submitted
> a second release.

This is indeed a common issue and there are different answers for it.

For the layers I am actively acting as commited (meta-fsl-*,
meta-java, meta-browser) I send the email when I do merges. For
meta-qt5 Martin merges the patches for test in the -next branches. If
it is inside it, it is a good chance of it being applied in next
merge, or feedback will be given.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: checking if a patch was approved

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 2253 bytes --]

On Tue, Oct 27, 2015 at 11:40:58AM +0100, Ivan Sergio Borgonovo wrote:
> On 10/27/2015 08:12 AM, Nicolas Dechesne wrote:
> > On Tue, Oct 27, 2015 at 12:12 AM, Ivan Sergio Borgonovo
> > <mail@webthatworks.it> wrote:
> >> I saw many patch passing by and I submitted a couple about
> >> meta-toolchain-qt5.
> >> I didn't see any message from Otavio or Martin "approving" a patches.
> >>
> >> How can I check if it was approved other than pulling from the repo/checking
> >> github?
> >>
> >> Or if there is no place to check... consider this a ping ;)
> 
> > all commits are published on
> > openembedded-commits@lists.openembedded.org mailing list, and in
> 
> thanks, actually my commit was for meta-qt5.
> But still I haven't seen any feedback on this mailing list to guess if 
> the commit was actually approved or not.
> 
> I haven't seen any "approval" feedback even for other commits. Maybe 
> because the patches submitted were coming from known developers and the 
> assumption is that if there is no request to fix something the patches 
> are going to be queued to be committed by default.
> 
> I'm really not asking for any special attention, I just would like to 
> know what I've to expect and check if I did the right thing and if I've 
> to do anything else to see my patch committed.

meta-oe and meta-qt5 patches are managed in Patchwork as described here:
http://www.openembedded.org/wiki/Patchwork

You can see the status here.

> Martin Jansa actually noticed a first revision of my patch and gave some 
> feedback to fix stuff and things have been fixed (hopefully) and I 
> submitted a second release.

I've noticed second revision as well, it's in master-next, but it
haven't finished even the automated jenkins build yet and because I
don't use qt5 SDK I was hoping that someone else will review them as
well. There are 2 formal issues, I've fixed commit message summary to
match our guidelines:
http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines

But both are also missing SOB line, please confirm that I can add your
SOB or resend both patches with SOB (and commit message from
master-next).

Regards,

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

Re: checking if a patch was approved

[Ivan Sergio Borgonovo]

On 10/27/2015 12:05 PM, Martin Jansa wrote:

> I've noticed second revision as well, it's in master-next, but it
> haven't finished even the automated jenkins build yet and because I
> don't use qt5 SDK I was hoping that someone else will review them as
> well. There are 2 formal issues, I've fixed commit message summary to
> match our guidelines:
> http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines

> But both are also missing SOB line, please confirm that I can add your
> SOB or resend both patches with SOB (and commit message from
> master-next).

Yes. Feel free to commit it. The changes are mine and the original file 
is under MIT license and the one below is my real name.

I'll try to be more strict about commit messages next time. The subject 
seemed so uncomfortably long.

Thanks

-- 
Ivan Sergio Borgonovo
http://www.webthatworks.it

Re: checking if a patch was approved

[Paul Eggleton]

On Tuesday 27 October 2015 08:12:48 Nicolas Dechesne wrote:
> On Tue, Oct 27, 2015 at 12:12 AM, Ivan Sergio Borgonovo
> <mail@webthatworks.it> wrote:
> > I saw many patch passing by and I submitted a couple about
> > meta-toolchain-qt5.
> > I didn't see any message from Otavio or Martin "approving" a patches.
> > 
> > How can I check if it was approved other than pulling from the
> > repo/checking github?
> > 
> > Or if there is no place to check... consider this a ping ;)
> 
> all commits are published on
> openembedded-commits@lists.openembedded.org mailing list, and in
> general you see when it's pushed in master-next, then in master.. i
> have a mail filter that checks my name there.. it's the poor man
> solution.. but it works. Note that the email trigger has been broken
> for 2 weeks.. but i suspect this is a temporary issue that should be
> fixed..

FWIW there are a small number of us working on improving patchwork so that 
we're able to rely upon the results it shows as being the outstanding patches 
in the queue and potentially even send email notifications to submitters (opt-
in). I'd also like to go a step further and trigger some automatic validation 
on patches. At the moment we're trying to figure out if we're able to spend the 
time working on this in the next development cycle.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre

Re: checking if a patch was approved

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1815 bytes --]

On Tue, Oct 27, 2015 at 11:37:36AM +0000, Paul Eggleton wrote:
> On Tuesday 27 October 2015 08:12:48 Nicolas Dechesne wrote:
> > On Tue, Oct 27, 2015 at 12:12 AM, Ivan Sergio Borgonovo
> > <mail@webthatworks.it> wrote:
> > > I saw many patch passing by and I submitted a couple about
> > > meta-toolchain-qt5.
> > > I didn't see any message from Otavio or Martin "approving" a patches.
> > > 
> > > How can I check if it was approved other than pulling from the
> > > repo/checking github?
> > > 
> > > Or if there is no place to check... consider this a ping ;)
> > 
> > all commits are published on
> > openembedded-commits@lists.openembedded.org mailing list, and in
> > general you see when it's pushed in master-next, then in master.. i
> > have a mail filter that checks my name there.. it's the poor man
> > solution.. but it works. Note that the email trigger has been broken
> > for 2 weeks.. but i suspect this is a temporary issue that should be
> > fixed..
> 
> FWIW there are a small number of us working on improving patchwork so that 
> we're able to rely upon the results it shows as being the outstanding patches 
> in the queue and potentially even send email notifications to submitters (opt-
> in). I'd also like to go a step further and trigger some automatic validation 
> on patches. At the moment we're trying to figure out if we're able to spend the 
> time working on this in the next development cycle.

Paul: do you know what's wrong with git hooks triggering
openembedded-commits e-mails? Or maybe it's the ML itself, but there
was no e-mail in last month. I've pinged Michael on IRC twice (+CC here)

http://lists.openembedded.org/pipermail/openembedded-commits/2015-September/thread.html

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

Re: checking if a patch was approved

[Paul Eggleton]

On Tuesday 27 October 2015 13:00:16 Martin Jansa wrote:
> On Tue, Oct 27, 2015 at 11:37:36AM +0000, Paul Eggleton wrote:
> > On Tuesday 27 October 2015 08:12:48 Nicolas Dechesne wrote:
> > > On Tue, Oct 27, 2015 at 12:12 AM, Ivan Sergio Borgonovo
> > > 
> > > <mail@webthatworks.it> wrote:
> > > > I saw many patch passing by and I submitted a couple about
> > > > meta-toolchain-qt5.
> > > > I didn't see any message from Otavio or Martin "approving" a patches.
> > > > 
> > > > How can I check if it was approved other than pulling from the
> > > > repo/checking github?
> > > > 
> > > > Or if there is no place to check... consider this a ping ;)
> > > 
> > > all commits are published on
> > > openembedded-commits@lists.openembedded.org mailing list, and in
> > > general you see when it's pushed in master-next, then in master.. i
> > > have a mail filter that checks my name there.. it's the poor man
> > > solution.. but it works. Note that the email trigger has been broken
> > > for 2 weeks.. but i suspect this is a temporary issue that should be
> > > fixed..
> > 
> > FWIW there are a small number of us working on improving patchwork so that
> > we're able to rely upon the results it shows as being the outstanding
> > patches in the queue and potentially even send email notifications to
> > submitters (opt- in). I'd also like to go a step further and trigger some
> > automatic validation on patches. At the moment we're trying to figure out
> > if we're able to spend the time working on this in the next development
> > cycle.
> 
> Paul: do you know what's wrong with git hooks triggering
> openembedded-commits e-mails? Or maybe it's the ML itself, but there
> was no e-mail in last month. I've pinged Michael on IRC twice (+CC here)
> 
> http://lists.openembedded.org/pipermail/openembedded-commits/2015-September/
> thread.html

I don't, I'm afraid - I don't have access to that infrastructure. I hope 
Michael can shed some light.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre