Re: [Qemu-devel] [PATCH] vl.c: Replace fprintf(stderr) with error_report()

[Eduardo Habkost <ehabkost@redhat.com>]

On Mon, Oct 26, 2015 at 01:10:31PM -0600, Eric Blake wrote:
> On 10/26/2015 11:13 AM, Eduardo Habkost wrote:
> > This replaces most fprintf(stderr) calls on vl.c with error_report().
> > 
> > The trailing newlines, "qemu:" and "error:" message prefixes were
> > removed.
> > 
> > The only remaining fprintf(stderr) calls are the ones at
> > qemu_kill_report(), because the error mesage is split in multiple
> > fprintf() calls.
> > 
> > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> > ---
> > Not sure if this is appropriate post soft-freeze, but if we are going to apply
> > the max-cpus patch from Drew before 2.5.0, we could simply change all the
> > fprintf() calls in a single step.
> 
> Soft freeze means no new features that didn't already have a patch
> review started - but this is a cleanup, not a new feature. I think it
> qualifies for 2.5 inclusion just fine.

Makes sense. Thanks for the input!

> 
> > ---
> >  vl.c | 228 +++++++++++++++++++++++++++++++++----------------------------------
> >  1 file changed, 112 insertions(+), 116 deletions(-)
> 
> In addition to the things Markus pointed out,
> 
[many suggestions]
> 
> Whether you squash in those fixes, roll a v2, or send a followup, feel
> free to add:
> 
> Reviewed-by: Eric Blake <eblake@redhat.com>

Except for the indentation fix (which I already fixed in my git tree), I
will send them as a follow-up. Thanks!

-- 
Eduardo