From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: axboe@fb.com, jack@suse.cz, akpm@linux-foundation.org,
linux-nvdimm@lists.01.org,
Dave Hansen <dave.hansen@linux.intel.com>,
david@fromorbit.com, linux-kernel@vger.kernel.org,
willy@linux.intel.com, ross.zwisler@linux.intel.com, hch@lst.de
Subject: Re: [PATCH v2 1/5] pmem, dax: clean up clear_pmem()
Date: Tue, 27 Oct 2015 11:31:12 -0600 [thread overview]
Message-ID: <20151027173112.GA16605@linux.intel.com> (raw)
In-Reply-To: <20151022171021.38343.65959.stgit@dwillia2-desk3.amr.corp.intel.com>
On Thu, Oct 22, 2015 at 01:10:21PM -0400, Dan Williams wrote:
> Both, __dax_pmd_fault, and clear_pmem() were taking special steps to
> clear memory a page at a time to take advantage of non-temporal
> clear_page() implementations. However, x86_64 does not use
> non-temporal instructions for clear_page(), and arch_clear_pmem() was
> always incurring the cost of __arch_wb_cache_pmem().
>
> Clean up the assumption that doing clear_pmem() a page at a time is more
> performant.
>
> Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
> Reported-by: Dave Hansen <dave.hansen@linux.intel.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>
WARNING: multiple messages have this Message-ID (diff)
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: axboe@fb.com, jack@suse.cz, akpm@linux-foundation.org,
linux-nvdimm@ml01.01.org,
Dave Hansen <dave.hansen@linux.intel.com>,
david@fromorbit.com, linux-kernel@vger.kernel.org,
willy@linux.intel.com, ross.zwisler@linux.intel.com, hch@lst.de
Subject: Re: [PATCH v2 1/5] pmem, dax: clean up clear_pmem()
Date: Tue, 27 Oct 2015 11:31:12 -0600 [thread overview]
Message-ID: <20151027173112.GA16605@linux.intel.com> (raw)
In-Reply-To: <20151022171021.38343.65959.stgit@dwillia2-desk3.amr.corp.intel.com>
On Thu, Oct 22, 2015 at 01:10:21PM -0400, Dan Williams wrote:
> Both, __dax_pmd_fault, and clear_pmem() were taking special steps to
> clear memory a page at a time to take advantage of non-temporal
> clear_page() implementations. However, x86_64 does not use
> non-temporal instructions for clear_page(), and arch_clear_pmem() was
> always incurring the cost of __arch_wb_cache_pmem().
>
> Clean up the assumption that doing clear_pmem() a page at a time is more
> performant.
>
> Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
> Reported-by: Dave Hansen <dave.hansen@linux.intel.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>
next prev parent reply other threads:[~2015-10-27 17:31 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-22 17:10 [PATCH v2 0/5] block, dax: updates for 4.4 Dan Williams
2015-10-22 17:10 ` Dan Williams
2015-10-22 17:10 ` [PATCH v2 1/5] pmem, dax: clean up clear_pmem() Dan Williams
2015-10-22 17:10 ` Dan Williams
2015-10-22 20:48 ` Jeff Moyer
2015-10-22 22:29 ` Dan Williams
2015-10-28 21:01 ` Jeff Moyer
2015-10-27 17:31 ` Ross Zwisler [this message]
2015-10-27 17:31 ` Ross Zwisler
2015-10-22 17:10 ` [PATCH v2 2/5] dax: increase granularity of dax_clear_blocks() operations Dan Williams
2015-10-22 17:10 ` Dan Williams
2015-10-22 21:04 ` Jeff Moyer
2015-10-22 22:57 ` Williams, Dan J
2015-10-28 21:02 ` Jeff Moyer
2015-10-22 17:10 ` [PATCH v2 3/5] block, dax: fix lifetime of in-kernel dax mappings with dax_map_atomic() Dan Williams
2015-10-22 17:10 ` Dan Williams
2015-10-28 20:15 ` Jeff Moyer
2015-10-22 17:10 ` [PATCH v2 4/5] block: introduce bdev_file_inode() Dan Williams
2015-10-22 17:10 ` Dan Williams
2015-10-22 20:37 ` Jan Kara
2015-10-22 20:37 ` Jan Kara
2015-10-28 20:16 ` Jeff Moyer
2015-10-22 17:10 ` [PATCH v2 5/5] block: enable dax for raw block devices Dan Williams
2015-10-22 17:10 ` Dan Williams
2015-10-28 20:50 ` Jeff Moyer
2015-10-29 7:14 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151027173112.GA16605@linux.intel.com \
--to=ross.zwisler@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@fb.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=david@fromorbit.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.