From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: "Wan, Kaike" <kaike.wan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: "Weiny, Ira" <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Saurabh Sengar
<saurabh.truth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org"
<dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"Hefty,
Sean" <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
<hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"yun.wang-EIkl63zCoXaH+58JC4qpiA@public.gmane.org"
<yun.wang-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>,
"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] IB/sa: replace GFP_KERNEL with GFP_ATOMIC
Date: Tue, 27 Oct 2015 14:00:12 -0600 [thread overview]
Message-ID: <20151027200012.GA7403@obsidianresearch.com> (raw)
In-Reply-To: <3F128C9216C9B84BB6ED23EF16290AFB18571E3F-8k97q/ur5Z2krb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
On Tue, Oct 27, 2015 at 06:56:50PM +0000, Wan, Kaike wrote:
> > I do wonder if it is a good idea to call ib_nl_send_msg with a spinlock held
> > though.. Would be nice to see that go away.
>
> We have to hold the lock to protect against a race condition that a
> quick response will try to free the request from the
> ib_nl_request_list before we even put it on the list.
Put is on the list first? Use a kref? Doesn't look like a big deal to
clean this up.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: "Wan, Kaike" <kaike.wan@intel.com>
Cc: "Weiny, Ira" <ira.weiny@intel.com>,
Saurabh Sengar <saurabh.truth@gmail.com>,
"dledford@redhat.com" <dledford@redhat.com>,
"Hefty, Sean" <sean.hefty@intel.com>,
"hal.rosenstock@gmail.com" <hal.rosenstock@gmail.com>,
"yun.wang@profitbricks.com" <yun.wang@profitbricks.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] IB/sa: replace GFP_KERNEL with GFP_ATOMIC
Date: Tue, 27 Oct 2015 14:00:12 -0600 [thread overview]
Message-ID: <20151027200012.GA7403@obsidianresearch.com> (raw)
In-Reply-To: <3F128C9216C9B84BB6ED23EF16290AFB18571E3F@CRSMSX101.amr.corp.intel.com>
On Tue, Oct 27, 2015 at 06:56:50PM +0000, Wan, Kaike wrote:
> > I do wonder if it is a good idea to call ib_nl_send_msg with a spinlock held
> > though.. Would be nice to see that go away.
>
> We have to hold the lock to protect against a race condition that a
> quick response will try to free the request from the
> ib_nl_request_list before we even put it on the list.
Put is on the list first? Use a kref? Doesn't look like a big deal to
clean this up.
Jason
next prev parent reply other threads:[~2015-10-27 20:00 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <saurabh.truth@gmail.com>
2015-10-27 3:42 ` [PATCH] drivers: of: removing assignment of 0 to static variable Saurabh Sengar
2015-10-27 3:42 ` Saurabh Sengar
2015-10-30 18:30 ` Rob Herring
2015-10-27 15:47 ` [PATCH] IB/sa: replace GFP_KERNEL with GFP_ATOMIC Saurabh Sengar
2015-10-27 15:47 ` Saurabh Sengar
[not found] ` <1445960860-3396-1-git-send-email-saurabh.truth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-10-27 18:12 ` ira.weiny
2015-10-27 18:12 ` ira.weiny
[not found] ` <20151027181235.GA27038-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>
2015-10-27 18:16 ` Jason Gunthorpe
2015-10-27 18:16 ` Jason Gunthorpe
[not found] ` <20151027181652.GA6879-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-10-27 18:20 ` ira.weiny
2015-10-27 18:20 ` ira.weiny
2015-10-27 18:56 ` Wan, Kaike
2015-10-27 18:56 ` Wan, Kaike
[not found] ` <3F128C9216C9B84BB6ED23EF16290AFB18571E3F-8k97q/ur5Z2krb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-10-27 20:00 ` Jason Gunthorpe [this message]
2015-10-27 20:00 ` Jason Gunthorpe
2015-10-28 4:30 ` Weiny, Ira
[not found] ` <2807E5FD2F6FDA4886F6618EAC48510E1CBD4369-8k97q/ur5Z2krb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-11-13 7:42 ` Saurabh Sengar
2015-11-13 7:42 ` Saurabh Sengar
[not found] ` <1447400547-11490-1-git-send-email-saurabh.truth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-11-13 10:47 ` Wan, Kaike
2015-11-13 10:47 ` Wan, Kaike
[not found] ` <3F128C9216C9B84BB6ED23EF16290AFB1857D86D-8k97q/ur5Z2krb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-11-13 12:37 ` Saurabh Sengar
2015-11-13 12:37 ` Saurabh Sengar
2015-10-27 18:42 ` [PATCH] efi: " Saurabh Sengar
2015-10-27 18:42 ` Saurabh Sengar
2015-10-28 3:42 ` [PATCH v2] " Saurabh Sengar
[not found] ` <1446003747-3760-1-git-send-email-saurabh.truth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-11-03 16:36 ` Matt Fleming
2015-11-03 16:36 ` Matt Fleming
2015-11-03 17:38 ` [PATCH] " Saurabh Sengar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151027200012.GA7403@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=kaike.wan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=saurabh.truth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=yun.wang-EIkl63zCoXaH+58JC4qpiA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.