From: Dmitry Torokhov <dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Michael Welling <mwelling-EkmVulN54Sk@public.gmane.org>
Cc: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>,
Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>,
Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>,
Sebastian Reichel <sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Roger Quadros <rogerq-l0cyMroinI0@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2] Input: tsc2005 - Add support for tsc2004
Date: Tue, 27 Oct 2015 18:51:41 -0700 [thread overview]
Message-ID: <20151028015141.GA11237@localhost> (raw)
In-Reply-To: <1445991421-29938-1-git-send-email-mwelling-EkmVulN54Sk@public.gmane.org>
Hi Michael,
On Tue, Oct 27, 2015 at 07:17:01PM -0500, Michael Welling wrote:
> Adds support for the i2c based tsc2004. Support was added to the tsc2005 driver
> due to the similarity of the devices.
>
> Signed-off-by: Michael Welling <mwelling-EkmVulN54Sk@public.gmane.org>
> ---
> v2: Fixes Kconfig based on report for 0-day build bot.
>
> .../bindings/input/touchscreen/tsc2004.txt | 38 ++++
> drivers/input/touchscreen/Kconfig | 7 +-
> drivers/input/touchscreen/tsc2005.c | 206 ++++++++++++++++-----
Could we maybe split the code into core, spi and i2c drivers instead of
keeping everything together and rely on #ifdefs?
Thanks!
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Michael Welling <mwelling@ieee.org>
Cc: Tony Lindgren <tony@atomide.com>, Pavel Machek <pavel@ucw.cz>,
Felipe Balbi <balbi@ti.com>, Sebastian Reichel <sre@kernel.org>,
Roger Quadros <rogerq@ti.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-input@vger.kernel.org
Subject: Re: [PATCH v2] Input: tsc2005 - Add support for tsc2004
Date: Tue, 27 Oct 2015 18:51:41 -0700 [thread overview]
Message-ID: <20151028015141.GA11237@localhost> (raw)
In-Reply-To: <1445991421-29938-1-git-send-email-mwelling@ieee.org>
Hi Michael,
On Tue, Oct 27, 2015 at 07:17:01PM -0500, Michael Welling wrote:
> Adds support for the i2c based tsc2004. Support was added to the tsc2005 driver
> due to the similarity of the devices.
>
> Signed-off-by: Michael Welling <mwelling@ieee.org>
> ---
> v2: Fixes Kconfig based on report for 0-day build bot.
>
> .../bindings/input/touchscreen/tsc2004.txt | 38 ++++
> drivers/input/touchscreen/Kconfig | 7 +-
> drivers/input/touchscreen/tsc2005.c | 206 ++++++++++++++++-----
Could we maybe split the code into core, spi and i2c drivers instead of
keeping everything together and rely on #ifdefs?
Thanks!
--
Dmitry
next prev parent reply other threads:[~2015-10-28 1:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 20:36 [PATCH] Input: tsc2005 - Add support for tsc2004 Michael Welling
2015-10-27 20:49 ` Michael Welling
[not found] ` <1445978203-31264-1-git-send-email-mwelling-EkmVulN54Sk@public.gmane.org>
2015-10-27 23:34 ` kbuild test robot
2015-10-27 23:34 ` kbuild test robot
2015-10-28 0:17 ` [PATCH v2] " Michael Welling
[not found] ` <1445991421-29938-1-git-send-email-mwelling-EkmVulN54Sk@public.gmane.org>
2015-10-28 1:51 ` Dmitry Torokhov [this message]
2015-10-28 1:51 ` Dmitry Torokhov
2015-10-28 5:23 ` Michael Welling
2015-10-28 5:41 ` Dmitry Torokhov
2015-10-28 5:48 ` Michael Welling
2015-10-28 6:12 ` Dmitry Torokhov
2015-10-30 12:59 ` Arnd Bergmann
2015-10-28 4:37 ` kbuild test robot
2015-10-28 4:37 ` kbuild test robot
2015-10-28 5:38 ` Michael Welling
2015-10-28 5:45 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151028015141.GA11237@localhost \
--to=dmitry.torokhov-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=balbi-l0cyMroinI0@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mwelling-EkmVulN54Sk@public.gmane.org \
--cc=pavel-+ZI9xUNit7I@public.gmane.org \
--cc=rogerq-l0cyMroinI0@public.gmane.org \
--cc=sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.