From: Tejun Heo <htejun@gmail.com>
To: Christoph Lameter <cl@linux.com>
Cc: akpm@linux-foundation.org, Michal Hocko <mhocko@kernel.org>,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
torvalds@linux-foundation.org, hannes@cmpxchg.org,
mgorman@suse.de
Subject: Re: [patch 3/3] vmstat: Create our own workqueue
Date: Wed, 28 Oct 2015 11:43:50 +0900 [thread overview]
Message-ID: <20151028024350.GA10448@mtj.duckdns.org> (raw)
In-Reply-To: <20151028024131.719968999@linux.com>
Hello,
On Tue, Oct 27, 2015 at 09:41:17PM -0500, Christoph Lameter wrote:
> + vmstat_wq = alloc_workqueue("vmstat",
> + WQ_FREEZABLE|
> + WQ_SYSFS|
> + WQ_MEM_RECLAIM, 0);
The only thing necessary here is WQ_MEM_RECLAIM. I don't see how
WQ_SYSFS and WQ_FREEZABLE make sense here.
Thanks.
--
tejun
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <htejun@gmail.com>
To: Christoph Lameter <cl@linux.com>
Cc: akpm@linux-foundation.org, Michal Hocko <mhocko@kernel.org>,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
torvalds@linux-foundation.org, hannes@cmpxchg.org,
mgorman@suse.de
Subject: Re: [patch 3/3] vmstat: Create our own workqueue
Date: Wed, 28 Oct 2015 11:43:50 +0900 [thread overview]
Message-ID: <20151028024350.GA10448@mtj.duckdns.org> (raw)
In-Reply-To: <20151028024131.719968999@linux.com>
Hello,
On Tue, Oct 27, 2015 at 09:41:17PM -0500, Christoph Lameter wrote:
> + vmstat_wq = alloc_workqueue("vmstat",
> + WQ_FREEZABLE|
> + WQ_SYSFS|
> + WQ_MEM_RECLAIM, 0);
The only thing necessary here is WQ_MEM_RECLAIM. I don't see how
WQ_SYSFS and WQ_FREEZABLE make sense here.
Thanks.
--
tejun
next prev parent reply other threads:[~2015-10-28 2:43 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-28 2:41 [patch 0/3] vmstat: Various enhancements Christoph Lameter
2015-10-28 2:41 ` Christoph Lameter
2015-10-28 2:41 ` [patch 1/3] vmstat: Make pageset processing optional in refresh_cpu_vm_stats Christoph Lameter
2015-10-28 2:41 ` Christoph Lameter
2015-10-28 2:41 ` [patch 2/3] vmstat: make vmstat_updater deferrable again and shut down on idle Christoph Lameter
2015-10-28 2:41 ` Christoph Lameter
2015-10-28 2:41 ` [patch 3/3] vmstat: Create our own workqueue Christoph Lameter
2015-10-28 2:41 ` Christoph Lameter
2015-10-28 2:43 ` Tejun Heo [this message]
2015-10-28 2:43 ` Tejun Heo
2015-10-28 3:04 ` Christoph Lameter
2015-10-28 3:04 ` Christoph Lameter
2015-10-28 11:57 ` Tetsuo Handa
2015-10-28 11:57 ` Tetsuo Handa
2015-10-28 22:32 ` Christoph Lameter
2015-10-28 22:32 ` Christoph Lameter
2015-10-29 2:24 ` Tejun Heo
2015-10-29 2:24 ` Tejun Heo
2015-10-29 3:08 ` Tejun Heo
2015-10-29 3:08 ` Tejun Heo
2015-10-30 1:01 ` Christoph Lameter
2015-10-30 1:01 ` Christoph Lameter
2015-10-31 1:15 ` Tejun Heo
2015-10-31 1:15 ` Tejun Heo
2015-10-31 2:43 ` Tetsuo Handa
2015-10-31 2:43 ` Tetsuo Handa
2015-11-02 16:12 ` Christoph Lameter
2015-11-02 16:12 ` Christoph Lameter
2015-11-02 16:52 ` Tetsuo Handa
2015-11-02 16:52 ` Tetsuo Handa
2015-11-02 18:10 ` Christoph Lameter
2015-11-02 18:10 ` Christoph Lameter
2015-11-02 19:11 ` Tejun Heo
2015-11-02 19:11 ` Tejun Heo
2015-11-06 11:28 ` Tetsuo Handa
2015-11-06 11:28 ` Tetsuo Handa
2015-11-06 12:56 ` Christoph Lameter
2015-11-06 12:56 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151028024350.GA10448@mtj.duckdns.org \
--to=htejun@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.