All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Johan Hovold <johan@kernel.org>, Michal Marek <mmarek@suse.com>,
	Gilles Muller <Gilles.Muller@lip6.fr>,
	Nicolas Palix <nicolas.palix@imag.fr>,
	linux-kernel@vger.kernel.org, cocci@systeme.lip6.fr
Subject: Re: [PATCH] coccinelle: misc: remove "complex return code" warnings
Date: Wed, 28 Oct 2015 10:54:14 +0100	[thread overview]
Message-ID: <20151028095414.GD28572@localhost> (raw)
In-Reply-To: <alpine.DEB.2.10.1510031825170.2586@hadrien>

On Sat, Oct 03, 2015 at 06:25:39PM +0200, Julia Lawall wrote:
> Should have acked this message...
> 
> Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> 
> On Wed, 30 Sep 2015, Johan Hovold wrote:
> 
> > This effectively reverts 932058a5d5f9 ("coccinelle: misc: semantic patch
> > to delete overly complex return code processing").
> >
> > There can be both symmetry and readability reasons for not wanting to do
> > the final function call as part of the return statement and to maintain
> > a clear separation of success and error paths.
> >
> > Since this is in no way mandated by the coding standard, let's just
> > remove this semantic patch to avoid having "clean up" patches being
> > posted over and over in response to these Coccinelle warnings.
> >
> > Signed-off-by: Johan Hovold <johan@kernel.org>

Is anyone planning on picking this patch up?

Thanks,
Johan

  reply	other threads:[~2015-10-28  9:54 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-30 22:37 [Cocci] [PATCH] coccinelle: misc: remove "complex return code" warnings Johan Hovold
2015-09-30 22:37 ` Johan Hovold
2015-10-01  5:20 ` [Cocci] " Julia Lawall
2015-10-01  5:20   ` Julia Lawall
2015-10-01 17:47   ` [Cocci] " Johan Hovold
2015-10-01 17:47     ` Johan Hovold
2015-10-02 21:33     ` [Cocci] " Julia Lawall
2015-10-02 21:33       ` Julia Lawall
2015-10-04 10:50       ` [Cocci] " Johan Hovold
2015-10-04 10:50         ` Johan Hovold
2015-10-03 16:24     ` [Cocci] " Julia Lawall
2015-10-03 16:24       ` Julia Lawall
2015-10-04 10:52       ` [Cocci] " Johan Hovold
2015-10-04 10:52         ` Johan Hovold
2015-10-03 16:25 ` [Cocci] " Julia Lawall
2015-10-03 16:25   ` Julia Lawall
2015-10-28  9:54   ` Johan Hovold [this message]
2015-10-28 10:04     ` [Cocci] " Michal Marek
2015-10-28 10:04       ` Michal Marek
2015-10-28 10:09       ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151028095414.GD28572@localhost \
    --to=johan@kernel.org \
    --cc=Gilles.Muller@lip6.fr \
    --cc=cocci@systeme.lip6.fr \
    --cc=julia.lawall@lip6.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.com \
    --cc=nicolas.palix@imag.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.