From: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
To: Timur Tabi <timur-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Cc: Ard Biesheuvel
<ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Mark Salter <msalter-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
Matt Fleming
<matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Shanker Donthineni
<shankerd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Mark Langsdorf <mlangsdo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Jon Masters <jcm-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH] arm64: efi: make sure vmlinux load address aligned on 2MBytes
Date: Wed, 28 Oct 2015 11:28:39 +0000 [thread overview]
Message-ID: <20151028112839.GA24930@leverpostej> (raw)
In-Reply-To: <56302F42.4040408-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
On Tue, Oct 27, 2015 at 09:13:22PM -0500, Timur Tabi wrote:
> Ard Biesheuvel wrote:
> >No. I screwed up the patch since the trailing ) should not be there,
> >but we do need to round first, and only then add the offset.
>
> But if the offset is not a multiple of 2MB, won't the address passed
> to allocate_pages be unaligned? I'll test your patch on our system,
> but I thought the problem was that the allocated address must be
> aligned.
The kernel needs to be loaded at an address which is text_offset bytes
past a 2M-aligned base. It is not loaded at the 2M-aligned base itself.
Ard's patch correctly findd a 2M-aligned base, then adds the text
offset.
Mark.
WARNING: multiple messages have this Message-ID (diff)
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: efi: make sure vmlinux load address aligned on 2MBytes
Date: Wed, 28 Oct 2015 11:28:39 +0000 [thread overview]
Message-ID: <20151028112839.GA24930@leverpostej> (raw)
In-Reply-To: <56302F42.4040408@codeaurora.org>
On Tue, Oct 27, 2015 at 09:13:22PM -0500, Timur Tabi wrote:
> Ard Biesheuvel wrote:
> >No. I screwed up the patch since the trailing ) should not be there,
> >but we do need to round first, and only then add the offset.
>
> But if the offset is not a multiple of 2MB, won't the address passed
> to allocate_pages be unaligned? I'll test your patch on our system,
> but I thought the problem was that the allocated address must be
> aligned.
The kernel needs to be loaded at an address which is text_offset bytes
past a 2M-aligned base. It is not loaded at the 2M-aligned base itself.
Ard's patch correctly findd a 2M-aligned base, then adds the text
offset.
Mark.
next prev parent reply other threads:[~2015-10-28 11:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 21:24 [PATCH] arm64: efi: make sure vmlinux load address aligned on 2MBytes Timur Tabi
2015-10-27 21:24 ` Timur Tabi
[not found] ` <1445981041-8774-1-git-send-email-timur-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2015-10-28 2:06 ` Ard Biesheuvel
2015-10-28 2:06 ` Ard Biesheuvel
[not found] ` <CAKv+Gu_ivkemFva-Fu0E24mQqE-m0jPWBzo5OZAr7cyM08hqug-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-10-28 2:10 ` Timur Tabi
2015-10-28 2:10 ` Timur Tabi
[not found] ` <56302E7C.7000605-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2015-10-28 2:11 ` Ard Biesheuvel
2015-10-28 2:11 ` Ard Biesheuvel
[not found] ` <CAKv+Gu9t=dGoaVem+h11cXfimpEzmte36_j4tKW_h8rA8c1jBg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-10-28 2:13 ` Timur Tabi
2015-10-28 2:13 ` Timur Tabi
[not found] ` <56302F42.4040408-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2015-10-28 11:28 ` Mark Rutland [this message]
2015-10-28 11:28 ` Mark Rutland
2015-10-28 17:11 ` Timur Tabi
2015-10-28 17:11 ` Timur Tabi
[not found] ` <563101DD.8080508-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2015-10-28 17:26 ` Mark Rutland
2015-10-28 17:26 ` Mark Rutland
2015-10-28 21:02 ` Timur Tabi
2015-10-28 21:02 ` Timur Tabi
[not found] ` <563137DF.1040908-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2015-10-27 12:05 ` Mark Rutland
2015-10-27 12:05 ` Mark Rutland
2015-10-28 17:27 ` Will Deacon
2015-10-28 17:27 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151028112839.GA24930@leverpostej \
--to=mark.rutland-5wv7dgnigg8@public.gmane.org \
--cc=ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=jcm-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=mlangsdo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=msalter-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=shankerd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=timur-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.