From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Shivani Bhardwaj <shivanib134@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH v2 1/3] Staging: wilc1000: linux_wlan_sdio: Drop unneeded wrapper functions
Date: Wed, 28 Oct 2015 18:35:03 +0530 [thread overview]
Message-ID: <20151028130503.GA16810@sudip-pc> (raw)
In-Reply-To: <5a66436fde0503739c5a6e99c6cc5c9c2c2a7cbf.1446032441.git.shivanib134@gmail.com>
On Wed, Oct 28, 2015 at 05:18:21PM +0530, Shivani Bhardwaj wrote:
> Remove the functions linux_sdio_get_speed(), linux_sdio_set_max_speed()
> and linux_sdio_set_default_speed(). Replace their calls with appropriate
> functions. Also, definitions associated with these functions should be
> removed.
>
> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
> ---
You have not build tested it.
WARNING: "linux_sdio_set_default_speed" [drivers/staging/wilc1000/wilc1000.ko] undefined!
WARNING: "linux_sdio_set_max_speed" [drivers/staging/wilc1000/wilc1000.ko] undefined!
We have:
wilc1000/linux_wlan.c: nwi->io_func.u.sdio.sdio_set_default_speed = linux_sdio_set_default_speed;
and also:
nwi->io_func.u.sdio.sdio_set_max_speed = linux_sdio_set_max_speed;
regards
sudip
next prev parent reply other threads:[~2015-10-28 13:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-28 11:47 [PATCH v2 0/3] Drop wrapper functions and clean up the code Shivani Bhardwaj
2015-10-28 11:48 ` [PATCH v2 1/3] Staging: wilc1000: linux_wlan_sdio: Drop unneeded wrapper functions Shivani Bhardwaj
2015-10-28 13:05 ` Sudip Mukherjee [this message]
2015-10-28 11:48 ` [PATCH v2 2/3] Staging: wilc1000: linux_wlan_sdio: Remove unnecessary blank lines Shivani Bhardwaj
2015-10-28 11:49 ` [PATCH v2 3/3] Staging: wilc1000: linux_wlan: Replace function calls Shivani Bhardwaj
2015-10-28 13:10 ` [Outreachy kernel] " Sudip Mukherjee
2015-10-28 16:09 ` Shivani Bhardwaj
2015-10-28 16:58 ` Shivani Bhardwaj
2015-10-29 5:41 ` Sudip Mukherjee
2015-10-28 13:48 ` Julia Lawall
2015-10-28 16:07 ` Shivani Bhardwaj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151028130503.GA16810@sudip-pc \
--to=sudipm.mukherjee@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
--cc=shivanib134@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.