Re: [Outreachy kernel] [PATCH v2 3/3] Staging: wilc1000: linux_wlan: Replace function calls

[Sudip Mukherjee <sudipm.mukherjee@gmail.com>]

On Wed, Oct 28, 2015 at 10:28:29PM +0530, Shivani Bhardwaj wrote:
> On Wed, Oct 28, 2015 at 9:39 PM, Shivani Bhardwaj <shivanib134@gmail.com>
> wrote:
> > On Wed, Oct 28, 2015 at 6:40 PM, Sudip Mukherjee
> > <sudipm.mukherjee@gmail.com> wrote:
> >> On Wed, Oct 28, 2015 at 05:19:04PM +0530, Shivani Bhardwaj wrote:
> >>> Replace calls to wrapper functions with the actual functions called by
> >>> wrapper functions. Definitions needed to make those calls should also
> be added.
> >>>
> >>> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
> >>> ---
> >>
> >> Not build tested. :(
> >>
> >> error: implicit declaration of function ‘linux_sdio_set_speed’
> [-Werror=implicit-function-declaration]
> >>   nwi->io_func.u.sdio.sdio_set_max_speed =
> linux_sdio_set_speed(MAX_SPEED);
> >>
> >> drivers/staging/wilc1000/linux_wlan.c:990:41: warning: assignment makes
> pointer from integer without a cast [enabled by default]
> >>   nwi->io_func.u.sdio.sdio_set_max_speed =
> linux_sdio_set_speed(MAX_SPEED);
> >>
> >> drivers/staging/wilc1000/linux_wlan.c:991:68: error:
> ‘sdio_default_speed’ undeclared (first use in this function)
> >>
> >> regards
> >> sudip
> >
> > I'm really very sorry I didn't do make allmodconfig, make didn't show
> > me any errors at that time. In order to fix these mistakes, I'm
> > thinking of changing some part of code. Please check the next version.
> > Thank you
> 
> I need a bit of help here. While replacing the calls of wrapper function by
> actual function, I get the following:
> warning: assignment makes pointer from integer without a cast
> 
> Why is it like that? Wrapper function returns function which in turn
> returns an integer so ultimately the value that is to be returned is int.
> 
> I think I'm missing something trivial. I don't know what.

When it is doing nwi->io_func.u.sdio.sdio_set_max_speed = linux_sdio_set_max_speed;
it is saving the address of the function linux_sdio_set_max_speed in
nwi->io_func.u.sdio.sdio_set_max_speed.
But when you are doing:
nwi->io_func.u.sdio.sdio_set_max_speed = linux_sdio_set_speed(MAX_SPEED);
you are trying to save the speed value in a place where the function
pointer is supposed to stay.

If you want to remove this wrapper, then you can do:
nwi->io_func.u.sdio.sdio_set_max_speed = linux_sdio_set_speed;

and then in all places where nwi->io_func.u.sdio.sdio_set_max_speed is
used you need to modify that to use MAX_SPEED as argument.

But I guess that will make the code less readable.

regards
sudip