From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Wang Nan <wangnan0@huawei.com>,
ast@kernel.org, brendan.d.gregg@gmail.com, jolsa@kernel.org,
lizefan@huawei.com, pi3orama@163.com, davem@davemloft.net,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Alexei Starovoitov <ast@plumgrid.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [RFC PATCH net-next 1/4] perf tools: Enable pre-event inherit setting by config terms
Date: Wed, 28 Oct 2015 10:44:20 -0300 [thread overview]
Message-ID: <20151028134420.GA17877@kernel.org> (raw)
In-Reply-To: <20151028134213.GC18670@kernel.org>
Em Wed, Oct 28, 2015 at 10:42:13AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Wed, Oct 28, 2015 at 02:21:26PM +0100, Jiri Olsa escreveu:
> > On Wed, Oct 28, 2015 at 10:55:02AM +0000, Wang Nan wrote:
> > > @@ -55,6 +56,7 @@ struct perf_evsel_config_term {
> > > bool time;
> > > char *callgraph;
> > > u64 stack_user;
> > > + u64 inherit;
> >
> > seems like bool would be enough
>
> Ok, will change this and move it to a more suitable place member
> alignment wise.
Nah, switched it to bool, but no need to move it around, that is an
union...
> Can I, with this change, slap an Acked-by: jirka?
>
> - Arnaldo
next prev parent reply other threads:[~2015-10-28 13:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-28 10:55 [RFC PATCH net-next 0/4] perf tools: Support receiving output through BPF programs Wang Nan
2015-10-28 10:55 ` [RFC PATCH net-next 1/4] perf tools: Enable pre-event inherit setting by config terms Wang Nan
2015-10-28 13:21 ` Jiri Olsa
2015-10-28 13:42 ` Arnaldo Carvalho de Melo
2015-10-28 13:44 ` Arnaldo Carvalho de Melo [this message]
2015-10-28 14:17 ` Jiri Olsa
2015-10-29 9:42 ` [tip:perf/core] " tip-bot for Wang Nan
2015-10-28 10:55 ` [RFC PATCH net-next 2/4] perf tools: Introduce bpf-output event Wang Nan
2015-10-28 13:13 ` Sergei Shtylyov
2015-10-28 10:55 ` [RFC PATCH net-next 3/4] perf data: Add u32_hex data type Wang Nan
2015-10-28 10:55 ` [RFC PATCH net-next 4/4] perf data: Support converting data from bpf_perf_event_output() Wang Nan
2015-10-28 11:03 ` [RFC PATCH net-next 0/4] perf tools: Support receiving output through BPF programs Wangnan (F)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151028134420.GA17877@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=ast@kernel.org \
--cc=ast@plumgrid.com \
--cc=brendan.d.gregg@gmail.com \
--cc=davem@davemloft.net \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pi3orama@163.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.