All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Bogicevic Sasa <brutallesale@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] drivers:staging:gdm724x Fix Alignment should match open parenthesis
Date: Wed, 28 Oct 2015 21:53:30 +0300	[thread overview]
Message-ID: <20151028185330.GC18797@mwanda> (raw)
In-Reply-To: <1446056004-6092-1-git-send-email-brutallesale@gmail.com>

On Wed, Oct 28, 2015 at 07:13:24PM +0100, Bogicevic Sasa wrote:
> This fixes all Alignment should match open parenthesis
> messages from checkpatch.pl
> 
> Signed-off-by: Bogicevic Sasa <brutallesale@gmail.com>
> ---
>  drivers/staging/gdm724x/gdm_lte.c | 69 +++++++++++++++++++++++++--------------
>  1 file changed, 45 insertions(+), 24 deletions(-)
> 
> diff --git a/drivers/staging/gdm724x/gdm_lte.c b/drivers/staging/gdm724x/gdm_lte.c
> index a8d2cff..a28e0d1 100644
> --- a/drivers/staging/gdm724x/gdm_lte.c
> +++ b/drivers/staging/gdm724x/gdm_lte.c
> @@ -161,12 +161,15 @@ static int gdm_lte_emulate_arp(struct sk_buff *skb_in, u32 nic_type)
>  		return -ENOMEM;
>  	skb_reserve(skb_out, NET_IP_ALIGN);
>  
> -	memcpy(skb_put(skb_out, mac_header_len), mac_header_data,
> +	memcpy(
> +		skb_put(skb_out, mac_header_len), mac_header_data,
>  		mac_header_len);

No.  This isn't the right way.  Look at other code to see how it's done.

regards,
dan carpenter


      parent reply	other threads:[~2015-10-28 18:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-28 18:13 [PATCH 2/2] drivers:staging:gdm724x Fix Alignment should match open parenthesis Bogicevic Sasa
2015-10-28 18:23 ` Joe Perches
2015-10-28 18:53 ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151028185330.GC18797@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=brutallesale@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.