* [PATCH 2/2] Staging: lustre: console: Remove irrelevant return statement
@ 2015-10-29 6:20 Shivani Bhardwaj
0 siblings, 0 replies; 2+ messages in thread
From: Shivani Bhardwaj @ 2015-10-29 6:20 UTC (permalink / raw)
To: outreachy-kernel
Remove return statement from the function lstcon_group_ndlink_move()
as its return type is void.
Fix checkpatch WARNING: void function return statements are not
generally useful
Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
---
drivers/staging/lustre/lnet/selftest/console.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/lustre/lnet/selftest/console.c b/drivers/staging/lustre/lnet/selftest/console.c
index 9748a09..b1eceb4 100644
--- a/drivers/staging/lustre/lnet/selftest/console.c
+++ b/drivers/staging/lustre/lnet/selftest/console.c
@@ -318,8 +318,6 @@ lstcon_group_ndlink_move(lstcon_group_t *old,
list_add_tail(&ndl->ndl_hlink, &new->grp_ndl_hash[idx]);
list_add_tail(&ndl->ndl_link, &new->grp_ndl_list);
new->grp_nnode++;
-
- return;
}
static void
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH 0/2] Remove unnecessary functions and clean up the code
@ 2015-10-29 5:31 Shivani Bhardwaj
2015-10-29 5:32 ` [PATCH 2/2] Staging: lustre: console: Remove irrelevant return statement Shivani Bhardwaj
0 siblings, 1 reply; 2+ messages in thread
From: Shivani Bhardwaj @ 2015-10-29 5:31 UTC (permalink / raw)
To: outreachy-kernel; +Cc: outreachy-kernel
This patchset removes an unnecessary wrapper function and replaces its
calls with appropriate function. Also, an unnecessary return statement
is removed.
After applying this patchset, code becomes cleaner.
Shivani Bhardwaj (2):
Staging: lustre: console: Drop unnecessary wrapper function
Staging: lustre: console: Remove irrelevant return statement
drivers/staging/lustre/lnet/selftest/console.c | 80 ++++++++++++--------------
1 file changed, 36 insertions(+), 44 deletions(-)
--
2.1.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH 2/2] Staging: lustre: console: Remove irrelevant return statement
2015-10-29 5:31 [PATCH 0/2] Remove unnecessary functions and clean up the code Shivani Bhardwaj
@ 2015-10-29 5:32 ` Shivani Bhardwaj
0 siblings, 0 replies; 2+ messages in thread
From: Shivani Bhardwaj @ 2015-10-29 5:32 UTC (permalink / raw)
To: outreachy-kernel; +Cc: outreachy-kernel
Remove return statement from the function lstcon_group_ndlink_move()
as its return type is void.
Fix checkpatch WARNING: void function return statements are not
generally useful
Signed-off-by : Shivani Bhardwaj <shivanib134@gmail.com>
---
drivers/staging/lustre/lnet/selftest/console.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/lustre/lnet/selftest/console.c b/drivers/staging/lustre/lnet/selftest/console.c
index 9748a09..b1eceb4 100644
--- a/drivers/staging/lustre/lnet/selftest/console.c
+++ b/drivers/staging/lustre/lnet/selftest/console.c
@@ -318,8 +318,6 @@ lstcon_group_ndlink_move(lstcon_group_t *old,
list_add_tail(&ndl->ndl_hlink, &new->grp_ndl_hash[idx]);
list_add_tail(&ndl->ndl_link, &new->grp_ndl_list);
new->grp_nnode++;
-
- return;
}
static void
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-29 6:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-29 6:20 [PATCH 2/2] Staging: lustre: console: Remove irrelevant return statement Shivani Bhardwaj
-- strict thread matches above, loose matches on Subject: below --
2015-10-29 5:31 [PATCH 0/2] Remove unnecessary functions and clean up the code Shivani Bhardwaj
2015-10-29 5:32 ` [PATCH 2/2] Staging: lustre: console: Remove irrelevant return statement Shivani Bhardwaj
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.