From: Lukasz Majewski <l.majewski@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] Exynos4412: pinmux: disable pull for MMC pins
Date: Thu, 29 Oct 2015 18:12:53 +0100 [thread overview]
Message-ID: <20151029181253.7829b0fc@amdc2363> (raw)
In-Reply-To: <1446043310-21519-1-git-send-email-p.marczak@samsung.com>
Hi Przemyslaw,
> There are 8 pins for SD card in Exynos, but the MUX was configured
> only for 7, since the one was used for card detection.
> This caused the pin's pull wrong configuration.
>
> This commit fixes this and the card detect can work properly,
> after call this function.
>
> Tested-on: Odroid U3 and Odroid X2.
>
> Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com>
> Cc: Guillaume GARDET <guillaume.gardet@free.fr>
> Cc: Lukasz Majewski <l.majewski@samsung.com>
> Cc: Jaehoon Chung <jh80.chung@samsung.com>
> Cc: Minkyu Kang <mk7.kang@samsung.com>
> Cc: Simon Glass <sjg@chromium.org>
> ---
> arch/arm/mach-exynos/pinmux.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-exynos/pinmux.c
> b/arch/arm/mach-exynos/pinmux.c index 179b294..925bd0a 100644
> --- a/arch/arm/mach-exynos/pinmux.c
> +++ b/arch/arm/mach-exynos/pinmux.c
> @@ -737,10 +737,10 @@ static int exynos4x12_mmc_config(int
> peripheral, int flags) return -1;
> }
> for (i = start; i < (start + 7); i++) {
> + gpio_set_pull(i, S5P_GPIO_PULL_NONE);
> if (i == (start + 2))
> continue;
> gpio_cfg_pin(i, func);
> - gpio_set_pull(i, S5P_GPIO_PULL_NONE);
> gpio_set_drv(i, S5P_GPIO_DRV_4X);
> }
> if (flags & PINMUX_FLAG_8BIT_MODE) {
Tested-by: Lukasz Majewski <l.majewski@samsung.com>
Test HW: Exynos 4210 - Trats board.
--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
next prev parent reply other threads:[~2015-10-29 17:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-28 14:41 [U-Boot] [PATCH 1/2] Exynos4412: pinmux: disable pull for MMC pins Przemyslaw Marczak
2015-10-28 14:41 ` [U-Boot] [PATCH 2/2] s5p sdhci: call pinmux for card's gpio pins before use them Przemyslaw Marczak
2015-10-29 7:29 ` Jaehoon Chung
2015-10-29 17:13 ` Lukasz Majewski
2015-11-02 5:37 ` Minkyu Kang
2015-10-29 7:29 ` [U-Boot] [PATCH 1/2] Exynos4412: pinmux: disable pull for MMC pins Jaehoon Chung
2015-10-29 17:12 ` Lukasz Majewski [this message]
2015-11-02 5:37 ` Minkyu Kang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151029181253.7829b0fc@amdc2363 \
--to=l.majewski@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.