All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Nitin Gupta <nitin.m.gupta@oracle.com>
Cc: sparclinux <sparclinux@vger.kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Andrew Morton <akpm@linux-foundation.org>,
	Chris Hyser <chris.hyser@oracle.com>,
	Khalid Aziz <khalid.aziz@oracle.com>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	David Hildenbrand <dahi@linux.vnet.ibm.com>,
	Tony Luck <tony.luck@intel.com>,
	Santosh Shilimkar <santosh.shilimkar@oracle.com>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sparc64: Fix numa distance values
Date: Thu, 29 Oct 2015 18:50:56 +0000	[thread overview]
Message-ID: <20151029185056.GA398@ravnborg.org> (raw)
In-Reply-To: <1446077026-5598-1-git-send-email-nitin.m.gupta@oracle.com>

Small nit.

> diff --git a/arch/sparc/include/asm/topology_64.h b/arch/sparc/include/asm/topology_64.h
> index 01d1704..ed3dfdd 100644
> --- a/arch/sparc/include/asm/topology_64.h
> +++ b/arch/sparc/include/asm/topology_64.h
> @@ -31,6 +31,9 @@ static inline int pcibus_to_node(struct pci_bus *pbus)
>  	 cpu_all_mask : \
>  	 cpumask_of_node(pcibus_to_node(bus)))
>  
> +extern int __node_distance(int, int);
We have dropped using "extern" for function prototypes.

> +#define node_distance(a, b) __node_distance(a, b)

And had this be written as:
#define node_distance node_distance
int node_distance(int, int);

Then there had been no need for the leadign underscores.

But as I said - only nits.

	Sam

WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Nitin Gupta <nitin.m.gupta@oracle.com>
Cc: sparclinux <sparclinux@vger.kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Andrew Morton <akpm@linux-foundation.org>,
	Chris Hyser <chris.hyser@oracle.com>,
	Khalid Aziz <khalid.aziz@oracle.com>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	David Hildenbrand <dahi@linux.vnet.ibm.com>,
	Tony Luck <tony.luck@intel.com>,
	Santosh Shilimkar <santosh.shilimkar@oracle.com>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sparc64: Fix numa distance values
Date: Thu, 29 Oct 2015 19:50:56 +0100	[thread overview]
Message-ID: <20151029185056.GA398@ravnborg.org> (raw)
In-Reply-To: <1446077026-5598-1-git-send-email-nitin.m.gupta@oracle.com>

Small nit.

> diff --git a/arch/sparc/include/asm/topology_64.h b/arch/sparc/include/asm/topology_64.h
> index 01d1704..ed3dfdd 100644
> --- a/arch/sparc/include/asm/topology_64.h
> +++ b/arch/sparc/include/asm/topology_64.h
> @@ -31,6 +31,9 @@ static inline int pcibus_to_node(struct pci_bus *pbus)
>  	 cpu_all_mask : \
>  	 cpumask_of_node(pcibus_to_node(bus)))
>  
> +extern int __node_distance(int, int);
We have dropped using "extern" for function prototypes.

> +#define node_distance(a, b) __node_distance(a, b)

And had this be written as:
#define node_distance node_distance
int node_distance(int, int);

Then there had been no need for the leadign underscores.

But as I said - only nits.

	Sam

  reply	other threads:[~2015-10-29 18:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-29  0:03 [PATCH] sparc64: Fix numa distance values Nitin Gupta
2015-10-29  0:03 ` Nitin Gupta
2015-10-29 18:50 ` Sam Ravnborg [this message]
2015-10-29 18:50   ` Sam Ravnborg
2015-10-29 22:46   ` Nitin Gupta
2015-10-29 22:46     ` Nitin Gupta
2015-11-02 21:30 ` Nitin Gupta
2015-11-02 21:30   ` Nitin Gupta
2015-11-04 20:15   ` David Miller
2015-11-04 20:15     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151029185056.GA398@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=akpm@linux-foundation.org \
    --cc=chris.hyser@oracle.com \
    --cc=dahi@linux.vnet.ibm.com \
    --cc=davem@davemloft.net \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=khalid.aziz@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nitin.m.gupta@oracle.com \
    --cc=santosh.shilimkar@oracle.com \
    --cc=sparclinux@vger.kernel.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.