From: Wolfram Sang <wsa@the-dreams.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Simon <horms@verge.net.au>, Linux I2C <linux-i2c@vger.kernel.org>,
Magnus <magnus.damm@gmail.com>,
Linux-sh list <linux-sh@vger.kernel.org>
Subject: Re: [PATCH] i2c: rcar: call rcar_i2c_init() after pm_runtime_get_sync()
Date: Thu, 29 Oct 2015 20:17:40 +0100 [thread overview]
Message-ID: <20151029191740.GC8992@katana> (raw)
In-Reply-To: <CAMuHMdXnMFh5umv=wJdvrcMip+DOn8rYP_3eUTufFw4q2Sr8Jw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 301 bytes --]
> Hence now it's done again for every transfer?
>
> What about moving it just before the call to i2c_add_numbered_adapter(),
> and wrapping it inside pm_runtime_get_sync(dev)/pm_runtime_put()?
>
> Wolfram, what do you think?
I'd prefer the latter. Sending a tested patch in a second...
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Simon <horms@verge.net.au>, Linux I2C <linux-i2c@vger.kernel.org>,
Magnus <magnus.damm@gmail.com>,
Linux-sh list <linux-sh@vger.kernel.org>
Subject: Re: [PATCH] i2c: rcar: call rcar_i2c_init() after pm_runtime_get_sync()
Date: Thu, 29 Oct 2015 19:17:40 +0000 [thread overview]
Message-ID: <20151029191740.GC8992@katana> (raw)
In-Reply-To: <CAMuHMdXnMFh5umv=wJdvrcMip+DOn8rYP_3eUTufFw4q2Sr8Jw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 301 bytes --]
> Hence now it's done again for every transfer?
>
> What about moving it just before the call to i2c_add_numbered_adapter(),
> and wrapping it inside pm_runtime_get_sync(dev)/pm_runtime_put()?
>
> Wolfram, what do you think?
I'd prefer the latter. Sending a tested patch in a second...
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-10-29 19:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-29 9:37 [PATCH] i2c: rcar: call rcar_i2c_init() after pm_runtime_get_sync() Kuninori Morimoto
2015-10-29 11:32 ` Geert Uytterhoeven
2015-10-29 11:32 ` Geert Uytterhoeven
2015-10-29 19:17 ` Wolfram Sang [this message]
2015-10-29 19:17 ` Wolfram Sang
2015-10-30 0:13 ` Kuninori Morimoto
2015-10-30 8:04 ` Geert Uytterhoeven
2015-10-30 8:04 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151029191740.GC8992@katana \
--to=wsa@the-dreams.de \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.