All of lore.kernel.org
 help / color / mirror / Atom feed
From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH] nvme: prepare support for Apple NVMe controller
Date: Thu, 29 Oct 2015 20:31:15 +0000	[thread overview]
Message-ID: <20151029203115.GA12930@localhost.localdomain> (raw)
In-Reply-To: <1765c91018bf3b7840ce79d9b51762e8@localhost>

On Thu, Oct 29, 2015@08:46:38PM +0100, Stephan G?nther wrote:
> On 2015/October/29 09:10, Jon Derrick wrote:
> > Christoph recently added a quirks mechanism where I think it would fit
> 
> To be honest we don't know what mechanism you are referring to. Please 
> give us pointer.

It's new, not merged in an official tree. A copy is on the mailing list
somewhere. I committed it to my personal tree here:

http://git.infradead.org/users/kbusch/linux-nvme.git/commitdiff/e43f1dc5d9f31380090cc6b67fd3fa43a15089e6
 
> I assume that we concur that this workaround--as well as making the nvme 
> driver claim the Apple controller--should be a runtime-decisions based 
> on the device id. That avoids both penalties in terms of cpu cycles and 
> the tedious manual binding.

Just append the Vendor + Device to struct pci_device_id nvme_id_table
if the 64 bit register access really is the only problem preventing it
from working in an NVMe compliant way. You can check at run time for
the lo_hi_[read/write]q quirk.

If it really works with only this one change to the nvme driver, I also
wonder Apple typo'ed their class code.

  reply	other threads:[~2015-10-29 20:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-29 14:38 [PATCH] nvme: prepare support for Apple NVMe controller Stephan Günther
2015-10-29 15:10 ` Jon Derrick
2015-10-29 16:36   ` Vedant Lath
2015-10-29 17:59     ` Stephan Günther
2015-10-31 22:34       ` Vedant Lath
2015-10-29 19:46   ` Stephan Günther
2015-10-29 20:31     ` Keith Busch [this message]
2015-10-29 20:41       ` Stephan Günther
2015-11-03 13:02   ` Christoph Hellwig
2015-11-03 20:43     ` Stephan Günther

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151029203115.GA12930@localhost.localdomain \
    --to=keith.busch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.