* Question regarding patches
@ 2015-10-30 14:07 Shraddha Barke
2015-10-30 14:16 ` [Outreachy kernel] " Julia Lawall
2015-10-30 14:18 ` Greg KH
0 siblings, 2 replies; 3+ messages in thread
From: Shraddha Barke @ 2015-10-30 14:07 UTC (permalink / raw)
To: outreachy-kernel
[-- Attachment #1.1: Type: text/plain, Size: 242 bytes --]
I want to do 2 changes in same header file - 1. Remove unused functions and
2. Remove the function declarations of static functions.
Should I split this up into separate patches considering that it is the
same header?
Thanks,
Shraddha
[-- Attachment #1.2: Type: text/html, Size: 280 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] Question regarding patches
2015-10-30 14:07 Question regarding patches Shraddha Barke
@ 2015-10-30 14:16 ` Julia Lawall
2015-10-30 14:18 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Julia Lawall @ 2015-10-30 14:16 UTC (permalink / raw)
To: Shraddha Barke; +Cc: outreachy-kernel
On Fri, 30 Oct 2015, Shraddha Barke wrote:
> I want to do 2 changes in same header file - 1. Remove unused functions and
> 2. Remove the function declarations of static functions.
> Should I split this up into separate patches considering that it is the same
> header?
Yes. If the functions seem completely unrelated, you might want to make
one patch per function. But if they are similar, they could be done at
once.
julia
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] Question regarding patches
2015-10-30 14:07 Question regarding patches Shraddha Barke
2015-10-30 14:16 ` [Outreachy kernel] " Julia Lawall
@ 2015-10-30 14:18 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2015-10-30 14:18 UTC (permalink / raw)
To: Shraddha Barke; +Cc: outreachy-kernel
On Fri, Oct 30, 2015 at 07:07:18AM -0700, Shraddha Barke wrote:
> I want to do 2 changes in same header file - 1. Remove unused functions and 2.
> Remove the function declarations of static functions.
> Should I split this up into separate patches considering that it is the same
> header?
Yes, make it a patch series, showing which patch should be applied in
which order.
hope this helps,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-30 14:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-30 14:07 Question regarding patches Shraddha Barke
2015-10-30 14:16 ` [Outreachy kernel] " Julia Lawall
2015-10-30 14:18 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.