From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH v3 net] i40e: Look up MAC address in Open Firmware or IDPROM
Date: Fri, 30 Oct 2015 14:12:54 -0400 [thread overview]
Message-ID: <20151030181254.GC32759@oracle.com> (raw)
In-Reply-To: <CAHp75Vc-swMap+Umong1WVfL-fQNNZ9QEXvrHCJXCte1g_h_KA@mail.gmail.com>
On (10/30/15 20:06), Andy Shevchenko wrote:
>
> > +#include "i40e.h"
>
> Why do you need this one exactly?
I needed it to find pf->pdev below.
> > + struct device_node *dp = pci_device_to_OF_node(pf->pdev);
Without it, you will get:
:
CC [M] drivers/net/ethernet/intel/i40e/i40e_common.o
drivers/net/ethernet/intel/i40e/i40e_common.c: In function ?i40e_get_platform_mac_addr?:
drivers/net/ethernet/intel/i40e/i40e_common.c:1021: error: dereferencing pointer to incomplete type
Unless you feel passionately about the \n nits, I'm going to pass on those.
Thanks for reviewing.
--Sowmini
WARNING: multiple messages have this Message-ID (diff)
From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
jeffrey.t.kirsher@intel.com, jesse.brandeburg@intel.com,
shannon.nelson@intel.com, carolyn.wyborny@intel.com,
donald.c.skidmore@intel.com, matthew.vick@intel.com,
john.ronciak@intel.com, mitch.a.williams@intel.com
Subject: Re: [PATCH v3 net] i40e: Look up MAC address in Open Firmware or IDPROM
Date: Fri, 30 Oct 2015 14:12:54 -0400 [thread overview]
Message-ID: <20151030181254.GC32759@oracle.com> (raw)
In-Reply-To: <CAHp75Vc-swMap+Umong1WVfL-fQNNZ9QEXvrHCJXCte1g_h_KA@mail.gmail.com>
On (10/30/15 20:06), Andy Shevchenko wrote:
>
> > +#include "i40e.h"
>
> Why do you need this one exactly?
I needed it to find pf->pdev below.
> > + struct device_node *dp = pci_device_to_OF_node(pf->pdev);
Without it, you will get:
:
CC [M] drivers/net/ethernet/intel/i40e/i40e_common.o
drivers/net/ethernet/intel/i40e/i40e_common.c: In function ?i40e_get_platform_mac_addr?:
drivers/net/ethernet/intel/i40e/i40e_common.c:1021: error: dereferencing pointer to incomplete type
Unless you feel passionately about the \n nits, I'm going to pass on those.
Thanks for reviewing.
--Sowmini
next prev parent reply other threads:[~2015-10-30 18:12 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-30 15:03 [Intel-wired-lan] [PATCH v3 net] i40e: Look up MAC address in Open Firmware or IDPROM Sowmini Varadhan
2015-10-30 15:03 ` Sowmini Varadhan
2015-10-30 18:06 ` [Intel-wired-lan] " Andy Shevchenko
2015-10-30 18:06 ` Andy Shevchenko
2015-10-30 18:12 ` Sowmini Varadhan [this message]
2015-10-30 18:12 ` Sowmini Varadhan
2015-10-30 18:20 ` [Intel-wired-lan] " Andy Shevchenko
2015-10-30 18:20 ` Andy Shevchenko
2015-10-30 18:28 ` [Intel-wired-lan] " Nelson, Shannon
2015-10-30 18:28 ` Nelson, Shannon
2015-10-30 18:36 ` [Intel-wired-lan] " Sowmini Varadhan
2015-10-30 18:36 ` Sowmini Varadhan
2015-10-30 18:57 ` [Intel-wired-lan] " Nelson, Shannon
2015-10-30 18:57 ` Nelson, Shannon
2015-10-30 19:24 ` [Intel-wired-lan] " Sowmini Varadhan
2015-10-30 19:24 ` Sowmini Varadhan
2015-10-30 22:03 ` [Intel-wired-lan] " Nelson, Shannon
2015-10-30 22:03 ` Nelson, Shannon
2015-10-30 23:13 ` [Intel-wired-lan] " Sowmini Varadhan
2015-10-30 23:13 ` Sowmini Varadhan
2015-11-01 16:24 ` [Intel-wired-lan] " Sowmini Varadhan
2015-11-01 16:24 ` Sowmini Varadhan
2015-11-01 21:03 ` [Intel-wired-lan] " Nelson, Shannon
2015-11-01 21:03 ` Nelson, Shannon
2015-11-02 0:07 ` Sowmini Varadhan
2015-11-02 17:26 ` Nelson, Shannon
2015-11-02 19:57 ` Sowmini Varadhan
2015-11-04 19:26 ` Sowmini Varadhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151030181254.GC32759@oracle.com \
--to=sowmini.varadhan@oracle.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.