From: Dan Carpenter <dan.carpenter@oracle.com>
To: lustre-devel@lists.lustre.org
Subject: [lustre-devel] [PATCH 1/3] staging: lustre: checkpatch cleanups for nidstring.c
Date: Mon, 2 Nov 2015 17:48:38 +0300 [thread overview]
Message-ID: <20151102144837.GG18797@mwanda> (raw)
In-Reply-To: <229dae23c2f34950a21db4bd6dbdcfba@EXCHCS32.ornl.gov>
Yeah. That is often the fastest way to fix all the checkpatch warnings.
Checkpatch warnings are pretty mechanical. Just send like 100 patches
at a time until everything is fixed. Don't overthink. Say your patch
breaks the alignment then you have to fix that, but otherwise only fix
one thing at a time. Sometimes people will ask you to fix something
else on the same line, but just say "I didn't introduce that, but yes I
am planning to fix that in a later patchset since I am following the
one thing per patch rule."
Don't feel shame about sending many small patches. We pretty much merge
everything.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Simmons, James A." <simmonsja@ornl.gov>
Cc: "'Greg Kroah-Hartman'" <gregkh@linuxfoundation.org>,
James Simmons <jsimmons@infradead.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
Oleg Drokin <oleg.drokin@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"lustre-devel@lists.lustre.org" <lustre-devel@lists.lustre.org>
Subject: Re: [lustre-devel] [PATCH 1/3] staging: lustre: checkpatch cleanups for nidstring.c
Date: Mon, 2 Nov 2015 17:48:38 +0300 [thread overview]
Message-ID: <20151102144837.GG18797@mwanda> (raw)
In-Reply-To: <229dae23c2f34950a21db4bd6dbdcfba@EXCHCS32.ornl.gov>
Yeah. That is often the fastest way to fix all the checkpatch warnings.
Checkpatch warnings are pretty mechanical. Just send like 100 patches
at a time until everything is fixed. Don't overthink. Say your patch
breaks the alignment then you have to fix that, but otherwise only fix
one thing at a time. Sometimes people will ask you to fix something
else on the same line, but just say "I didn't introduce that, but yes I
am planning to fix that in a later patchset since I am following the
one thing per patch rule."
Don't feel shame about sending many small patches. We pretty much merge
everything.
regards,
dan carpenter
next prev parent reply other threads:[~2015-11-02 14:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-29 23:28 [lustre-devel] [PATCH 0/3] make nidstring.c kernel style compliant James Simmons
2015-10-29 23:28 ` James Simmons
2015-10-29 23:28 ` [lustre-devel] [PATCH 1/3] staging: lustre: checkpatch cleanups for nidstring.c James Simmons
2015-10-29 23:28 ` James Simmons
2015-10-30 7:50 ` [lustre-devel] " Sudip Mukherjee
2015-10-30 7:50 ` Sudip Mukherjee
2015-10-30 23:01 ` [lustre-devel] " Greg Kroah-Hartman
2015-10-30 23:01 ` Greg Kroah-Hartman
2015-11-01 23:07 ` [lustre-devel] " Simmons, James A.
2015-11-01 23:07 ` Simmons, James A.
2015-11-01 23:24 ` Michael Shuey
2015-11-01 23:24 ` Michael Shuey
2015-11-02 14:48 ` Dan Carpenter [this message]
2015-11-02 14:48 ` Dan Carpenter
2015-11-03 23:56 ` Simmons, James A.
2015-11-03 23:56 ` Simmons, James A.
2015-10-29 23:28 ` [lustre-devel] [PATCH 2/3] staging: lustre: white space " James Simmons
2015-10-29 23:28 ` James Simmons
2015-10-29 23:28 ` [lustre-devel] [PATCH 3/3] staging: lustre: checkpatch cleanups for nidstr.h James Simmons
2015-10-29 23:28 ` James Simmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151102144837.GG18797@mwanda \
--to=dan.carpenter@oracle.com \
--cc=lustre-devel@lists.lustre.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.