Re: [Outreachy kernel] [PATCH] Staging: lustre: linux-cpu: Remove unnecessary wrapper functions

[Greg KH <gregkh@linuxfoundation.org>]

On Mon, Nov 02, 2015 at 10:11:19PM +0530, Shivani Bhardwaj wrote:
> Remove the functions cfs_cpu_core_siblings(), cfs_cpu_ht_siblings(),
> cfs_node_to_cpumask() and replace their calls with the functions they
> wrapped.
> 
> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
> ---
>  .../staging/lustre/lustre/libcfs/linux/linux-cpu.c | 30 +++++-----------------
>  1 file changed, 7 insertions(+), 23 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/libcfs/linux/linux-cpu.c b/drivers/staging/lustre/lustre/libcfs/linux/linux-cpu.c
> index 2097364..31719af 100644
> --- a/drivers/staging/lustre/lustre/libcfs/linux/linux-cpu.c
> +++ b/drivers/staging/lustre/lustre/libcfs/linux/linux-cpu.c
> @@ -78,23 +78,6 @@ struct cfs_cpt_data {
>  
>  static struct cfs_cpt_data	cpt_data;
>  
> -static void cfs_cpu_core_siblings(int cpu, cpumask_t *mask)
> -{
> -	/* return cpumask of cores in the same socket */
> -	cpumask_copy(mask, topology_core_cpumask(cpu));
> -}
> -
> -/* return cpumask of HTs in the same core */
> -static void cfs_cpu_ht_siblings(int cpu, cpumask_t *mask)
> -{
> -	cpumask_copy(mask, topology_sibling_cpumask(cpu));
> -}
> -
> -static void cfs_node_to_cpumask(int node, cpumask_t *mask)
> -{
> -	cpumask_copy(mask, cpumask_of_node(node));
> -}
> 

Please remove one of these at a time, it makes it much easier to review
the patch.

thanks,

greg k-h