From: Greg KH <gregkh@linuxfoundation.org>
To: Shivani Bhardwaj <shivanib134@gmail.com>
Cc: outreachy-kernel <outreachy-kernel@googlegroups.com>
Subject: Re: [Outreachy kernel] [PATCH] Staging: lustre: linux-cpu: Remove unnecessary wrapper functions
Date: Mon, 2 Nov 2015 08:59:10 -0800 [thread overview]
Message-ID: <20151102165910.GA21152@kroah.com> (raw)
In-Reply-To: <CAKHNQQFRSko0HhvRjhn+N2v6RRjA=z-5Ug6-CVvOeu+tHPUByA@mail.gmail.com>
On Mon, Nov 02, 2015 at 10:26:18PM +0530, Shivani Bhardwaj wrote:
> On Mon, Nov 2, 2015 at 10:22 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Mon, Nov 02, 2015 at 10:11:19PM +0530, Shivani Bhardwaj wrote:
> >> Remove the functions cfs_cpu_core_siblings(), cfs_cpu_ht_siblings(),
> >> cfs_node_to_cpumask() and replace their calls with the functions they
> >> wrapped.
> >>
> >> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
> >> ---
> >> .../staging/lustre/lustre/libcfs/linux/linux-cpu.c | 30 +++++-----------------
> >> 1 file changed, 7 insertions(+), 23 deletions(-)
> >>
> >> diff --git a/drivers/staging/lustre/lustre/libcfs/linux/linux-cpu.c b/drivers/staging/lustre/lustre/libcfs/linux/linux-cpu.c
> >> index 2097364..31719af 100644
> >> --- a/drivers/staging/lustre/lustre/libcfs/linux/linux-cpu.c
> >> +++ b/drivers/staging/lustre/lustre/libcfs/linux/linux-cpu.c
> >> @@ -78,23 +78,6 @@ struct cfs_cpt_data {
> >>
> >> static struct cfs_cpt_data cpt_data;
> >>
> >> -static void cfs_cpu_core_siblings(int cpu, cpumask_t *mask)
> >> -{
> >> - /* return cpumask of cores in the same socket */
> >> - cpumask_copy(mask, topology_core_cpumask(cpu));
> >> -}
> >> -
> >> -/* return cpumask of HTs in the same core */
> >> -static void cfs_cpu_ht_siblings(int cpu, cpumask_t *mask)
> >> -{
> >> - cpumask_copy(mask, topology_sibling_cpumask(cpu));
> >> -}
> >> -
> >> -static void cfs_node_to_cpumask(int node, cpumask_t *mask)
> >> -{
> >> - cpumask_copy(mask, cpumask_of_node(node));
> >> -}
> >>
> >
> > Please remove one of these at a time, it makes it much easier to review
> > the patch.
> >
>
> Should I resend this one as well?
Yes.
prev parent reply other threads:[~2015-11-02 16:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-02 16:41 [PATCH] Staging: lustre: linux-cpu: Remove unnecessary wrapper functions Shivani Bhardwaj
2015-11-02 16:52 ` [Outreachy kernel] " Greg KH
2015-11-02 16:56 ` Shivani Bhardwaj
2015-11-02 16:59 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151102165910.GA21152@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=shivanib134@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.