From: Eduardo Valentin <edubezval-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Sudeep Holla <sudeep.holla-5wv7dgnIgG8@public.gmane.org>
Cc: "Javi Merino" <javi.merino-5wv7dgnIgG8@public.gmane.org>,
"\"Chung-Yih Wang (王崇懿)\""
<cywang-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
"Zhang Rui" <rui.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"Mark Rutland" <Mark.Rutland-5wv7dgnIgG8@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Pawel Moll" <Pawel.Moll-5wv7dgnIgG8@public.gmane.org>,
"Ian Campbell"
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
"Kumar Gala" <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
"linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] thermal: of: Introduce governor selection in dts
Date: Mon, 2 Nov 2015 13:24:22 -0800 [thread overview]
Message-ID: <20151102212420.GH4469@localhost.localdomain> (raw)
In-Reply-To: <55C9BB53.1090001-5wv7dgnIgG8@public.gmane.org>
On Tue, Aug 11, 2015 at 10:07:31AM +0100, Sudeep Holla wrote:
>
>
> On 10/08/15 18:47, Javi Merino wrote:
> >On Mon, Aug 10, 2015 at 09:00:49AM +0100, Chung-Yih Wang (王崇懿) wrote:
> >>This patch was originally introduced when we made power_allocator the
> >>default governor where we had issues in binding a thermal zone w/o
> >>parameters to. Then we came out this facility for binding a specific
> >>governor to a thermal zone in dts instead of the default governor.
> >>Javi seems like this idea much.
> >
> >While I can understand why this is not suitable for devicetree, we
> >should have a way in the kernel to configure different governors for
> >different thermal zones defined in device tree. Thermal zones defined
> >from platform code can choose the thermal governor when they are
> >registered.
> >
> >If this information can't go in device tree, where can we put it? As
> >an additional parameter to thermal_zone_of_sensor_register()?
> >
>
> Why can't it be via sysfs allowing users to select their choice of
> governor ? (like cpuidle/freq or even devfreq I assume)
>
Yes, sysfs configuration is the current recommended way.
Although it is tempting to have it in device tree, its
design decisions are not meant for OS implementation/specifics.
BR,
> Regards,
> Sudeep
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Eduardo Valentin <edubezval@gmail.com>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: "Javi Merino" <javi.merino@arm.com>,
"\"Chung-Yih Wang (王崇懿)\"" <cywang@google.com>,
"Zhang Rui" <rui.zhang@intel.com>,
"Mark Rutland" <Mark.Rutland@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Pawel Moll" <Pawel.Moll@arm.com>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Kumar Gala" <galak@codeaurora.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH] thermal: of: Introduce governor selection in dts
Date: Mon, 2 Nov 2015 13:24:22 -0800 [thread overview]
Message-ID: <20151102212420.GH4469@localhost.localdomain> (raw)
In-Reply-To: <55C9BB53.1090001@arm.com>
On Tue, Aug 11, 2015 at 10:07:31AM +0100, Sudeep Holla wrote:
>
>
> On 10/08/15 18:47, Javi Merino wrote:
> >On Mon, Aug 10, 2015 at 09:00:49AM +0100, Chung-Yih Wang (王崇懿) wrote:
> >>This patch was originally introduced when we made power_allocator the
> >>default governor where we had issues in binding a thermal zone w/o
> >>parameters to. Then we came out this facility for binding a specific
> >>governor to a thermal zone in dts instead of the default governor.
> >>Javi seems like this idea much.
> >
> >While I can understand why this is not suitable for devicetree, we
> >should have a way in the kernel to configure different governors for
> >different thermal zones defined in device tree. Thermal zones defined
> >from platform code can choose the thermal governor when they are
> >registered.
> >
> >If this information can't go in device tree, where can we put it? As
> >an additional parameter to thermal_zone_of_sensor_register()?
> >
>
> Why can't it be via sysfs allowing users to select their choice of
> governor ? (like cpuidle/freq or even devfreq I assume)
>
Yes, sysfs configuration is the current recommended way.
Although it is tempting to have it in device tree, its
design decisions are not meant for OS implementation/specifics.
BR,
> Regards,
> Sudeep
next prev parent reply other threads:[~2015-11-02 21:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-07 7:09 [PATCH] thermal: of: Introduce governor selection in dts Chung-Yih Wang (王崇懿)
2015-08-07 7:18 ` Krzysztof Kozlowski
[not found] ` <CAM2ehZYXsqCoS9ygXNfPHxt9-b5cFxH_ovrgjvM-BfDO6REcUg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-08-07 10:31 ` Mark Rutland
2015-08-07 10:31 ` Mark Rutland
2015-08-10 8:00 ` Chung-Yih Wang (王崇懿)
2015-08-10 17:47 ` Javi Merino
2015-08-11 9:07 ` Sudeep Holla
[not found] ` <55C9BB53.1090001-5wv7dgnIgG8@public.gmane.org>
2015-11-02 21:24 ` Eduardo Valentin [this message]
2015-11-02 21:24 ` Eduardo Valentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151102212420.GH4469@localhost.localdomain \
--to=edubezval-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=Mark.Rutland-5wv7dgnIgG8@public.gmane.org \
--cc=Pawel.Moll-5wv7dgnIgG8@public.gmane.org \
--cc=cywang-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=javi.merino-5wv7dgnIgG8@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=rui.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=sudeep.holla-5wv7dgnIgG8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.