Re: [PATCH] perf report: Support caller callchain order when using DWARF unwinder.

[Arnaldo Carvalho de Melo <acme@kernel.org>]

Em Tue, Nov 03, 2015 at 08:33:25AM +0100, Jiri Olsa escreveu:
> On Mon, Nov 02, 2015 at 06:19:44PM -0300, Arnaldo Carvalho de Melo wrote:
> 
> SNIP
> 
> > > > 
> > > > there's no check for return value of entry callback
> > > > 
> > > > also I wonder would it be better to store into ips[] within
> > > > the single loop all the time, and iterate throught it after
> > > > forward/backward based on the callchain_param.order
> > > > 
> > > > please check attached patch, totaly untested, probably leaking some index
> > > > ;-)
> > > > 
> > > > any chance this could be done also for util/unwind-libdw.c ?
> > > 
> > > That patch looks much better than mine. I'll try it out later next week and 
> > > will also have a look at util/unwind-libdw.c. Question: How can I test the 
> > 
> > So, you tried this patch, right? Jiri, have you submitted this in some
> > other message I missed?
> 
> nope.. I thought Milian would take it ;-)

I can take it, as soon as you guys agree its something I should :-)

- Arnaldo