All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Milian Wolff <milian.wolff@kdab.com>
Cc: "Jiri Olsa" <jolsa@redhat.com>,
	linux-perf-users@vger.kernel.org, "Jiri Olsa" <jolsa@kernel.org>,
	"Namhyung Kim" <namhyung@kernel.org>,
	"Frédéric Weisbecker" <fweisbec@gmail.com>
Subject: Re: [PATCH] perf report: Support caller callchain order when using DWARF unwinder.
Date: Tue, 3 Nov 2015 11:30:47 -0300	[thread overview]
Message-ID: <20151103143047.GK21609@kernel.org> (raw)
In-Reply-To: <20151103142837.GJ21609@kernel.org>

Em Tue, Nov 03, 2015 at 11:28:37AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Tue, Nov 03, 2015 at 01:54:58PM +0100, Milian Wolff escreveu:
> > On Tuesday, November 3, 2015 9:06:31 AM CET Arnaldo Carvalho de Melo wrote:
> > > Em Tue, Nov 03, 2015 at 08:33:25AM +0100, Jiri Olsa escreveu:
> > > > On Mon, Nov 02, 2015 at 06:19:44PM -0300, Arnaldo Carvalho de Melo wrote:
> > > > > So, you tried this patch, right? Jiri, have you submitted this in some
> > > > > other message I missed?
> > > > 
> > > > nope.. I thought Milian would take it ;-)
> > > 
> > > I can take it, as soon as you guys agree its something I should :-)
> > 
> > Yes, I think it's good as-is. Should I resubmit Jiris patch? Considering that 
> > he rewrote the patch, should he send it and add me as tester? How do you 
> > handle such situations in the Kernel land?
> 
> So, I'll fix this all up by adding a Signed-off-by: Jiri and a

I take that back, can one of you please write a nice description to the
problem and how the proposed patch fixes it, then send as a separate
message with your Tested-by + Signed-off-by?

- Arnaldo

> Tested-by: Millian, which I think I can do according to the above
> messages and past experience, but the Correct Way to do this would
> be for Jiri to collect your Tested-by and resubmit in a separate
> message, not as a patch added to the text of a thread.

  reply	other threads:[~2015-11-03 14:30 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-04 15:16 [PATCH] perf report: Support caller callchain order when using DWARF unwinder Milian Wolff
2015-10-04 20:38 ` Arnaldo Carvalho de Melo
2015-10-05 11:08   ` Jiri Olsa
2015-10-09 17:29     ` Milian Wolff
2015-11-02 21:19       ` Arnaldo Carvalho de Melo
2015-11-03  7:33         ` Jiri Olsa
2015-11-03 12:06           ` Arnaldo Carvalho de Melo
2015-11-03 12:54             ` Milian Wolff
2015-11-03 14:28               ` Arnaldo Carvalho de Melo
2015-11-03 14:30                 ` Arnaldo Carvalho de Melo [this message]
2015-11-03 14:32                 ` Jiri Olsa
2015-11-03 15:11                   ` Arnaldo Carvalho de Melo
2015-11-03  7:37       ` Jiri Olsa
2015-11-03 11:25         ` Milian Wolff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151103143047.GK21609@kernel.org \
    --to=acme@kernel.org \
    --cc=fweisbec@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=milian.wolff@kdab.com \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.