From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Jan Beulich <JBeulich@suse.com>, Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH 1/3] xen/x86: Correct {a, m}perf check in generic_identify()
Date: Tue, 3 Nov 2015 09:31:49 -0500 [thread overview]
Message-ID: <20151103143149.GA21174@l.oracle.com> (raw)
In-Reply-To: <1446487185-10152-2-git-send-email-andrew.cooper3@citrix.com>
On Mon, Nov 02, 2015 at 05:59:43PM +0000, Andrew Cooper wrote:
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Jan Beulich <JBeulich@suse.com>
> ---
> xen/arch/x86/cpu/common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/x86/cpu/common.c b/xen/arch/x86/cpu/common.c
> index 653b052..02f2504 100644
> --- a/xen/arch/x86/cpu/common.c
> +++ b/xen/arch/x86/cpu/common.c
> @@ -239,7 +239,7 @@ static void __cpuinit generic_identify(struct cpuinfo_x86 *c)
> if ( cpu_has(c, X86_FEATURE_CLFLSH) )
> c->x86_clflush_size = ((ebx >> 8) & 0xff) * 8;
>
> - if ( (c->cpuid_level > CPUID_PM_LEAF) &&
> + if ( (c->cpuid_level >= CPUID_PM_LEAF) &&
> (cpuid_ecx(CPUID_PM_LEAF) & CPUID6_ECX_APERFMPERF_CAPABILITY) )
> set_bit(X86_FEATURE_APERFMPERF, c->x86_capability);
>
> --
> 2.1.4
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2015-11-03 14:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-02 17:59 [PATCH 0/3] Futher cpuid handling cleanup Andrew Cooper
2015-11-02 17:59 ` [PATCH 1/3] xen/x86: Correct {a, m}perf check in generic_identify() Andrew Cooper
2015-11-03 14:31 ` Konrad Rzeszutek Wilk [this message]
2015-11-02 17:59 ` [PATCH 2/3] xen/x86: Query for paddr_bits in early_cpu_detect() Andrew Cooper
2015-11-03 14:37 ` Konrad Rzeszutek Wilk
2015-11-02 17:59 ` [PATCH 3/3] xen/x86: Cleanup of early cpuid handling Andrew Cooper
2015-11-03 14:41 ` Konrad Rzeszutek Wilk
2015-11-03 14:59 ` Andrew Cooper
2015-11-03 18:14 ` [PATCH v2 " Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151103143149.GA21174@l.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.