From: Bjorn Helgaas <helgaas@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Ley Foon Tan <lftan@altera.com>,
Marc Zyngier <marc.zyngier@arm.com>
Subject: Re: [PATCH] PCI: altera: add OF_PCI dependency
Date: Tue, 3 Nov 2015 08:44:01 -0600 [thread overview]
Message-ID: <20151103144401.GA17786@localhost> (raw)
In-Reply-To: <38421064.oVjju5M930@wuerfel>
On Tue, Nov 03, 2015 at 03:08:33PM +0100, Arnd Bergmann wrote:
> The newly added altera PCI driver fails to build when CONFIG_OF
> is disabled:
>
> drivers/pci/host/pcie-altera.c: In function 'altera_pcie_parse_request_of_pci_ranges':
> drivers/pci/host/pcie-altera.c:420:8: error: implicit declaration of function 'of_pci_get_host_bridge_resources' [-Werror=implicit-function-declaration]
>
> This adds a dependency on OF_PCI for clarity, this is the symbol
> that guards the implementation of of_pci_get_host_bridge_resources.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 6bb4dd154ae8 ("PCI: altera: Add Altera PCIe host controller driver")
6bb4dd154ae8 hasn't been merged into mainline yet, so I folded this fix
into it. Thanks, Arnd!
> ---
> Found on ARM randconfig builds yesterday
>
> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> index 9e24075d83f7..f131ba947dc6 100644
> --- a/drivers/pci/host/Kconfig
> +++ b/drivers/pci/host/Kconfig
> @@ -150,6 +150,7 @@ config PCIE_IPROC_BCMA
> config PCIE_ALTERA
> bool "Altera PCIe controller"
> depends on ARM || NIOS2
> + depends on OF_PCI
> select PCI_DOMAINS
> help
> Say Y here if you want to enable PCIe controller support on Altera
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: helgaas@kernel.org (Bjorn Helgaas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] PCI: altera: add OF_PCI dependency
Date: Tue, 3 Nov 2015 08:44:01 -0600 [thread overview]
Message-ID: <20151103144401.GA17786@localhost> (raw)
In-Reply-To: <38421064.oVjju5M930@wuerfel>
On Tue, Nov 03, 2015 at 03:08:33PM +0100, Arnd Bergmann wrote:
> The newly added altera PCI driver fails to build when CONFIG_OF
> is disabled:
>
> drivers/pci/host/pcie-altera.c: In function 'altera_pcie_parse_request_of_pci_ranges':
> drivers/pci/host/pcie-altera.c:420:8: error: implicit declaration of function 'of_pci_get_host_bridge_resources' [-Werror=implicit-function-declaration]
>
> This adds a dependency on OF_PCI for clarity, this is the symbol
> that guards the implementation of of_pci_get_host_bridge_resources.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 6bb4dd154ae8 ("PCI: altera: Add Altera PCIe host controller driver")
6bb4dd154ae8 hasn't been merged into mainline yet, so I folded this fix
into it. Thanks, Arnd!
> ---
> Found on ARM randconfig builds yesterday
>
> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> index 9e24075d83f7..f131ba947dc6 100644
> --- a/drivers/pci/host/Kconfig
> +++ b/drivers/pci/host/Kconfig
> @@ -150,6 +150,7 @@ config PCIE_IPROC_BCMA
> config PCIE_ALTERA
> bool "Altera PCIe controller"
> depends on ARM || NIOS2
> + depends on OF_PCI
> select PCI_DOMAINS
> help
> Say Y here if you want to enable PCIe controller support on Altera
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-11-03 14:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-03 14:08 [PATCH] PCI: altera: add OF_PCI dependency Arnd Bergmann
2015-11-03 14:08 ` Arnd Bergmann
2015-11-03 14:44 ` Bjorn Helgaas [this message]
2015-11-03 14:44 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151103144401.GA17786@localhost \
--to=helgaas@kernel.org \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=lftan@altera.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=marc.zyngier@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.