From: Vinod Koul <vinod.koul@intel.com>
To: Keyon <yang.jie@linux.intel.com>
Cc: alsa-devel@alsa-project.org, patches.audio@intel.com,
Omair M Abdullah <omair.m.abdullah@intel.com>,
liam.r.girdwood@linux.intel.com, Mark Brown <broonie@kernel.org>,
Jeeja KP <jeeja.kp@intel.com>
Subject: Re: [PATCH 1/3] ASoC: Intel: Skylake: fix missing machine device creation
Date: Tue, 3 Nov 2015 23:28:01 +0530 [thread overview]
Message-ID: <20151103175801.GI12910@localhost> (raw)
In-Reply-To: <5638A88E.5050908@linux.intel.com>
On Tue, Nov 03, 2015 at 08:29:02PM +0800, Keyon wrote:
> >I'm having a hard time seeing the difference between this and what's
> >going on in sst-acpi. They seem to be doing the same thing in slightly
> >different ways, they both match tables of CODEC IDs to machine driver
> >names with the distinction being that this doesn't provide a firmware
> >filename whereas sst-acpi does but the mechanics of mapping a CODEC to a
> >machine driver seem otherwise the same.
>
> agree that it may be better if we can reuse(or merge with) sst
> driver (intel/common/sst-acpi.c) for SKL.
all drivers use different sst_machine structure... and data required is not
same
--
~Vinod
next prev parent reply other threads:[~2015-11-03 17:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-30 15:04 [PATCH 0/3] ASoC: Intel: Skylake: Some more fixes Vinod Koul
2015-10-30 15:04 ` [PATCH 1/3] ASoC: Intel: Skylake: fix missing machine device creation Vinod Koul
2015-11-01 2:54 ` Mark Brown
2015-11-02 10:11 ` Vinod Koul
2015-11-02 12:07 ` Mark Brown
2015-11-02 15:32 ` Vinod Koul
2015-11-03 11:24 ` Mark Brown
2015-11-03 12:29 ` Keyon
2015-11-03 17:58 ` Vinod Koul [this message]
2015-11-03 17:57 ` Vinod Koul
2015-11-04 14:29 ` Mark Brown
2015-11-04 16:07 ` Vinod Koul
2015-10-30 15:04 ` [PATCH 2/3] ASoC: Intel: Skylake: Fix to cleanup if skl_sst_dsp_init fails Vinod Koul
2015-11-02 10:39 ` Applied "ASoC: Intel: Skylake: Fix to cleanup if skl_sst_dsp_init fails" to the asoc tree Mark Brown
2015-10-30 15:04 ` [PATCH 3/3] ASoC: Intel: Skylake: Fix substream dereference before check Vinod Koul
2015-11-02 10:39 ` Applied "ASoC: Intel: Skylake: Fix substream dereference before check" to the asoc tree Mark Brown
2015-10-30 15:04 ` [PATCH 0/3] ASoC: Intel: Skylake: Some more fixes Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151103175801.GI12910@localhost \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jeeja.kp@intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=omair.m.abdullah@intel.com \
--cc=patches.audio@intel.com \
--cc=yang.jie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.