Re: [PATCH 1/3] ASoC: Intel: Skylake: fix missing machine device creation

[Vinod Koul <vinod.koul@intel.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1100 bytes --]

On Wed, Nov 04, 2015 at 02:29:58PM +0000, Mark Brown wrote:
> On Tue, Nov 03, 2015 at 11:27:08PM +0530, Vinod Koul wrote:
> > On Tue, Nov 03, 2015 at 11:24:58AM +0000, Mark Brown wrote:
> 
> > > I'm having a hard time seeing the difference between this and what's
> > > going on in sst-acpi.  They seem to be doing the same thing in slightly
> > > different ways, they both match tables of CODEC IDs to machine driver
> > > names with the distinction being that this doesn't provide a firmware
> > > filename whereas sst-acpi does but the mechanics of mapping a CODEC to a
> > > machine driver seem otherwise the same.
> 
> > I don't disagree with your observation, the code does same stuff and only
> > difference is the data we require here, so commonizing becomes tricky
> 
> The only difference in data appears to be a firmware file name?
The one atom code uses is quite different, but i did manage to create a
global one and ignore those in other places

I will send updated patches moving all to common apci match code and then
add SKL to common code

Thanks
-- 
~Vinod

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]