From: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
To: Bart Van Assche <bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
Cc: Sagi Grimberg
<sagig-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>,
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Sebastian Parschauer
<sebastian.riemer-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>,
"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 4/7] IB/srp: Fix a potential queue overflow in an error path
Date: Tue, 3 Nov 2015 20:03:22 -0800 [thread overview]
Message-ID: <20151104040322.GA22142@infradead.org> (raw)
In-Reply-To: <56391E33.5050300-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
On Tue, Nov 03, 2015 at 12:50:59PM -0800, Bart Van Assche wrote:
> Such a check wouldn't be that simple because the only way to perform such a
> check is either by doubling the number of ib_map_mr_sg() calls or by
> performing additional memory allocations.
The other option woud be to disallow gappy SG lists unless supported by
the hardware with a single MR similar to iSER. While this would leave
the SRP protocol support for multiple SG entries per command unused it
would significantly simplify the driver.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-11-04 4:03 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 22:00 [PATCH 0/7] Fix an infinite loop in the SRP initiator Bart Van Assche
[not found] ` <562FF404.7000504-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2015-10-27 22:01 ` [PATCH 1/7] IB/srp: Fix a spelling error Bart Van Assche
[not found] ` <562FF427.3000306-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2015-11-03 17:27 ` Sagi Grimberg
2015-10-27 22:01 ` [PATCH 2/7] IB/srp: Document srp_map_data() return value Bart Van Assche
[not found] ` <562FF43F.2000404-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2015-11-03 17:28 ` Sagi Grimberg
2015-10-27 22:02 ` [PATCH 3/7] IB/srp: Rename work request ID labels Bart Van Assche
[not found] ` <562FF463.40107-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2015-11-03 17:28 ` Sagi Grimberg
2015-10-27 22:02 ` [PATCH 4/7] IB/srp: Fix a potential queue overflow in an error path Bart Van Assche
[not found] ` <562FF484.6030400-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2015-11-03 17:36 ` Sagi Grimberg
[not found] ` <5638F08D.9070206-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-11-03 19:04 ` Bart Van Assche
[not found] ` <56390557.204-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2015-11-03 19:56 ` Sagi Grimberg
[not found] ` <56391181.8040207-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-11-03 20:01 ` Bart Van Assche
[not found] ` <56391290.2080708-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2015-11-03 20:13 ` Sagi Grimberg
[not found] ` <5639157C.2060107-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-11-03 20:50 ` Bart Van Assche
[not found] ` <56391E33.5050300-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2015-11-04 4:03 ` Christoph Hellwig [this message]
[not found] ` <20151104040322.GA22142-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-11-04 22:19 ` Bart Van Assche
2015-10-27 22:03 ` [PATCH 5/7] IB/srp: Fix srp_map_data() error paths Bart Van Assche
2015-10-27 22:03 ` [PATCH 6/7] IB/srp: Introduce target->mr_pool_size Bart Van Assche
[not found] ` <562FF4BC.6030100-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2015-11-03 17:37 ` Sagi Grimberg
2015-10-27 22:04 ` [PATCH 7/7] IB/srp: Avoid that mapping failure triggers an infinite loop Bart Van Assche
[not found] ` <562FF4D9.2060809-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2015-11-03 17:43 ` Sagi Grimberg
[not found] ` <5638F25D.703-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-11-03 18:56 ` Bart Van Assche
[not found] ` <5639034D.8000905-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2015-11-03 18:59 ` Sagi Grimberg
[not found] ` <5639040F.1040503-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-11-03 19:12 ` Bart Van Assche
[not found] ` <56390730.703-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2015-11-03 19:53 ` Sagi Grimberg
2015-10-28 10:32 ` [PATCH 0/7] Fix an infinite loop in the SRP initiator Sagi Grimberg
[not found] ` <5630A454.40604-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-10-28 15:32 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151104040322.GA22142@infradead.org \
--to=hch-wegcikhe2lqwvfeawa7xhq@public.gmane.org \
--cc=bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sagig-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
--cc=sebastian.riemer-EIkl63zCoXaH+58JC4qpiA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.