All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Turquette <mturquette@baylibre.com>
To: Zain Wang <zain.wang@rock-chips.com>,
	zhengsq@rock-chips.com, hl@rock-chips.com,
	herbert@gondor.apana.org.au, davem@davemloft.net,
	heiko@sntech.de, pawel.moll@arm.com,
	ijc+devicetree@hellion.org.uk, robh+dt@kernel.org,
	galak@codeaurora.org, linux@arm.linux.org.uk,
	mark.rutland@arm.com
Cc: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
	linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
	eddie.cai@rock-chips.com, "Zain Wang" <zain.wang@rock-chips.com>
Subject: Re: [PATCH v1 2/4] clk: rockchip: set an id for crypto clk
Date: Wed, 04 Nov 2015 02:08:02 -0800	[thread overview]
Message-ID: <20151104100802.22783.97388@quantum> (raw)
In-Reply-To: <1446529928-12521-3-git-send-email-zain.wang@rock-chips.com>

Quoting Zain Wang (2015-11-02 21:52:06)
> set an id for crypto clk, so that it can be called in other part.
> 
> Signed-off-by: Zain Wang <zain.wang@rock-chips.com>

Looks good to me. I can apply after -rc1 drops, or if you prefer to take
this series all together then you have my ack:

Acked-by: Michael Turquette <mturquette@baylibre.com>

Regards,
Mike

> ---
>  drivers/clk/rockchip/clk-rk3288.c      | 2 +-
>  include/dt-bindings/clock/rk3288-cru.h | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/rockchip/clk-rk3288.c b/drivers/clk/rockchip/clk-rk3288.c
> index 9040878..3fceda1 100644
> --- a/drivers/clk/rockchip/clk-rk3288.c
> +++ b/drivers/clk/rockchip/clk-rk3288.c
> @@ -295,7 +295,7 @@ static struct rockchip_clk_branch rk3288_clk_branches[] __initdata = {
>                         RK3288_CLKGATE_CON(0), 4, GFLAGS),
>         GATE(0, "c2c_host", "aclk_cpu_src", 0,
>                         RK3288_CLKGATE_CON(13), 8, GFLAGS),
> -       COMPOSITE_NOMUX(0, "crypto", "aclk_cpu_pre", 0,
> +       COMPOSITE_NOMUX(SCLK_CRYPTO, "crypto", "aclk_cpu_pre", 0,
>                         RK3288_CLKSEL_CON(26), 6, 2, DFLAGS,
>                         RK3288_CLKGATE_CON(5), 4, GFLAGS),
>         GATE(0, "aclk_bus_2pmu", "aclk_cpu_pre", CLK_IGNORE_UNUSED,
> diff --git a/include/dt-bindings/clock/rk3288-cru.h b/include/dt-bindings/clock/rk3288-cru.h
> index c719aac..30dcd60 100644
> --- a/include/dt-bindings/clock/rk3288-cru.h
> +++ b/include/dt-bindings/clock/rk3288-cru.h
> @@ -86,6 +86,7 @@
>  #define SCLK_USBPHY480M_SRC    122
>  #define SCLK_PVTM_CORE         123
>  #define SCLK_PVTM_GPU          124
> +#define SCLK_CRYPTO                    125
>  
>  #define SCLK_MAC               151
>  #define SCLK_MACREF_OUT                152
> -- 
> 1.9.1
> 
> 

WARNING: multiple messages have this Message-ID (diff)
From: Michael Turquette <mturquette@baylibre.com>
To: zhengsq@rock-chips.com, hl@rock-chips.com,
	herbert@gondor.apana.org.au, davem@davemloft.net,
	heiko@sntech.de, pawel.moll@arm.com,
	ijc+devicetree@hellion.org.uk, robh+dt@kernel.org,
	galak@codeaurora.org, linux@arm.linux.org.uk,
	mark.rutland@arm.com
Cc: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
	linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
	eddie.cai@rock-chips.com, Zain Wang <zain.wang@rock-chips.com>
Subject: Re: [PATCH v1 2/4] clk: rockchip: set an id for crypto clk
Date: Wed, 04 Nov 2015 02:08:02 -0800	[thread overview]
Message-ID: <20151104100802.22783.97388@quantum> (raw)
In-Reply-To: <1446529928-12521-3-git-send-email-zain.wang@rock-chips.com>

Quoting Zain Wang (2015-11-02 21:52:06)
> set an id for crypto clk, so that it can be called in other part.
> 
> Signed-off-by: Zain Wang <zain.wang@rock-chips.com>

Looks good to me. I can apply after -rc1 drops, or if you prefer to take
this series all together then you have my ack:

Acked-by: Michael Turquette <mturquette@baylibre.com>

Regards,
Mike

> ---
>  drivers/clk/rockchip/clk-rk3288.c      | 2 +-
>  include/dt-bindings/clock/rk3288-cru.h | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/rockchip/clk-rk3288.c b/drivers/clk/rockchip/clk-rk3288.c
> index 9040878..3fceda1 100644
> --- a/drivers/clk/rockchip/clk-rk3288.c
> +++ b/drivers/clk/rockchip/clk-rk3288.c
> @@ -295,7 +295,7 @@ static struct rockchip_clk_branch rk3288_clk_branches[] __initdata = {
>                         RK3288_CLKGATE_CON(0), 4, GFLAGS),
>         GATE(0, "c2c_host", "aclk_cpu_src", 0,
>                         RK3288_CLKGATE_CON(13), 8, GFLAGS),
> -       COMPOSITE_NOMUX(0, "crypto", "aclk_cpu_pre", 0,
> +       COMPOSITE_NOMUX(SCLK_CRYPTO, "crypto", "aclk_cpu_pre", 0,
>                         RK3288_CLKSEL_CON(26), 6, 2, DFLAGS,
>                         RK3288_CLKGATE_CON(5), 4, GFLAGS),
>         GATE(0, "aclk_bus_2pmu", "aclk_cpu_pre", CLK_IGNORE_UNUSED,
> diff --git a/include/dt-bindings/clock/rk3288-cru.h b/include/dt-bindings/clock/rk3288-cru.h
> index c719aac..30dcd60 100644
> --- a/include/dt-bindings/clock/rk3288-cru.h
> +++ b/include/dt-bindings/clock/rk3288-cru.h
> @@ -86,6 +86,7 @@
>  #define SCLK_USBPHY480M_SRC    122
>  #define SCLK_PVTM_CORE         123
>  #define SCLK_PVTM_GPU          124
> +#define SCLK_CRYPTO                    125
>  
>  #define SCLK_MAC               151
>  #define SCLK_MACREF_OUT                152
> -- 
> 1.9.1
> 
> 

  reply	other threads:[~2015-11-04 10:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-03  5:52 [PATCH v1 0/4] Crypto: add crypto accelerator support for rk3288 Zain Wang
     [not found] ` <1446529928-12521-1-git-send-email-zain.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2015-11-03  5:52   ` [PATCH v1 1/4] Crypto: Crypto driver support aes/des/des3 " Zain Wang
2015-11-03  5:52     ` Zain Wang
     [not found]     ` <1446529928-12521-2-git-send-email-zain.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2015-11-03  8:59       ` LABBE Corentin
2015-11-03  8:59         ` LABBE Corentin
2015-11-04  5:50         ` Zain
2015-11-06 10:38     ` Heiko Stuebner
2015-11-03  5:52 ` [PATCH v1 2/4] clk: rockchip: set an id for crypto clk Zain Wang
2015-11-04 10:08   ` Michael Turquette [this message]
2015-11-04 10:08     ` Michael Turquette
2015-11-03  5:52 ` [PATCH v1 3/4] ARM: dts: rockchip: Add Crypto drivers for rk3288 Zain Wang
2015-11-03  5:52 ` [PATCH v1 4/4] crypto: rk_crypto - add DT bindings documentation Zain Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151104100802.22783.97388@quantum \
    --to=mturquette@baylibre.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=eddie.cai@rock-chips.com \
    --cc=galak@codeaurora.org \
    --cc=heiko@sntech.de \
    --cc=herbert@gondor.apana.org.au \
    --cc=hl@rock-chips.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=zain.wang@rock-chips.com \
    --cc=zhengsq@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.