From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Sasha Levin <sasha.levin@oracle.com>
Cc: Vlastimil Babka <vbabka@suse.cz>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Minchan Kim <minchan@kernel.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Mel Gorman <mgorman@suse.de>
Subject: Re: [PATCH 5/5] mm, page_owner: dump page owner info from dump_page()
Date: Wed, 4 Nov 2015 22:41:12 +0200 [thread overview]
Message-ID: <20151104204112.GA7614@node.shutemov.name> (raw)
In-Reply-To: <563A66B7.5090102@oracle.com>
On Wed, Nov 04, 2015 at 03:12:39PM -0500, Sasha Levin wrote:
> On 11/04/2015 02:41 PM, Kirill A. Shutemov wrote:
> >> + dump_page_owner(page);
> > I tend to put dump_page() into random places during debug. Dumping page
> > owner for all dump_page() cases can be too verbose.
> >
> > Can we introduce dump_page_verbose() which would do usual dump_page() plus
> > dump_page_owner()?
> >
>
> Is there any existing piece of code that would use dump_page() rather than
> dump_page_verbose()?
Good point. I think not.
So we can leave dump_page() with dump_page_owner() stuff and have
__dump_page() or something as lighter version.
--
Kirill A. Shutemov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Sasha Levin <sasha.levin@oracle.com>
Cc: Vlastimil Babka <vbabka@suse.cz>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Minchan Kim <minchan@kernel.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Mel Gorman <mgorman@suse.de>
Subject: Re: [PATCH 5/5] mm, page_owner: dump page owner info from dump_page()
Date: Wed, 4 Nov 2015 22:41:12 +0200 [thread overview]
Message-ID: <20151104204112.GA7614@node.shutemov.name> (raw)
In-Reply-To: <563A66B7.5090102@oracle.com>
On Wed, Nov 04, 2015 at 03:12:39PM -0500, Sasha Levin wrote:
> On 11/04/2015 02:41 PM, Kirill A. Shutemov wrote:
> >> + dump_page_owner(page);
> > I tend to put dump_page() into random places during debug. Dumping page
> > owner for all dump_page() cases can be too verbose.
> >
> > Can we introduce dump_page_verbose() which would do usual dump_page() plus
> > dump_page_owner()?
> >
>
> Is there any existing piece of code that would use dump_page() rather than
> dump_page_verbose()?
Good point. I think not.
So we can leave dump_page() with dump_page_owner() stuff and have
__dump_page() or something as lighter version.
--
Kirill A. Shutemov
next prev parent reply other threads:[~2015-11-04 20:41 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-04 15:00 [PATCH 0/5] page_owner improvements for debugging Vlastimil Babka
2015-11-04 15:00 ` Vlastimil Babka
2015-11-04 15:00 ` [PATCH 1/5] mm, page_owner: print migratetype of a page, not pageblock Vlastimil Babka
2015-11-04 15:00 ` Vlastimil Babka
2015-11-05 8:09 ` Joonsoo Kim
2015-11-05 8:09 ` Joonsoo Kim
2015-11-05 8:15 ` Vlastimil Babka
2015-11-05 8:15 ` Vlastimil Babka
2015-11-05 8:19 ` Joonsoo Kim
2015-11-05 8:19 ` Joonsoo Kim
2015-11-04 15:00 ` [PATCH 2/5] mm, page_owner: convert page_owner_inited to static key Vlastimil Babka
2015-11-04 15:00 ` Vlastimil Babka
2015-11-04 15:00 ` [PATCH 3/5] mm, page_owner: copy page owner info during migration Vlastimil Babka
2015-11-04 15:00 ` Vlastimil Babka
2015-11-04 15:10 ` checkpatch false warning. was: " Vlastimil Babka
2015-11-04 15:30 ` Joe Perches
2015-11-05 8:10 ` Joonsoo Kim
2015-11-05 8:10 ` Joonsoo Kim
2015-11-05 8:17 ` Vlastimil Babka
2015-11-05 8:17 ` Vlastimil Babka
2015-11-05 8:23 ` Joonsoo Kim
2015-11-05 8:23 ` Joonsoo Kim
2015-11-08 21:29 ` Hugh Dickins
2015-11-08 21:29 ` Hugh Dickins
2015-11-19 16:44 ` Vlastimil Babka
2015-11-19 16:44 ` Vlastimil Babka
2015-11-04 15:01 ` [PATCH 4/5] mm, page_owner: track last migrate reason Vlastimil Babka
2015-11-04 15:01 ` Vlastimil Babka
2015-11-04 15:01 ` [PATCH 5/5] mm, page_owner: dump page owner info from dump_page() Vlastimil Babka
2015-11-04 15:01 ` Vlastimil Babka
2015-11-04 19:41 ` Kirill A. Shutemov
2015-11-04 19:41 ` Kirill A. Shutemov
2015-11-04 20:12 ` Sasha Levin
2015-11-04 20:12 ` Sasha Levin
2015-11-04 20:41 ` Kirill A. Shutemov [this message]
2015-11-04 20:41 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151104204112.GA7614@node.shutemov.name \
--to=kirill@shutemov.name \
--cc=iamjoonsoo.kim@lge.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=minchan@kernel.org \
--cc=sasha.levin@oracle.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.