* [U-Boot] [PATCH 1/2] video: Drop DEV_FLAGS_SYSTEM flag
@ 2015-11-04 7:23 Bin Meng
2015-11-04 7:23 ` [U-Boot] [PATCH 2/2] video: Drop DEV_EXT_VIDEO flag Bin Meng
2015-11-05 7:36 ` [U-Boot] [PATCH 1/2] video: Drop DEV_FLAGS_SYSTEM flag Anatolij Gustschin
0 siblings, 2 replies; 4+ messages in thread
From: Bin Meng @ 2015-11-04 7:23 UTC (permalink / raw)
To: u-boot
DEV_FLAGS_SYSTEM does not have any actual meaning, hence drop it.
Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---
arch/blackfin/cpu/jtag-console.c | 2 +-
board/bf527-ezkit/video.c | 1 -
board/bf533-stamp/video.c | 1 -
board/bf548-ezkit/video.c | 1 -
board/cm-bf548/video.c | 1 -
board/kosagi/novena/novena.c | 2 +-
board/mpl/common/kbd.c | 2 +-
board/mpl/pati/pati.c | 2 +-
common/cmd_console.c | 3 +--
common/stdio.c | 4 ++--
common/usb_kbd.c | 2 +-
drivers/input/cros_ec_keyb.c | 2 +-
drivers/input/keyboard.c | 2 +-
drivers/input/tegra-kbc.c | 2 +-
drivers/net/netconsole.c | 2 +-
drivers/video/cfb_console.c | 2 +-
include/stdio_dev.h | 1 -
17 files changed, 13 insertions(+), 19 deletions(-)
diff --git a/arch/blackfin/cpu/jtag-console.c b/arch/blackfin/cpu/jtag-console.c
index b0abeda..29e7a44 100644
--- a/arch/blackfin/cpu/jtag-console.c
+++ b/arch/blackfin/cpu/jtag-console.c
@@ -183,7 +183,7 @@ int drv_jtag_console_init(void)
memset(&dev, 0x00, sizeof(dev));
strcpy(dev.name, "jtag");
- dev.flags = DEV_FLAGS_OUTPUT | DEV_FLAGS_INPUT | DEV_FLAGS_SYSTEM;
+ dev.flags = DEV_FLAGS_OUTPUT | DEV_FLAGS_INPUT;
dev.putc = jtag_putc;
dev.puts = jtag_puts;
dev.tstc = jtag_tstc;
diff --git a/board/bf527-ezkit/video.c b/board/bf527-ezkit/video.c
index c2bf145..530b956 100644
--- a/board/bf527-ezkit/video.c
+++ b/board/bf527-ezkit/video.c
@@ -439,7 +439,6 @@ int drv_video_init(void)
strcpy(videodev.name, "video");
videodev.ext = DEV_EXT_VIDEO; /* Video extensions */
- videodev.flags = DEV_FLAGS_SYSTEM; /* No Output */
error = stdio_register(&videodev);
diff --git a/board/bf533-stamp/video.c b/board/bf533-stamp/video.c
index 75b8adc..a451f97 100644
--- a/board/bf533-stamp/video.c
+++ b/board/bf533-stamp/video.c
@@ -165,7 +165,6 @@ int drv_video_init(void)
memset(&videodev, 0, sizeof(videodev));
strcpy(videodev.name, "video");
videodev.ext = DEV_EXT_VIDEO;
- videodev.flags = DEV_FLAGS_SYSTEM;
return stdio_register(&videodev);
}
diff --git a/board/bf548-ezkit/video.c b/board/bf548-ezkit/video.c
index 47e68c6..9cc6c74 100644
--- a/board/bf548-ezkit/video.c
+++ b/board/bf548-ezkit/video.c
@@ -329,7 +329,6 @@ int drv_video_init(void)
strcpy(videodev.name, "video");
videodev.ext = DEV_EXT_VIDEO; /* Video extensions */
- videodev.flags = DEV_FLAGS_SYSTEM; /* No Output */
error = stdio_register(&videodev);
diff --git a/board/cm-bf548/video.c b/board/cm-bf548/video.c
index b098615..2867260 100644
--- a/board/cm-bf548/video.c
+++ b/board/cm-bf548/video.c
@@ -333,7 +333,6 @@ int drv_video_init(void)
strcpy(videodev.name, "video");
videodev.ext = DEV_EXT_VIDEO; /* Video extensions */
- videodev.flags = DEV_FLAGS_SYSTEM; /* No Output */
error = stdio_register(&videodev);
diff --git a/board/kosagi/novena/novena.c b/board/kosagi/novena/novena.c
index 69f5be3..919133b 100644
--- a/board/kosagi/novena/novena.c
+++ b/board/kosagi/novena/novena.c
@@ -77,7 +77,7 @@ int drv_keyboard_init(void)
int error;
struct stdio_dev dev = {
.name = "button",
- .flags = DEV_FLAGS_INPUT | DEV_FLAGS_SYSTEM,
+ .flags = DEV_FLAGS_INPUT,
.start = novena_gpio_button_init,
.getc = novena_gpio_button_getc,
.tstc = novena_gpio_button_tstc,
diff --git a/board/mpl/common/kbd.c b/board/mpl/common/kbd.c
index 99de2ca..1da72c5 100644
--- a/board/mpl/common/kbd.c
+++ b/board/mpl/common/kbd.c
@@ -203,7 +203,7 @@ int drv_isa_kbd_init (void)
return -1;
memset (&kbddev, 0, sizeof(kbddev));
strcpy(kbddev.name, DEVNAME);
- kbddev.flags = DEV_FLAGS_INPUT | DEV_FLAGS_SYSTEM;
+ kbddev.flags = DEV_FLAGS_INPUT;
kbddev.getc = kbd_getc ;
kbddev.tstc = kbd_testc ;
diff --git a/board/mpl/pati/pati.c b/board/mpl/pati/pati.c
index b9d88ee..958cdec 100644
--- a/board/mpl/pati/pati.c
+++ b/board/mpl/pati/pati.c
@@ -566,7 +566,7 @@ void pci_con_connect(void)
irq_install_handler (0x2, (interrupt_handler_t *) pci_dorbell_irq,NULL);
memset (&pci_con_dev, 0, sizeof (pci_con_dev));
strcpy (pci_con_dev.name, "pci_con");
- pci_con_dev.flags = DEV_FLAGS_OUTPUT | DEV_FLAGS_INPUT | DEV_FLAGS_SYSTEM;
+ pci_con_dev.flags = DEV_FLAGS_OUTPUT | DEV_FLAGS_INPUT;
pci_con_dev.putc = pci_con_putc;
pci_con_dev.puts = pci_con_puts;
pci_con_dev.getc = pci_con_getc;
diff --git a/common/cmd_console.c b/common/cmd_console.c
index 93dc505..9a356ec 100644
--- a/common/cmd_console.c
+++ b/common/cmd_console.c
@@ -27,10 +27,9 @@ static int do_coninfo(cmd_tbl_t *cmd, int flag, int argc, char * const argv[])
list_for_each(pos, list) {
dev = list_entry(pos, struct stdio_dev, list);
- printf ("%-8s %08x %c%c%c ",
+ printf ("%-8s %08x %c%c ",
dev->name,
dev->flags,
- (dev->flags & DEV_FLAGS_SYSTEM) ? 'S' : '.',
(dev->flags & DEV_FLAGS_INPUT) ? 'I' : '.',
(dev->flags & DEV_FLAGS_OUTPUT) ? 'O' : '.');
diff --git a/common/stdio.c b/common/stdio.c
index adbfc89..ab4df20 100644
--- a/common/stdio.c
+++ b/common/stdio.c
@@ -88,7 +88,7 @@ static void drv_system_init (void)
memset (&dev, 0, sizeof (dev));
strcpy (dev.name, "serial");
- dev.flags = DEV_FLAGS_OUTPUT | DEV_FLAGS_INPUT | DEV_FLAGS_SYSTEM;
+ dev.flags = DEV_FLAGS_OUTPUT | DEV_FLAGS_INPUT;
dev.putc = stdio_serial_putc;
dev.puts = stdio_serial_puts;
dev.getc = stdio_serial_getc;
@@ -99,7 +99,7 @@ static void drv_system_init (void)
memset (&dev, 0, sizeof (dev));
strcpy (dev.name, "nulldev");
- dev.flags = DEV_FLAGS_OUTPUT | DEV_FLAGS_INPUT | DEV_FLAGS_SYSTEM;
+ dev.flags = DEV_FLAGS_OUTPUT | DEV_FLAGS_INPUT;
dev.putc = nulldev_putc;
dev.puts = nulldev_puts;
dev.getc = nulldev_input;
diff --git a/common/usb_kbd.c b/common/usb_kbd.c
index 95912f9..0302e5b 100644
--- a/common/usb_kbd.c
+++ b/common/usb_kbd.c
@@ -503,7 +503,7 @@ static int probe_usb_keyboard(struct usb_device *dev)
debug("USB KBD: register.\n");
memset(&usb_kbd_dev, 0, sizeof(struct stdio_dev));
strcpy(usb_kbd_dev.name, DEVNAME);
- usb_kbd_dev.flags = DEV_FLAGS_INPUT | DEV_FLAGS_SYSTEM;
+ usb_kbd_dev.flags = DEV_FLAGS_INPUT;
usb_kbd_dev.getc = usb_kbd_getc;
usb_kbd_dev.tstc = usb_kbd_testc;
usb_kbd_dev.priv = (void *)dev;
diff --git a/drivers/input/cros_ec_keyb.c b/drivers/input/cros_ec_keyb.c
index a31aa77..dd150ee 100644
--- a/drivers/input/cros_ec_keyb.c
+++ b/drivers/input/cros_ec_keyb.c
@@ -258,7 +258,7 @@ int drv_keyboard_init(void)
memset(&dev, '\0', sizeof(dev));
strcpy(dev.name, "cros-ec-keyb");
- dev.flags = DEV_FLAGS_INPUT | DEV_FLAGS_SYSTEM;
+ dev.flags = DEV_FLAGS_INPUT;
dev.getc = kbd_getc;
dev.tstc = kbd_tstc;
dev.start = cros_ec_init_keyboard;
diff --git a/drivers/input/keyboard.c b/drivers/input/keyboard.c
index be0f333..ca3886a 100644
--- a/drivers/input/keyboard.c
+++ b/drivers/input/keyboard.c
@@ -274,7 +274,7 @@ int kbd_init (void)
return -1;
memset (&kbddev, 0, sizeof(kbddev));
strcpy(kbddev.name, DEVNAME);
- kbddev.flags = DEV_FLAGS_INPUT | DEV_FLAGS_SYSTEM;
+ kbddev.flags = DEV_FLAGS_INPUT;
kbddev.getc = kbd_getc ;
kbddev.tstc = kbd_testc ;
diff --git a/drivers/input/tegra-kbc.c b/drivers/input/tegra-kbc.c
index c9c9fac..6b88db4 100644
--- a/drivers/input/tegra-kbc.c
+++ b/drivers/input/tegra-kbc.c
@@ -358,7 +358,7 @@ int drv_keyboard_init(void)
memset(&dev, '\0', sizeof(dev));
strcpy(dev.name, "tegra-kbc");
- dev.flags = DEV_FLAGS_INPUT | DEV_FLAGS_SYSTEM;
+ dev.flags = DEV_FLAGS_INPUT;
dev.getc = kbd_getc;
dev.tstc = kbd_tstc;
dev.start = init_tegra_keyboard;
diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c
index bf972dc..3500047 100644
--- a/drivers/net/netconsole.c
+++ b/drivers/net/netconsole.c
@@ -330,7 +330,7 @@ int drv_nc_init(void)
memset(&dev, 0, sizeof(dev));
strcpy(dev.name, "nc");
- dev.flags = DEV_FLAGS_OUTPUT | DEV_FLAGS_INPUT | DEV_FLAGS_SYSTEM;
+ dev.flags = DEV_FLAGS_OUTPUT | DEV_FLAGS_INPUT;
dev.start = nc_stdio_start;
dev.putc = nc_stdio_putc;
dev.puts = nc_stdio_puts;
diff --git a/drivers/video/cfb_console.c b/drivers/video/cfb_console.c
index aa7ca86..51cdd4d 100644
--- a/drivers/video/cfb_console.c
+++ b/drivers/video/cfb_console.c
@@ -2281,7 +2281,7 @@ int drv_video_init(void)
memset(&console_dev, 0, sizeof(console_dev));
strcpy(console_dev.name, "vga");
console_dev.ext = DEV_EXT_VIDEO; /* Video extensions */
- console_dev.flags = DEV_FLAGS_OUTPUT | DEV_FLAGS_SYSTEM;
+ console_dev.flags = DEV_FLAGS_OUTPUT;
console_dev.putc = video_putc; /* 'putc' function */
console_dev.puts = video_puts; /* 'puts' function */
diff --git a/include/stdio_dev.h b/include/stdio_dev.h
index 95d6246..d473f16 100644
--- a/include/stdio_dev.h
+++ b/include/stdio_dev.h
@@ -16,7 +16,6 @@
#define DEV_FLAGS_INPUT 0x00000001 /* Device can be used as input console */
#define DEV_FLAGS_OUTPUT 0x00000002 /* Device can be used as output console */
-#define DEV_FLAGS_SYSTEM 0x80000000 /* Device is a system device */
#define DEV_EXT_VIDEO 0x00000001 /* Video extensions supported */
/* Device information */
--
1.8.2.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [U-Boot] [PATCH 2/2] video: Drop DEV_EXT_VIDEO flag
2015-11-04 7:23 [U-Boot] [PATCH 1/2] video: Drop DEV_FLAGS_SYSTEM flag Bin Meng
@ 2015-11-04 7:23 ` Bin Meng
2015-11-05 7:37 ` Anatolij Gustschin
2015-11-05 7:36 ` [U-Boot] [PATCH 1/2] video: Drop DEV_FLAGS_SYSTEM flag Anatolij Gustschin
1 sibling, 1 reply; 4+ messages in thread
From: Bin Meng @ 2015-11-04 7:23 UTC (permalink / raw)
To: u-boot
DEV_EXT_VIDEO does not have any actual meaning, hence drop it.
Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---
arch/powerpc/cpu/mpc8xx/video.c | 1 -
board/bf527-ezkit/video.c | 1 -
board/bf533-stamp/video.c | 1 -
board/bf548-ezkit/video.c | 1 -
board/cm-bf548/video.c | 1 -
drivers/video/cfb_console.c | 1 -
include/stdio_dev.h | 1 -
7 files changed, 7 deletions(-)
diff --git a/arch/powerpc/cpu/mpc8xx/video.c b/arch/powerpc/cpu/mpc8xx/video.c
index 659e688..15cee3f 100644
--- a/arch/powerpc/cpu/mpc8xx/video.c
+++ b/arch/powerpc/cpu/mpc8xx/video.c
@@ -1089,7 +1089,6 @@ int drv_video_init (void)
memset (&videodev, 0, sizeof (videodev));
strcpy (videodev.name, "video");
- videodev.ext = DEV_EXT_VIDEO; /* Video extensions */
videodev.flags = DEV_FLAGS_OUTPUT; /* Output only */
videodev.putc = video_putc; /* 'putc' function */
videodev.puts = video_puts; /* 'puts' function */
diff --git a/board/bf527-ezkit/video.c b/board/bf527-ezkit/video.c
index 530b956..a57f9fe 100644
--- a/board/bf527-ezkit/video.c
+++ b/board/bf527-ezkit/video.c
@@ -438,7 +438,6 @@ int drv_video_init(void)
memset(&videodev, 0, sizeof(videodev));
strcpy(videodev.name, "video");
- videodev.ext = DEV_EXT_VIDEO; /* Video extensions */
error = stdio_register(&videodev);
diff --git a/board/bf533-stamp/video.c b/board/bf533-stamp/video.c
index a451f97..e9b9a9a 100644
--- a/board/bf533-stamp/video.c
+++ b/board/bf533-stamp/video.c
@@ -164,7 +164,6 @@ int drv_video_init(void)
memset(&videodev, 0, sizeof(videodev));
strcpy(videodev.name, "video");
- videodev.ext = DEV_EXT_VIDEO;
return stdio_register(&videodev);
}
diff --git a/board/bf548-ezkit/video.c b/board/bf548-ezkit/video.c
index 9cc6c74..3765993 100644
--- a/board/bf548-ezkit/video.c
+++ b/board/bf548-ezkit/video.c
@@ -328,7 +328,6 @@ int drv_video_init(void)
memset(&videodev, 0, sizeof(videodev));
strcpy(videodev.name, "video");
- videodev.ext = DEV_EXT_VIDEO; /* Video extensions */
error = stdio_register(&videodev);
diff --git a/board/cm-bf548/video.c b/board/cm-bf548/video.c
index 2867260..b8cc873 100644
--- a/board/cm-bf548/video.c
+++ b/board/cm-bf548/video.c
@@ -332,7 +332,6 @@ int drv_video_init(void)
memset(&videodev, 0, sizeof(videodev));
strcpy(videodev.name, "video");
- videodev.ext = DEV_EXT_VIDEO; /* Video extensions */
error = stdio_register(&videodev);
diff --git a/drivers/video/cfb_console.c b/drivers/video/cfb_console.c
index 51cdd4d..556a55f 100644
--- a/drivers/video/cfb_console.c
+++ b/drivers/video/cfb_console.c
@@ -2280,7 +2280,6 @@ int drv_video_init(void)
/* Init vga device */
memset(&console_dev, 0, sizeof(console_dev));
strcpy(console_dev.name, "vga");
- console_dev.ext = DEV_EXT_VIDEO; /* Video extensions */
console_dev.flags = DEV_FLAGS_OUTPUT;
console_dev.putc = video_putc; /* 'putc' function */
console_dev.puts = video_puts; /* 'puts' function */
diff --git a/include/stdio_dev.h b/include/stdio_dev.h
index d473f16..13f76be 100644
--- a/include/stdio_dev.h
+++ b/include/stdio_dev.h
@@ -16,7 +16,6 @@
#define DEV_FLAGS_INPUT 0x00000001 /* Device can be used as input console */
#define DEV_FLAGS_OUTPUT 0x00000002 /* Device can be used as output console */
-#define DEV_EXT_VIDEO 0x00000001 /* Video extensions supported */
/* Device information */
struct stdio_dev {
--
1.8.2.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [U-Boot] [PATCH 2/2] video: Drop DEV_EXT_VIDEO flag
2015-11-04 7:23 ` [U-Boot] [PATCH 2/2] video: Drop DEV_EXT_VIDEO flag Bin Meng
@ 2015-11-05 7:37 ` Anatolij Gustschin
0 siblings, 0 replies; 4+ messages in thread
From: Anatolij Gustschin @ 2015-11-05 7:37 UTC (permalink / raw)
To: u-boot
On Tue, 3 Nov 2015 23:23:38 -0800
Bin Meng <bmeng.cn@gmail.com> wrote:
> DEV_EXT_VIDEO does not have any actual meaning, hence drop it.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>
> ---
>
> arch/powerpc/cpu/mpc8xx/video.c | 1 -
> board/bf527-ezkit/video.c | 1 -
> board/bf533-stamp/video.c | 1 -
> board/bf548-ezkit/video.c | 1 -
> board/cm-bf548/video.c | 1 -
> drivers/video/cfb_console.c | 1 -
> include/stdio_dev.h | 1 -
> 7 files changed, 7 deletions(-)
applied to u-boot-video/master, thanks!
Anatolij
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH 1/2] video: Drop DEV_FLAGS_SYSTEM flag
2015-11-04 7:23 [U-Boot] [PATCH 1/2] video: Drop DEV_FLAGS_SYSTEM flag Bin Meng
2015-11-04 7:23 ` [U-Boot] [PATCH 2/2] video: Drop DEV_EXT_VIDEO flag Bin Meng
@ 2015-11-05 7:36 ` Anatolij Gustschin
1 sibling, 0 replies; 4+ messages in thread
From: Anatolij Gustschin @ 2015-11-05 7:36 UTC (permalink / raw)
To: u-boot
On Tue, 3 Nov 2015 23:23:37 -0800
Bin Meng <bmeng.cn@gmail.com> wrote:
> DEV_FLAGS_SYSTEM does not have any actual meaning, hence drop it.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>
> arch/blackfin/cpu/jtag-console.c | 2 +-
> board/bf527-ezkit/video.c | 1 -
> board/bf533-stamp/video.c | 1 -
> board/bf548-ezkit/video.c | 1 -
> board/cm-bf548/video.c | 1 -
> board/kosagi/novena/novena.c | 2 +-
> board/mpl/common/kbd.c | 2 +-
> board/mpl/pati/pati.c | 2 +-
> common/cmd_console.c | 3 +--
> common/stdio.c | 4 ++--
> common/usb_kbd.c | 2 +-
> drivers/input/cros_ec_keyb.c | 2 +-
> drivers/input/keyboard.c | 2 +-
> drivers/input/tegra-kbc.c | 2 +-
> drivers/net/netconsole.c | 2 +-
> drivers/video/cfb_console.c | 2 +-
> include/stdio_dev.h | 1 -
> 17 files changed, 13 insertions(+), 19 deletions(-)
applied to u-boot-video/master, thanks!
Anatolij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-11-05 7:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-04 7:23 [U-Boot] [PATCH 1/2] video: Drop DEV_FLAGS_SYSTEM flag Bin Meng
2015-11-04 7:23 ` [U-Boot] [PATCH 2/2] video: Drop DEV_EXT_VIDEO flag Bin Meng
2015-11-05 7:37 ` Anatolij Gustschin
2015-11-05 7:36 ` [U-Boot] [PATCH 1/2] video: Drop DEV_FLAGS_SYSTEM flag Anatolij Gustschin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.