Re: [meta-multimedia][PATCH 3/3] VLC: drop gnome-vfs, it will be removed from upstream in VLC 3.0

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 3083 bytes --]

On Thu, Nov 05, 2015 at 11:59:14AM +0100, Rafaël Carré wrote:
> Hello,
> 
> On 04/11/2015 23:25, Martin Jansa wrote:
> > On Wed, Nov 04, 2015 at 05:03:19PM +0100, Rafaël Carré wrote:
> >> ---
> > 
> > Is it still used in 2.2.1 version? we aren't using 3.0 yet:
> 
> Yes, that module is still present in 2.2 (2.2.1 and future 2.2.X versions).
> 
> I'm testing the waters here, as I couldn't build gnome-vfs, and since
> that module
> is being removed from upstream (again, in future 3.0 version but not
> 2.2.X), I
> didn't bother to add a PACKAGECONFIG knob for it.
> 
> With this patch the gnome-vfs module will still if gnome-vfs is present,
> although it will not load at runtime if gnome-vfs is not installed (without
> preventing the rest of VLC to work properly).
> 
> It would be in the same position than the libarchive, dvdnav, samba,
> ssh2 modules, etc
> which coincidentally implement the capabilities that the deprecated (in
> gnome) gnome-vfs
> provides :)
> 
> So this simple patch fixes my build failure and at the same time reduces
> future work for when
> VLC 3.0 will be released.
> 
> 
> What do you think?

NAK it's not acceptable to make gnome-vfs support undeterministic in
2.2.x just because some future 3.0 recipe won't use it.

We already have too many autodetected dependencies again, last bunch
added by new 1394 recipes in meta-multimedia:
vlc-2.2.1: vlc rdepends on libavc1394, but it isn't a build dependency? [build-deps]
vlc-2.2.1: vlc rdepends on libdvdnav, but it isn't a build dependency? [build-deps]
vlc-2.2.1: vlc rdepends on libupnp, but it isn't a build dependency? [build-deps]

Add PACKAGECONFIG for it please and to get bonus points add
PACKAGECONFIG for deps from QA issues above.

> Thanks for the feedback
> 
> >>  meta-multimedia/recipes-multimedia/vlc/vlc.inc | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/meta-multimedia/recipes-multimedia/vlc/vlc.inc b/meta-multimedia/recipes-multimedia/vlc/vlc.inc
> >> index ad5c81d..dddbb5b 100644
> >> --- a/meta-multimedia/recipes-multimedia/vlc/vlc.inc
> >> +++ b/meta-multimedia/recipes-multimedia/vlc/vlc.inc
> >> @@ -8,7 +8,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
> >>  DEPENDS = "libfribidi libtool libgcrypt libgcrypt-native \
> >>     virtual/libsdl libsdl-image dbus dbus-glib libxml2 gnutls \
> >>     tremor faad2 ffmpeg flac libxpm libxinerama fluidsynth alsa-lib \
> >> -   libdvdcss libdvdread lua-native lua libidn gnome-vfs \
> >> +   libdvdcss libdvdread lua-native lua libidn \
> >>     libdc1394 libraw1394 avahi libjpeg-turbo xz libmodplug mpeg2dec \
> >>     libmtp libopus orc libsamplerate0 libusb1 schroedinger taglib \
> >>     tiff xcb-util-keysyms samba"
> 
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]