Re: [meta-multimedia][PATCH 3/3] VLC: drop gnome-vfs, it will be removed from upstream in VLC 3.0

["Rafaël Carré" <funman@videolan.org>]

On 05/11/2015 12:16, Martin Jansa wrote:
> On Thu, Nov 05, 2015 at 11:59:14AM +0100, Rafaël Carré wrote:
>> Hello,
>>
>> On 04/11/2015 23:25, Martin Jansa wrote:
>>> On Wed, Nov 04, 2015 at 05:03:19PM +0100, Rafaël Carré wrote:
>>>> ---
>>>
>>> Is it still used in 2.2.1 version? we aren't using 3.0 yet:
>>
>> Yes, that module is still present in 2.2 (2.2.1 and future 2.2.X versions).


>> What do you think?
> 
> NAK it's not acceptable to make gnome-vfs support undeterministic in
> 2.2.x just because some future 3.0 recipe won't use it.

Ok

> We already have too many autodetected dependencies again, last bunch
> added by new 1394 recipes in meta-multimedia:
> vlc-2.2.1: vlc rdepends on libavc1394, but it isn't a build dependency? [build-deps]
> vlc-2.2.1: vlc rdepends on libdvdnav, but it isn't a build dependency? [build-deps]
> vlc-2.2.1: vlc rdepends on libupnp, but it isn't a build dependency? [build-deps]
> 
> Add PACKAGECONFIG for it please and to get bonus points add

Done

> PACKAGECONFIG for deps from QA issues above.

I will take a deeper look as there are more than just those

>> Thanks for the feedback
>>
>>>>  meta-multimedia/recipes-multimedia/vlc/vlc.inc | 2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/meta-multimedia/recipes-multimedia/vlc/vlc.inc b/meta-multimedia/recipes-multimedia/vlc/vlc.inc
>>>> index ad5c81d..dddbb5b 100644
>>>> --- a/meta-multimedia/recipes-multimedia/vlc/vlc.inc
>>>> +++ b/meta-multimedia/recipes-multimedia/vlc/vlc.inc
>>>> @@ -8,7 +8,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
>>>>  DEPENDS = "libfribidi libtool libgcrypt libgcrypt-native \
>>>>     virtual/libsdl libsdl-image dbus dbus-glib libxml2 gnutls \
>>>>     tremor faad2 ffmpeg flac libxpm libxinerama fluidsynth alsa-lib \
>>>> -   libdvdcss libdvdread lua-native lua libidn gnome-vfs \
>>>> +   libdvdcss libdvdread lua-native lua libidn \
>>>>     libdc1394 libraw1394 avahi libjpeg-turbo xz libmodplug mpeg2dec \
>>>>     libmtp libopus orc libsamplerate0 libusb1 schroedinger taglib \
>>>>     tiff xcb-util-keysyms samba"