All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	Dmitry Vyukov <dvyukov@google.com>
Cc: Roland McGrath <roland@hack.frob.com>,
	amanieu@gmail.com, pmoore@redhat.com,
	Ingo Molnar <mingo@kernel.org>,
	vdavydov@parallels.com, qiaowei.ren@intel.com, dave@stgolabs.net,
	palmer@dabbelt.com, syzkaller <syzkaller@googlegroups.com>,
	Kostya Serebryany <kcc@google.com>,
	Alexander Potapenko <glider@google.com>,
	Sasha Levin <sasha.levin@oracle.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 0/3] signal: kill the obsolete SIGNAL_UNKILLABLE check in complete_signal()
Date: Thu, 5 Nov 2015 21:17:20 +0100	[thread overview]
Message-ID: <20151105201720.GA15763@redhat.com> (raw)

On 11/05, Oleg Nesterov wrote:
>
> Cough... and on the second thought this patch needs v2. Sorry Andrew, please
> drop signal-kill-the-obsolete-signal_unkillable-check-in-complete_signal.patch
> I'll send the updated version.
>
> With this patch the parent namespace can use any fatal signal (not only SIGKILL)
> to kill the init process in container. I do not think this is actually bad, but
> in any case this should not silently come as a side effect. And this is not
> consistent with SIGNAL_UNKILLABLE/sig_kernel_only() check in get_signal().
>
> Most probably I will just resend this patch as 2/2, while 1/2 will change
> sig_task_ignored() because afaics it is not actually right too (albeit not
> really buggy).

So this replaces
signal-kill-the-obsolete-signal_unkillable-check-in-complete_signal.patch
2/3 is actually the same change, just the changelog was updated.

I'll try to send the cleanups tomorrow. sig_task_ignored() doesn't
look nice, sig_handler_ignored() must die, SIGNAL_UNKILLABLE checks
in sig_task_ignored() and get_signal() should be unified.

And to remind, we need to fix more problems I found yesterday.

Oleg.


             reply	other threads:[~2015-11-05 19:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-05 20:17 Oleg Nesterov [this message]
2015-11-05 20:17 ` [PATCH v2 1/3] signal: change sig_task_ignored(force) to take sig_kernel_only() into account Oleg Nesterov
2015-11-05 20:17 ` [PATCH v2 2/3] signal: kill the obsolete SIGNAL_UNKILLABLE check in complete_signal() Oleg Nesterov
2015-11-05 20:17 ` [PATCH v2 3/3] signal: change complete_signal() to use for_each_thread() Oleg Nesterov
2015-11-05 23:33 ` [PATCH 0/3] signal: kill the obsolete SIGNAL_UNKILLABLE check in complete_signal() Andrew Morton
2015-11-06 14:32   ` Oleg Nesterov
2015-11-06 19:16     ` Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151105201720.GA15763@redhat.com \
    --to=oleg@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=amanieu@gmail.com \
    --cc=dave@stgolabs.net \
    --cc=dvyukov@google.com \
    --cc=glider@google.com \
    --cc=kcc@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=palmer@dabbelt.com \
    --cc=pmoore@redhat.com \
    --cc=qiaowei.ren@intel.com \
    --cc=roland@hack.frob.com \
    --cc=sasha.levin@oracle.com \
    --cc=syzkaller@googlegroups.com \
    --cc=vdavydov@parallels.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.