All of lore.kernel.org
 help / color / mirror / Atom feed
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] xen/arm: introduce xen_read_wallclock
Date: Fri, 6 Nov 2015 12:26:42 +0000	[thread overview]
Message-ID: <20151106122641.GC23038@leverpostej> (raw)
In-Reply-To: <1446743385-12848-1-git-send-email-stefano.stabellini@eu.citrix.com>

> +	delta = arch_timer_read_counter();	/* time since system boot */
> +	delta += now.tv_sec * (u64)NSEC_PER_SEC + now.tv_nsec;

The arch counter value is not a number of nanoseconds (unless CNTFRQ
reads as 1000000), so this doesn't look right; the units don't match.

Thanks,
Mark.

WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: xen-devel@lists.xensource.com, Ian.Campbell@citrix.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] xen/arm: introduce xen_read_wallclock
Date: Fri, 6 Nov 2015 12:26:42 +0000	[thread overview]
Message-ID: <20151106122641.GC23038@leverpostej> (raw)
In-Reply-To: <1446743385-12848-1-git-send-email-stefano.stabellini@eu.citrix.com>

> +	delta = arch_timer_read_counter();	/* time since system boot */
> +	delta += now.tv_sec * (u64)NSEC_PER_SEC + now.tv_nsec;

The arch counter value is not a number of nanoseconds (unless CNTFRQ
reads as 1000000), so this doesn't look right; the units don't match.

Thanks,
Mark.

  parent reply	other threads:[~2015-11-06 12:26 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-05 17:09 [PATCH 0/3] Xen wallclock on arm and arm64 Stefano Stabellini
2015-11-05 17:09 ` Stefano Stabellini
2015-11-05 17:09 ` [PATCH 1/3] xen/arm: introduce xen_read_wallclock Stefano Stabellini
2015-11-05 17:09   ` Stefano Stabellini
2015-11-05 18:53   ` Arnd Bergmann
2015-11-05 18:53     ` Arnd Bergmann
2015-11-06 15:09     ` Stefano Stabellini
2015-11-06 15:09       ` Stefano Stabellini
2015-11-06 15:56       ` Arnd Bergmann
2015-11-06 15:56         ` Arnd Bergmann
2015-11-09 13:53         ` Stefano Stabellini
2015-11-09 13:53           ` Stefano Stabellini
2015-11-09 16:16           ` Arnd Bergmann
2015-11-09 16:16             ` Arnd Bergmann
2015-11-09 17:14             ` Stefano Stabellini
2015-11-09 17:14               ` Stefano Stabellini
2015-11-09 20:42               ` Arnd Bergmann
2015-11-09 20:42                 ` Arnd Bergmann
2015-11-06 12:26   ` Mark Rutland [this message]
2015-11-06 12:26     ` Mark Rutland
2015-11-06 14:34     ` Stefano Stabellini
2015-11-06 14:34       ` Stefano Stabellini
2015-11-05 17:09 ` [PATCH 2/3] xen/arm: introduce HYPERVISOR_dom0_op on arm and arm64 Stefano Stabellini
2015-11-05 17:09   ` Stefano Stabellini
2015-11-05 17:21   ` [Xen-devel] " Jan Beulich
2015-11-05 17:21     ` Jan Beulich
2015-11-06 14:45     ` [Xen-devel] " Stefano Stabellini
2015-11-06 14:45     ` Stefano Stabellini
2015-11-05 17:09 ` [PATCH 3/3] xen/arm: set the system time in Xen via the XENPF_settime hypercall Stefano Stabellini
2015-11-05 17:09   ` Stefano Stabellini
2015-11-05 17:45   ` [Xen-devel] " David Vrabel
2015-11-05 17:45     ` David Vrabel
2015-11-06 14:59     ` Stefano Stabellini
2015-11-06 14:59       ` Stefano Stabellini
2015-11-05 18:58   ` Arnd Bergmann
2015-11-05 18:58     ` Arnd Bergmann
2015-11-09 14:10     ` Stefano Stabellini
2015-11-09 14:10       ` Stefano Stabellini
2015-11-09 16:10       ` Arnd Bergmann
2015-11-09 16:10         ` Arnd Bergmann
2015-11-09 17:17         ` Stefano Stabellini
2015-11-09 17:17           ` Stefano Stabellini
2015-11-09 17:42           ` Stefano Stabellini
2015-11-09 17:42             ` Stefano Stabellini
2015-11-09 20:45             ` Arnd Bergmann
2015-11-09 20:45               ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151106122641.GC23038@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.