From: Thierry Reding <thierry.reding@gmail.com>
To: Olliver Schinagl <o.schinagl@ultimaker.com>
Cc: Olliver Schinagl <oliver@schinagl.nl>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Joachim Eastwood <manabian@gmail.com>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Olliver Schinagl <oliver+list@schinagl.nl>,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 06/10] pwm: sysfs: make use of the DEVICE_ATTR_[RW][WO] macro's
Date: Fri, 6 Nov 2015 15:52:58 +0100 [thread overview]
Message-ID: <20151106145258.GC8418@ulmo> (raw)
In-Reply-To: <1445895161-2317-7-git-send-email-o.schinagl@ultimaker.com>
[-- Attachment #1: Type: text/plain, Size: 722 bytes --]
On Mon, Oct 26, 2015 at 10:32:37PM +0100, Olliver Schinagl wrote:
> From: Olliver Schinagl <oliver@schinagl.nl>
>
> For the npwm property the pwm sysfs interface already made use of the
> DEVICE_ATTR_RO macro. This patch expands this to the other sysfs
> properties so that the code base is concise and makes use of this
> helpful macro.
>
> This has the advantage of slightly reducing the code size, improving
> readability and no longer using magic values for permissions.
>
> Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
> ---
> drivers/pwm/sysfs.c | 72 ++++++++++++++++++++++++++---------------------------
> 1 file changed, 36 insertions(+), 36 deletions(-)
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: thierry.reding@gmail.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 06/10] pwm: sysfs: make use of the DEVICE_ATTR_[RW][WO] macro's
Date: Fri, 6 Nov 2015 15:52:58 +0100 [thread overview]
Message-ID: <20151106145258.GC8418@ulmo> (raw)
In-Reply-To: <1445895161-2317-7-git-send-email-o.schinagl@ultimaker.com>
On Mon, Oct 26, 2015 at 10:32:37PM +0100, Olliver Schinagl wrote:
> From: Olliver Schinagl <oliver@schinagl.nl>
>
> For the npwm property the pwm sysfs interface already made use of the
> DEVICE_ATTR_RO macro. This patch expands this to the other sysfs
> properties so that the code base is concise and makes use of this
> helpful macro.
>
> This has the advantage of slightly reducing the code size, improving
> readability and no longer using magic values for permissions.
>
> Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
> ---
> drivers/pwm/sysfs.c | 72 ++++++++++++++++++++++++++---------------------------
> 1 file changed, 36 insertions(+), 36 deletions(-)
Applied, thanks.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20151106/671d537d/attachment.sig>
next prev parent reply other threads:[~2015-11-06 14:52 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-26 21:32 [PATCH 00/10] Olliver Schinagl
2015-10-26 21:32 ` Olliver Schinagl
2015-10-26 21:32 ` [PATCH 01/10] pwm: lpc18xx_pwm: use pwm_set_chip_data Olliver Schinagl
2015-10-26 21:32 ` Olliver Schinagl
2015-10-26 21:58 ` Ezequiel Garcia
2015-10-26 21:58 ` Ezequiel Garcia
2015-10-27 7:22 ` Olliver Schinagl
2015-10-27 7:22 ` Olliver Schinagl
2015-10-26 21:32 ` [PATCH 02/10] pwm: sunxi: fix whitespace issue Olliver Schinagl
2015-10-26 21:32 ` Olliver Schinagl
2015-11-06 16:08 ` Thierry Reding
2015-11-06 16:08 ` Thierry Reding
2015-10-26 21:32 ` [PATCH 03/10] pwm: sunxi: Yield some time to the pwm-block to become ready Olliver Schinagl
2015-10-26 21:32 ` Olliver Schinagl
2015-10-26 21:32 ` Olliver Schinagl
2015-11-06 16:12 ` Thierry Reding
2015-11-06 16:12 ` Thierry Reding
2015-11-06 16:34 ` Chen-Yu Tsai
2015-11-06 16:34 ` Chen-Yu Tsai
2015-10-26 21:32 ` [PATCH 04/10] pwm: core: use bitops Olliver Schinagl
2015-10-26 21:32 ` Olliver Schinagl
2015-11-06 14:46 ` Thierry Reding
2015-11-06 14:46 ` Thierry Reding
2015-11-06 14:49 ` Olliver Schinagl
2015-11-06 14:49 ` Olliver Schinagl
2015-11-06 21:36 ` Andy Shevchenko
2015-11-06 21:36 ` Andy Shevchenko
2015-10-26 21:32 ` [PATCH 05/10] pwm: sysfs: do not unnecessarily store result in var Olliver Schinagl
2015-10-26 21:32 ` Olliver Schinagl
2015-10-26 21:32 ` Olliver Schinagl
2015-11-06 14:51 ` Thierry Reding
2015-11-06 14:51 ` Thierry Reding
2015-10-26 21:32 ` [PATCH 06/10] pwm: sysfs: make use of the DEVICE_ATTR_[RW][WO] macro's Olliver Schinagl
2015-10-26 21:32 ` Olliver Schinagl
2015-11-06 14:52 ` Thierry Reding [this message]
2015-11-06 14:52 ` Thierry Reding
2015-10-26 21:32 ` [PATCH 07/10] pwm: gpio: Add a generic gpio based PWM driver Olliver Schinagl
2015-10-26 21:32 ` Olliver Schinagl
2015-10-27 7:42 ` Rob Herring
2015-10-27 7:42 ` Rob Herring
2015-10-27 8:50 ` Olliver Schinagl
2015-10-27 8:50 ` Olliver Schinagl
2015-11-06 15:57 ` Thierry Reding
2015-11-06 15:57 ` Thierry Reding
2015-10-26 21:32 ` [PATCH 08/10] pwm: core: add pulse feature to the PWM framework Olliver Schinagl
2015-10-26 21:32 ` Olliver Schinagl
2015-10-26 21:59 ` kbuild test robot
2015-10-26 21:59 ` kbuild test robot
2015-10-26 22:09 ` kbuild test robot
2015-10-26 22:09 ` kbuild test robot
[not found] ` <1445895161-2317-9-git-send-email-o.schinagl-U3FVU11NWA554TAoqtyWWQ@public.gmane.org>
2015-10-26 22:10 ` kbuild test robot
2015-10-26 22:10 ` kbuild test robot
2015-10-26 22:10 ` kbuild test robot
2015-10-26 22:11 ` kbuild test robot
2015-10-26 22:11 ` kbuild test robot
2015-10-26 23:06 ` kbuild test robot
2015-10-26 23:06 ` kbuild test robot
2015-11-06 15:18 ` Thierry Reding
2015-11-06 15:18 ` Thierry Reding
2015-11-06 15:46 ` Olliver Schinagl
2015-11-06 15:46 ` Olliver Schinagl
[not found] ` <563CCB6E.2090206-U3FVU11NWA554TAoqtyWWQ@public.gmane.org>
2015-11-06 16:05 ` Thierry Reding
2015-11-06 16:05 ` Thierry Reding
2015-11-06 16:05 ` Thierry Reding
2015-11-06 16:18 ` Olliver Schinagl
2015-11-06 16:18 ` Olliver Schinagl
2015-10-26 21:32 ` [PATCH 09/10] pwm: pwm_gpio: add pulse option Olliver Schinagl
2015-10-26 21:32 ` Olliver Schinagl
2015-10-26 21:32 ` [PATCH 10/10] pwm: sunxi: Add possibility to pulse the sunxi pwm output Olliver Schinagl
2015-10-26 21:32 ` Olliver Schinagl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151106145258.GC8418@ulmo \
--to=thierry.reding@gmail.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=manabian@gmail.com \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=o.schinagl@ultimaker.com \
--cc=oliver+list@schinagl.nl \
--cc=oliver@schinagl.nl \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.