All of lore.kernel.org
 help / color / mirror / Atom feed
* [patch 1/2] megaraid_sas: remove a stray tab
@ 2015-11-07 16:16 ` Dan Carpenter
  0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2015-11-07 16:16 UTC (permalink / raw)
  To: Kashyap Desai, Sumit Saxena
  Cc: Uday Lingala, James E.J. Bottomley, megaraidlinux.pdl, linux-scsi,
	linux-kernel, kernel-janitors

One line was indented more than the others.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
index cc95372..829e9e9 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -5923,9 +5923,9 @@ static void megasas_detach_one(struct pci_dev *pdev)
 
 	if (instance->ctrl_context) {
 		megasas_release_fusion(instance);
-			pd_seq_map_sz = sizeof(struct MR_PD_CFG_SEQ_NUM_SYNC) +
+		pd_seq_map_sz = sizeof(struct MR_PD_CFG_SEQ_NUM_SYNC) +
 				(sizeof(struct MR_PD_CFG_SEQ) *
-					(MAX_PHYSICAL_DEVICES - 1));
+				(MAX_PHYSICAL_DEVICES - 1));
 		for (i = 0; i < 2 ; i++) {
 			if (fusion->ld_map[i])
 				dma_free_coherent(&instance->pdev->dev,

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [patch 1/2] megaraid_sas: remove a stray tab
@ 2015-11-07 16:16 ` Dan Carpenter
  0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2015-11-07 16:16 UTC (permalink / raw)
  To: Kashyap Desai, Sumit Saxena
  Cc: Uday Lingala, James E.J. Bottomley, megaraidlinux.pdl, linux-scsi,
	linux-kernel, kernel-janitors

One line was indented more than the others.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
index cc95372..829e9e9 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -5923,9 +5923,9 @@ static void megasas_detach_one(struct pci_dev *pdev)
 
 	if (instance->ctrl_context) {
 		megasas_release_fusion(instance);
-			pd_seq_map_sz = sizeof(struct MR_PD_CFG_SEQ_NUM_SYNC) +
+		pd_seq_map_sz = sizeof(struct MR_PD_CFG_SEQ_NUM_SYNC) +
 				(sizeof(struct MR_PD_CFG_SEQ) *
-					(MAX_PHYSICAL_DEVICES - 1));
+				(MAX_PHYSICAL_DEVICES - 1));
 		for (i = 0; i < 2 ; i++) {
 			if (fusion->ld_map[i])
 				dma_free_coherent(&instance->pdev->dev,

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* RE: [patch 1/2] megaraid_sas: remove a stray tab
  2015-11-07 16:16 ` Dan Carpenter
@ 2015-11-10 10:33   ` Kashyap Desai
  -1 siblings, 0 replies; 4+ messages in thread
From: Kashyap Desai @ 2015-11-10 10:21 UTC (permalink / raw)
  To: Dan Carpenter, Sumit Saxena
  Cc: Uday Lingala, James E.J. Bottomley, PDL,MEGARAIDLINUX, linux-scsi,
	linux-kernel, kernel-janitors

> -----Original Message-----
> From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
> Sent: Saturday, November 07, 2015 9:46 PM
> To: Kashyap Desai; Sumit Saxena
> Cc: Uday Lingala; James E.J. Bottomley; megaraidlinux.pdl@avagotech.com;
> linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org; kernel-
> janitors@vger.kernel.org
> Subject: [patch 1/2] megaraid_sas: remove a stray tab
>
> One line was indented more than the others.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Let us combine your next patch (because that is also indentation issue)
and this one. We will resubmit patch.   For now ignore to avoid any issue
for pending patches to be committed.

>
> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
> b/drivers/scsi/megaraid/megaraid_sas_base.c
> index cc95372..829e9e9 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_base.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_base.c
> @@ -5923,9 +5923,9 @@ static void megasas_detach_one(struct pci_dev
> *pdev)
>
>  	if (instance->ctrl_context) {
>  		megasas_release_fusion(instance);
> -			pd_seq_map_sz = sizeof(struct
> MR_PD_CFG_SEQ_NUM_SYNC) +
> +		pd_seq_map_sz = sizeof(struct
> MR_PD_CFG_SEQ_NUM_SYNC) +
>  				(sizeof(struct MR_PD_CFG_SEQ) *
> -					(MAX_PHYSICAL_DEVICES - 1));
> +				(MAX_PHYSICAL_DEVICES - 1));
>  		for (i = 0; i < 2 ; i++) {
>  			if (fusion->ld_map[i])
>  				dma_free_coherent(&instance->pdev->dev,

^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [patch 1/2] megaraid_sas: remove a stray tab
@ 2015-11-10 10:33   ` Kashyap Desai
  0 siblings, 0 replies; 4+ messages in thread
From: Kashyap Desai @ 2015-11-10 10:33 UTC (permalink / raw)
  To: Dan Carpenter, Sumit Saxena
  Cc: Uday Lingala, James E.J. Bottomley, PDL,MEGARAIDLINUX, linux-scsi,
	linux-kernel, kernel-janitors

> -----Original Message-----
> From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
> Sent: Saturday, November 07, 2015 9:46 PM
> To: Kashyap Desai; Sumit Saxena
> Cc: Uday Lingala; James E.J. Bottomley; megaraidlinux.pdl@avagotech.com;
> linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org; kernel-
> janitors@vger.kernel.org
> Subject: [patch 1/2] megaraid_sas: remove a stray tab
>
> One line was indented more than the others.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Let us combine your next patch (because that is also indentation issue)
and this one. We will resubmit patch.   For now ignore to avoid any issue
for pending patches to be committed.

>
> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
> b/drivers/scsi/megaraid/megaraid_sas_base.c
> index cc95372..829e9e9 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_base.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_base.c
> @@ -5923,9 +5923,9 @@ static void megasas_detach_one(struct pci_dev
> *pdev)
>
>  	if (instance->ctrl_context) {
>  		megasas_release_fusion(instance);
> -			pd_seq_map_sz = sizeof(struct
> MR_PD_CFG_SEQ_NUM_SYNC) +
> +		pd_seq_map_sz = sizeof(struct
> MR_PD_CFG_SEQ_NUM_SYNC) +
>  				(sizeof(struct MR_PD_CFG_SEQ) *
> -					(MAX_PHYSICAL_DEVICES - 1));
> +				(MAX_PHYSICAL_DEVICES - 1));
>  		for (i = 0; i < 2 ; i++) {
>  			if (fusion->ld_map[i])
>  				dma_free_coherent(&instance->pdev->dev,

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-11-10 10:33 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-07 16:16 [patch 1/2] megaraid_sas: remove a stray tab Dan Carpenter
2015-11-07 16:16 ` Dan Carpenter
2015-11-10 10:21 ` Kashyap Desai
2015-11-10 10:33   ` Kashyap Desai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.