From: Al Viro <viro-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org>
To: Anna Schumaker <Anna.Schumaker-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org>
Cc: linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-btrfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
zab-ugsP4Wv/S6ZeoWH0uzbU5w@public.gmane.org,
clm-b10kYP2dOMg@public.gmane.org,
darrick.wong-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org,
mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
andros-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org,
hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org
Subject: Re: [PATCH v8 4/4] vfs: Add vfs_copy_file_range() support for pagecache copies
Date: Tue, 10 Nov 2015 00:56:45 +0000 [thread overview]
Message-ID: <20151110005645.GX22011@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1446844701-848-5-git-send-email-Anna.Schumaker-ZwjVKphTwtPQT0dZR+AlfA@public.gmane.org>
On Fri, Nov 06, 2015 at 04:18:20PM -0500, Anna Schumaker wrote:
> I moved the rw_verify_area() calls into the fallback code since some
> filesystems can handle reflinking a large range.
Take a look at rw_verify_area() - it does a lot more than "trim down to
2Gb" - starting with "deal with mandatory locks". LSM checks as well...
So that one is bogus, IMO. I've no problem with fallback per se, but
rw_verify_area() should be unconditional here. If anything, we might
add a variant that would skip the "trim down to 2Gb" and use it there,
but skipping it entirely is wrong.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Anna Schumaker <Anna.Schumaker@netapp.com>
Cc: linux-nfs@vger.kernel.org, linux-btrfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org,
zab@zabbo.net, clm@fb.com, darrick.wong@oracle.com,
mtk.manpages@gmail.com, andros@netapp.com, hch@infradead.org
Subject: Re: [PATCH v8 4/4] vfs: Add vfs_copy_file_range() support for pagecache copies
Date: Tue, 10 Nov 2015 00:56:45 +0000 [thread overview]
Message-ID: <20151110005645.GX22011@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1446844701-848-5-git-send-email-Anna.Schumaker@Netapp.com>
On Fri, Nov 06, 2015 at 04:18:20PM -0500, Anna Schumaker wrote:
> I moved the rw_verify_area() calls into the fallback code since some
> filesystems can handle reflinking a large range.
Take a look at rw_verify_area() - it does a lot more than "trim down to
2Gb" - starting with "deal with mandatory locks". LSM checks as well...
So that one is bogus, IMO. I've no problem with fallback per se, but
rw_verify_area() should be unconditional here. If anything, we might
add a variant that would skip the "trim down to 2Gb" and use it there,
but skipping it entirely is wrong.
next prev parent reply other threads:[~2015-11-10 0:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-06 21:18 [PATCH v8 0/4] VFS: In-kernel copy system call Anna Schumaker
2015-11-06 21:18 ` Anna Schumaker
2015-11-06 21:18 ` Anna Schumaker
2015-11-06 21:18 ` [PATCH v8 1/4] vfs: add copy_file_range syscall and vfs helper Anna Schumaker
2015-11-06 21:18 ` Anna Schumaker
2015-11-06 21:18 ` [PATCH v8 2/4] x86: add sys_copy_file_range to syscall tables Anna Schumaker
2015-11-06 21:18 ` Anna Schumaker
2015-11-06 21:18 ` [PATCH v8 3/4] btrfs: add .copy_file_range file operation Anna Schumaker
2015-11-06 21:18 ` Anna Schumaker
2015-11-06 21:18 ` [PATCH v8 4/4] vfs: Add vfs_copy_file_range() support for pagecache copies Anna Schumaker
2015-11-06 21:18 ` Anna Schumaker
[not found] ` <1446844701-848-5-git-send-email-Anna.Schumaker-ZwjVKphTwtPQT0dZR+AlfA@public.gmane.org>
2015-11-10 0:56 ` Al Viro [this message]
2015-11-10 0:56 ` Al Viro
2015-11-06 21:18 ` [PATCH v8 5/4] copy_file_range.2: New page documenting copy_file_range() Anna Schumaker
2015-11-06 21:18 ` Anna Schumaker
[not found] ` <1446844701-848-6-git-send-email-Anna.Schumaker-ZwjVKphTwtPQT0dZR+AlfA@public.gmane.org>
2016-01-25 13:45 ` Michael Kerrisk (man-pages)
2016-01-25 13:45 ` Michael Kerrisk (man-pages)
[not found] ` <CAKgNAkgaEgQb5kJWRf12GQMSip81SL6LtLFxQvOq1yCGR6+HOg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-01-25 21:48 ` Anna Schumaker
2016-01-25 21:48 ` Anna Schumaker
2016-01-26 9:49 ` Michael Kerrisk (man-pages)
[not found] ` <56A74147.8060807-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-01-26 15:35 ` Anna Schumaker
2016-01-26 15:35 ` Anna Schumaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151110005645.GX22011@ZenIV.linux.org.uk \
--to=viro-3bdd1+5odreifsdqtta3olvcufugdwfn@public.gmane.org \
--cc=Anna.Schumaker-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org \
--cc=andros-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org \
--cc=clm-b10kYP2dOMg@public.gmane.org \
--cc=darrick.wong-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-btrfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=zab-ugsP4Wv/S6ZeoWH0uzbU5w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.