From: "ira.weiny" <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Alexey Khoroshilov <khoroshilov-ufN2psIa012HXe+LvDLADg@public.gmane.org>
Cc: Mike Marciniszyn
<infinipath-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Hal Rosenstock
<hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
ldv-project-tpLiQldItUH5n4uC9ZG1Ww@public.gmane.org
Subject: Re: [BUG] IB/hfi1: might sleep under spinlock in hfi1_ioctl()
Date: Wed, 11 Nov 2015 00:53:07 -0500 [thread overview]
Message-ID: <20151111055305.GA9594@phlsvsds.ph.intel.com> (raw)
In-Reply-To: <20151030235817.GA13800-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>
On Fri, Oct 30, 2015 at 07:58:18PM -0400, ira. weiny wrote:
> On Sat, Oct 31, 2015 at 12:32:29AM +0300, Alexey Khoroshilov wrote:
> > Hello,
> >
> > hfi1_ioctl() contains many calls to might sleep functions with
> > dd->hfi1_snoop.snoop_lock spinlock held (for example, access_ok,
> > copy_from_user, kzalloc(GFP_KERNEL), etc.).
> >
> > Should dd->hfi1_snoop.snoop_lock be acquired just before updating state?
>
> I believe you are correct.
>
> I am currently in the process of pushing fixes to the staging tree.
>
> We have a patch which fixes this queued up but it depends on at least one other
> patch in my queue.
>
> I will do my best to get this submitted soon.
I have just posted a series which addresses this problem as well as doing
general clean up on hfi1_ioctl. The specific fix is contained in this patch.
[PATCH 7/8] staging/rdma/hfi1: Reduce snoop locking scope in IOCTL handler.
Thanks for the report,
Ira
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: "ira.weiny" <ira.weiny@intel.com>
To: Alexey Khoroshilov <khoroshilov@ispras.ru>
Cc: Mike Marciniszyn <infinipath@intel.com>,
Doug Ledford <dledford@redhat.com>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-rdma@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org
Subject: Re: [BUG] IB/hfi1: might sleep under spinlock in hfi1_ioctl()
Date: Wed, 11 Nov 2015 00:53:07 -0500 [thread overview]
Message-ID: <20151111055305.GA9594@phlsvsds.ph.intel.com> (raw)
In-Reply-To: <20151030235817.GA13800@phlsvsds.ph.intel.com>
On Fri, Oct 30, 2015 at 07:58:18PM -0400, ira. weiny wrote:
> On Sat, Oct 31, 2015 at 12:32:29AM +0300, Alexey Khoroshilov wrote:
> > Hello,
> >
> > hfi1_ioctl() contains many calls to might sleep functions with
> > dd->hfi1_snoop.snoop_lock spinlock held (for example, access_ok,
> > copy_from_user, kzalloc(GFP_KERNEL), etc.).
> >
> > Should dd->hfi1_snoop.snoop_lock be acquired just before updating state?
>
> I believe you are correct.
>
> I am currently in the process of pushing fixes to the staging tree.
>
> We have a patch which fixes this queued up but it depends on at least one other
> patch in my queue.
>
> I will do my best to get this submitted soon.
I have just posted a series which addresses this problem as well as doing
general clean up on hfi1_ioctl. The specific fix is contained in this patch.
[PATCH 7/8] staging/rdma/hfi1: Reduce snoop locking scope in IOCTL handler.
Thanks for the report,
Ira
next prev parent reply other threads:[~2015-11-11 5:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-30 21:32 [BUG] IB/hfi1: might sleep under spinlock in hfi1_ioctl() Alexey Khoroshilov
2015-10-30 21:32 ` Alexey Khoroshilov
[not found] ` <1446240749-5003-1-git-send-email-khoroshilov-ufN2psIa012HXe+LvDLADg@public.gmane.org>
2015-10-30 23:58 ` ira.weiny
2015-10-30 23:58 ` ira.weiny
[not found] ` <20151030235817.GA13800-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>
2015-11-11 5:53 ` ira.weiny [this message]
2015-11-11 5:53 ` ira.weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151111055305.GA9594@phlsvsds.ph.intel.com \
--to=ira.weiny-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=infinipath-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=khoroshilov-ufN2psIa012HXe+LvDLADg@public.gmane.org \
--cc=ldv-project-tpLiQldItUH5n4uC9ZG1Ww@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.