From: Darren Hart <dvhart@infradead.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Corentin Chary <corentin.chary@gmail.com>,
acpi4asus-user@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] asus-wmi: fix error handling in store_sys_wmi()
Date: Wed, 11 Nov 2015 06:22:57 +0000 [thread overview]
Message-ID: <20151111062257.GL18221@malice.jf.intel.com> (raw)
In-Reply-To: <20151110221816.GC30281@mwanda>
On Wed, Nov 11, 2015 at 01:18:16AM +0300, Dan Carpenter wrote:
> The asus_wmi_get_devstate_simple() returns 0-1 on success. In theory
> according to static checkers, it can return either -EIO or -ENODEV on
> failure. Currently the error handling code only handles -ENODEV and
> -EIO is treated as success. Let's make it handle the -EIO error as
> well.
>
> It's possible that it can't actually return -EIO and this patch is not
> needed but in that case this patch is harmless and silences a static
> checker warning so it's still worth it.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thank you Dan, queued to testing.
--
Darren Hart
Intel Open Source Technology Center
WARNING: multiple messages have this Message-ID (diff)
From: Darren Hart <dvhart@infradead.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Corentin Chary <corentin.chary@gmail.com>,
acpi4asus-user@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] asus-wmi: fix error handling in store_sys_wmi()
Date: Tue, 10 Nov 2015 22:22:57 -0800 [thread overview]
Message-ID: <20151111062257.GL18221@malice.jf.intel.com> (raw)
In-Reply-To: <20151110221816.GC30281@mwanda>
On Wed, Nov 11, 2015 at 01:18:16AM +0300, Dan Carpenter wrote:
> The asus_wmi_get_devstate_simple() returns 0-1 on success. In theory
> according to static checkers, it can return either -EIO or -ENODEV on
> failure. Currently the error handling code only handles -ENODEV and
> -EIO is treated as success. Let's make it handle the -EIO error as
> well.
>
> It's possible that it can't actually return -EIO and this patch is not
> needed but in that case this patch is harmless and silences a static
> checker warning so it's still worth it.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thank you Dan, queued to testing.
--
Darren Hart
Intel Open Source Technology Center
next prev parent reply other threads:[~2015-11-11 6:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-10 22:18 [patch] asus-wmi: fix error handling in store_sys_wmi() Dan Carpenter
2015-11-10 22:18 ` Dan Carpenter
2015-11-11 6:22 ` Darren Hart [this message]
2015-11-11 6:22 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151111062257.GL18221@malice.jf.intel.com \
--to=dvhart@infradead.org \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=corentin.chary@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.