* Re: [PATCH] staging: lustre: cl_lock: Remove cl_lock_lockdep_init wrapper
@ 2015-11-11 17:21 ` Shivani Bhardwaj
0 siblings, 0 replies; 17+ messages in thread
From: Shivani Bhardwaj @ 2015-11-11 17:21 UTC (permalink / raw)
To: kbuild test robot
Cc: kbuild-all, Greg KH, Drokin, Oleg, devel, Dilger, Andreas,
linux-kernel, lustre-devel
On Wed, Nov 11, 2015 at 4:24 PM, kbuild test robot <lkp@intel.com> wrote:
> Hi Shivani,
>
> [auto build test ERROR on staging/staging-testing]
> [also build test ERROR on v4.3 next-20151111]
>
> url: https://github.com/0day-ci/linux/commits/Shivani-Bhardwaj/staging-lustre-cl_lock-Remove-cl_lock_lockdep_init-wrapper/20151111-182452
> config: m68k-allyesconfig (attached as .config)
> reproduce:
> wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # save the attached .config to linux build tree
> make.cross ARCH=m68k
>
> All errors (new ones prefixed by >>):
>
> In file included from include/linux/spinlock_types.h:18:0,
> from include/linux/spinlock.h:81,
> from include/linux/mmzone.h:7,
> from include/linux/gfp.h:5,
> from include/linux/slab.h:14,
> from drivers/staging/lustre/lustre/obdclass/../include/obd_support.h:40,
> from drivers/staging/lustre/lustre/obdclass/../include/obd_class.h:39,
> from drivers/staging/lustre/lustre/obdclass/cl_lock.c:43:
> drivers/staging/lustre/lustre/obdclass/cl_lock.c: In function 'cl_lock_alloc':
>>> drivers/staging/lustre/lustre/obdclass/cl_lock.c:379:37: error: 'cl_lock_key' undeclared (first use in this function)
> lockdep_set_class_and_name(lock, &cl_lock_key, "EXT");
> ^
> include/linux/lockdep.h:401:15: note: in definition of macro 'lockdep_set_class_and_name'
> do { (void)(key); (void)(name); } while (0)
> ^
> drivers/staging/lustre/lustre/obdclass/cl_lock.c:379:37: note: each undeclared identifier is reported only once for each function it appears in
> lockdep_set_class_and_name(lock, &cl_lock_key, "EXT");
> ^
> include/linux/lockdep.h:401:15: note: in definition of macro 'lockdep_set_class_and_name'
> do { (void)(key); (void)(name); } while (0)
> ^
> drivers/staging/lustre/lustre/obdclass/cl_lock.c: At top level:
> drivers/staging/lustre/lustre/obdclass/cl_lock.c:166:13: warning: 'cl_lock_lockdep_init' defined but not used [-Wunused-function]
> static void cl_lock_lockdep_init(struct cl_lock *lock)
> ^
>
> vim +/cl_lock_key +379 drivers/staging/lustre/lustre/obdclass/cl_lock.c
>
> 373 lockdep_set_class(&lock->cll_guard, &cl_lock_guard_class);
> 374 init_waitqueue_head(&lock->cll_wq);
> 375 head = obj->co_lu.lo_header;
> 376 CS_LOCKSTATE_INC(obj, CLS_NEW);
> 377 CS_LOCK_INC(obj, total);
> 378 CS_LOCK_INC(obj, create);
> > 379 lockdep_set_class_and_name(lock, &cl_lock_key, "EXT");
> 380 list_for_each_entry(obj, &head->loh_layers,
> 381 co_lu.lo_linkage) {
> 382 int err;
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
Hi all,
I'm not getting any of these errors at compilation. I've checked
thrice. Could you please tell what am I doing wrong so that I can
avoid introducing errors in future patches?
Thank you
Shivani
^ permalink raw reply [flat|nested] 17+ messages in thread* [lustre-devel] [PATCH] staging: lustre: cl_lock: Remove cl_lock_lockdep_init wrapper
2015-11-11 17:21 ` Shivani Bhardwaj
@ 2015-11-11 17:31 ` Greg KH
-1 siblings, 0 replies; 17+ messages in thread
From: Greg KH @ 2015-11-11 17:31 UTC (permalink / raw)
To: lustre-devel
On Wed, Nov 11, 2015 at 10:51:36PM +0530, Shivani Bhardwaj wrote:
> On Wed, Nov 11, 2015 at 4:24 PM, kbuild test robot <lkp@intel.com> wrote:
> > Hi Shivani,
> >
> > [auto build test ERROR on staging/staging-testing]
> > [also build test ERROR on v4.3 next-20151111]
> >
> > url: https://github.com/0day-ci/linux/commits/Shivani-Bhardwaj/staging-lustre-cl_lock-Remove-cl_lock_lockdep_init-wrapper/20151111-182452
> > config: m68k-allyesconfig (attached as .config)
> > reproduce:
> > wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
> > chmod +x ~/bin/make.cross
> > # save the attached .config to linux build tree
> > make.cross ARCH=m68k
> >
> > All errors (new ones prefixed by >>):
> >
> > In file included from include/linux/spinlock_types.h:18:0,
> > from include/linux/spinlock.h:81,
> > from include/linux/mmzone.h:7,
> > from include/linux/gfp.h:5,
> > from include/linux/slab.h:14,
> > from drivers/staging/lustre/lustre/obdclass/../include/obd_support.h:40,
> > from drivers/staging/lustre/lustre/obdclass/../include/obd_class.h:39,
> > from drivers/staging/lustre/lustre/obdclass/cl_lock.c:43:
> > drivers/staging/lustre/lustre/obdclass/cl_lock.c: In function 'cl_lock_alloc':
> >>> drivers/staging/lustre/lustre/obdclass/cl_lock.c:379:37: error: 'cl_lock_key' undeclared (first use in this function)
> > lockdep_set_class_and_name(lock, &cl_lock_key, "EXT");
> > ^
> > include/linux/lockdep.h:401:15: note: in definition of macro 'lockdep_set_class_and_name'
> > do { (void)(key); (void)(name); } while (0)
> > ^
> > drivers/staging/lustre/lustre/obdclass/cl_lock.c:379:37: note: each undeclared identifier is reported only once for each function it appears in
> > lockdep_set_class_and_name(lock, &cl_lock_key, "EXT");
> > ^
> > include/linux/lockdep.h:401:15: note: in definition of macro 'lockdep_set_class_and_name'
> > do { (void)(key); (void)(name); } while (0)
> > ^
> > drivers/staging/lustre/lustre/obdclass/cl_lock.c: At top level:
> > drivers/staging/lustre/lustre/obdclass/cl_lock.c:166:13: warning: 'cl_lock_lockdep_init' defined but not used [-Wunused-function]
> > static void cl_lock_lockdep_init(struct cl_lock *lock)
> > ^
> >
> > vim +/cl_lock_key +379 drivers/staging/lustre/lustre/obdclass/cl_lock.c
> >
> > 373 lockdep_set_class(&lock->cll_guard, &cl_lock_guard_class);
> > 374 init_waitqueue_head(&lock->cll_wq);
> > 375 head = obj->co_lu.lo_header;
> > 376 CS_LOCKSTATE_INC(obj, CLS_NEW);
> > 377 CS_LOCK_INC(obj, total);
> > 378 CS_LOCK_INC(obj, create);
> > > 379 lockdep_set_class_and_name(lock, &cl_lock_key, "EXT");
> > 380 list_for_each_entry(obj, &head->loh_layers,
> > 381 co_lu.lo_linkage) {
> > 382 int err;
> >
> > ---
> > 0-DAY kernel test infrastructure Open Source Technology Center
> > https://lists.01.org/pipermail/kbuild-all Intel Corporation
>
> Hi all,
>
> I'm not getting any of these errors at compilation. I've checked
> thrice. Could you please tell what am I doing wrong so that I can
> avoid introducing errors in future patches?
Use the .config provided, odds are you have lockdep enabled.
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PATCH] staging: lustre: cl_lock: Remove cl_lock_lockdep_init wrapper
@ 2015-11-11 17:31 ` Greg KH
0 siblings, 0 replies; 17+ messages in thread
From: Greg KH @ 2015-11-11 17:31 UTC (permalink / raw)
To: Shivani Bhardwaj
Cc: kbuild test robot, kbuild-all, Drokin, Oleg, devel,
Dilger, Andreas, linux-kernel, lustre-devel
On Wed, Nov 11, 2015 at 10:51:36PM +0530, Shivani Bhardwaj wrote:
> On Wed, Nov 11, 2015 at 4:24 PM, kbuild test robot <lkp@intel.com> wrote:
> > Hi Shivani,
> >
> > [auto build test ERROR on staging/staging-testing]
> > [also build test ERROR on v4.3 next-20151111]
> >
> > url: https://github.com/0day-ci/linux/commits/Shivani-Bhardwaj/staging-lustre-cl_lock-Remove-cl_lock_lockdep_init-wrapper/20151111-182452
> > config: m68k-allyesconfig (attached as .config)
> > reproduce:
> > wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
> > chmod +x ~/bin/make.cross
> > # save the attached .config to linux build tree
> > make.cross ARCH=m68k
> >
> > All errors (new ones prefixed by >>):
> >
> > In file included from include/linux/spinlock_types.h:18:0,
> > from include/linux/spinlock.h:81,
> > from include/linux/mmzone.h:7,
> > from include/linux/gfp.h:5,
> > from include/linux/slab.h:14,
> > from drivers/staging/lustre/lustre/obdclass/../include/obd_support.h:40,
> > from drivers/staging/lustre/lustre/obdclass/../include/obd_class.h:39,
> > from drivers/staging/lustre/lustre/obdclass/cl_lock.c:43:
> > drivers/staging/lustre/lustre/obdclass/cl_lock.c: In function 'cl_lock_alloc':
> >>> drivers/staging/lustre/lustre/obdclass/cl_lock.c:379:37: error: 'cl_lock_key' undeclared (first use in this function)
> > lockdep_set_class_and_name(lock, &cl_lock_key, "EXT");
> > ^
> > include/linux/lockdep.h:401:15: note: in definition of macro 'lockdep_set_class_and_name'
> > do { (void)(key); (void)(name); } while (0)
> > ^
> > drivers/staging/lustre/lustre/obdclass/cl_lock.c:379:37: note: each undeclared identifier is reported only once for each function it appears in
> > lockdep_set_class_and_name(lock, &cl_lock_key, "EXT");
> > ^
> > include/linux/lockdep.h:401:15: note: in definition of macro 'lockdep_set_class_and_name'
> > do { (void)(key); (void)(name); } while (0)
> > ^
> > drivers/staging/lustre/lustre/obdclass/cl_lock.c: At top level:
> > drivers/staging/lustre/lustre/obdclass/cl_lock.c:166:13: warning: 'cl_lock_lockdep_init' defined but not used [-Wunused-function]
> > static void cl_lock_lockdep_init(struct cl_lock *lock)
> > ^
> >
> > vim +/cl_lock_key +379 drivers/staging/lustre/lustre/obdclass/cl_lock.c
> >
> > 373 lockdep_set_class(&lock->cll_guard, &cl_lock_guard_class);
> > 374 init_waitqueue_head(&lock->cll_wq);
> > 375 head = obj->co_lu.lo_header;
> > 376 CS_LOCKSTATE_INC(obj, CLS_NEW);
> > 377 CS_LOCK_INC(obj, total);
> > 378 CS_LOCK_INC(obj, create);
> > > 379 lockdep_set_class_and_name(lock, &cl_lock_key, "EXT");
> > 380 list_for_each_entry(obj, &head->loh_layers,
> > 381 co_lu.lo_linkage) {
> > 382 int err;
> >
> > ---
> > 0-DAY kernel test infrastructure Open Source Technology Center
> > https://lists.01.org/pipermail/kbuild-all Intel Corporation
>
> Hi all,
>
> I'm not getting any of these errors at compilation. I've checked
> thrice. Could you please tell what am I doing wrong so that I can
> avoid introducing errors in future patches?
Use the .config provided, odds are you have lockdep enabled.
^ permalink raw reply [flat|nested] 17+ messages in thread* [lustre-devel] [PATCH] staging: lustre: cl_lock: Remove cl_lock_lockdep_init wrapper
2015-11-11 17:31 ` Greg KH
@ 2015-11-11 17:33 ` Shivani Bhardwaj
-1 siblings, 0 replies; 17+ messages in thread
From: Shivani Bhardwaj @ 2015-11-11 17:33 UTC (permalink / raw)
To: lustre-devel
On Wed, Nov 11, 2015 at 11:01 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Wed, Nov 11, 2015 at 10:51:36PM +0530, Shivani Bhardwaj wrote:
>> On Wed, Nov 11, 2015 at 4:24 PM, kbuild test robot <lkp@intel.com> wrote:
>> > Hi Shivani,
>> >
>> > [auto build test ERROR on staging/staging-testing]
>> > [also build test ERROR on v4.3 next-20151111]
>> >
>> > url: https://github.com/0day-ci/linux/commits/Shivani-Bhardwaj/staging-lustre-cl_lock-Remove-cl_lock_lockdep_init-wrapper/20151111-182452
>> > config: m68k-allyesconfig (attached as .config)
>> > reproduce:
>> > wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>> > chmod +x ~/bin/make.cross
>> > # save the attached .config to linux build tree
>> > make.cross ARCH=m68k
>> >
>> > All errors (new ones prefixed by >>):
>> >
>> > In file included from include/linux/spinlock_types.h:18:0,
>> > from include/linux/spinlock.h:81,
>> > from include/linux/mmzone.h:7,
>> > from include/linux/gfp.h:5,
>> > from include/linux/slab.h:14,
>> > from drivers/staging/lustre/lustre/obdclass/../include/obd_support.h:40,
>> > from drivers/staging/lustre/lustre/obdclass/../include/obd_class.h:39,
>> > from drivers/staging/lustre/lustre/obdclass/cl_lock.c:43:
>> > drivers/staging/lustre/lustre/obdclass/cl_lock.c: In function 'cl_lock_alloc':
>> >>> drivers/staging/lustre/lustre/obdclass/cl_lock.c:379:37: error: 'cl_lock_key' undeclared (first use in this function)
>> > lockdep_set_class_and_name(lock, &cl_lock_key, "EXT");
>> > ^
>> > include/linux/lockdep.h:401:15: note: in definition of macro 'lockdep_set_class_and_name'
>> > do { (void)(key); (void)(name); } while (0)
>> > ^
>> > drivers/staging/lustre/lustre/obdclass/cl_lock.c:379:37: note: each undeclared identifier is reported only once for each function it appears in
>> > lockdep_set_class_and_name(lock, &cl_lock_key, "EXT");
>> > ^
>> > include/linux/lockdep.h:401:15: note: in definition of macro 'lockdep_set_class_and_name'
>> > do { (void)(key); (void)(name); } while (0)
>> > ^
>> > drivers/staging/lustre/lustre/obdclass/cl_lock.c: At top level:
>> > drivers/staging/lustre/lustre/obdclass/cl_lock.c:166:13: warning: 'cl_lock_lockdep_init' defined but not used [-Wunused-function]
>> > static void cl_lock_lockdep_init(struct cl_lock *lock)
>> > ^
>> >
>> > vim +/cl_lock_key +379 drivers/staging/lustre/lustre/obdclass/cl_lock.c
>> >
>> > 373 lockdep_set_class(&lock->cll_guard, &cl_lock_guard_class);
>> > 374 init_waitqueue_head(&lock->cll_wq);
>> > 375 head = obj->co_lu.lo_header;
>> > 376 CS_LOCKSTATE_INC(obj, CLS_NEW);
>> > 377 CS_LOCK_INC(obj, total);
>> > 378 CS_LOCK_INC(obj, create);
>> > > 379 lockdep_set_class_and_name(lock, &cl_lock_key, "EXT");
>> > 380 list_for_each_entry(obj, &head->loh_layers,
>> > 381 co_lu.lo_linkage) {
>> > 382 int err;
>> >
>> > ---
>> > 0-DAY kernel test infrastructure Open Source Technology Center
>> > https://lists.01.org/pipermail/kbuild-all Intel Corporation
>>
>> Hi all,
>>
>> I'm not getting any of these errors at compilation. I've checked
>> thrice. Could you please tell what am I doing wrong so that I can
>> avoid introducing errors in future patches?
>
> Use the .config provided, odds are you have lockdep enabled.
Thanks Greg.
I tried that. Still no errors. Any other suggestion?
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PATCH] staging: lustre: cl_lock: Remove cl_lock_lockdep_init wrapper
@ 2015-11-11 17:33 ` Shivani Bhardwaj
0 siblings, 0 replies; 17+ messages in thread
From: Shivani Bhardwaj @ 2015-11-11 17:33 UTC (permalink / raw)
To: Greg KH
Cc: kbuild test robot, kbuild-all, Drokin, Oleg, devel,
Dilger, Andreas, linux-kernel, lustre-devel
On Wed, Nov 11, 2015 at 11:01 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Wed, Nov 11, 2015 at 10:51:36PM +0530, Shivani Bhardwaj wrote:
>> On Wed, Nov 11, 2015 at 4:24 PM, kbuild test robot <lkp@intel.com> wrote:
>> > Hi Shivani,
>> >
>> > [auto build test ERROR on staging/staging-testing]
>> > [also build test ERROR on v4.3 next-20151111]
>> >
>> > url: https://github.com/0day-ci/linux/commits/Shivani-Bhardwaj/staging-lustre-cl_lock-Remove-cl_lock_lockdep_init-wrapper/20151111-182452
>> > config: m68k-allyesconfig (attached as .config)
>> > reproduce:
>> > wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>> > chmod +x ~/bin/make.cross
>> > # save the attached .config to linux build tree
>> > make.cross ARCH=m68k
>> >
>> > All errors (new ones prefixed by >>):
>> >
>> > In file included from include/linux/spinlock_types.h:18:0,
>> > from include/linux/spinlock.h:81,
>> > from include/linux/mmzone.h:7,
>> > from include/linux/gfp.h:5,
>> > from include/linux/slab.h:14,
>> > from drivers/staging/lustre/lustre/obdclass/../include/obd_support.h:40,
>> > from drivers/staging/lustre/lustre/obdclass/../include/obd_class.h:39,
>> > from drivers/staging/lustre/lustre/obdclass/cl_lock.c:43:
>> > drivers/staging/lustre/lustre/obdclass/cl_lock.c: In function 'cl_lock_alloc':
>> >>> drivers/staging/lustre/lustre/obdclass/cl_lock.c:379:37: error: 'cl_lock_key' undeclared (first use in this function)
>> > lockdep_set_class_and_name(lock, &cl_lock_key, "EXT");
>> > ^
>> > include/linux/lockdep.h:401:15: note: in definition of macro 'lockdep_set_class_and_name'
>> > do { (void)(key); (void)(name); } while (0)
>> > ^
>> > drivers/staging/lustre/lustre/obdclass/cl_lock.c:379:37: note: each undeclared identifier is reported only once for each function it appears in
>> > lockdep_set_class_and_name(lock, &cl_lock_key, "EXT");
>> > ^
>> > include/linux/lockdep.h:401:15: note: in definition of macro 'lockdep_set_class_and_name'
>> > do { (void)(key); (void)(name); } while (0)
>> > ^
>> > drivers/staging/lustre/lustre/obdclass/cl_lock.c: At top level:
>> > drivers/staging/lustre/lustre/obdclass/cl_lock.c:166:13: warning: 'cl_lock_lockdep_init' defined but not used [-Wunused-function]
>> > static void cl_lock_lockdep_init(struct cl_lock *lock)
>> > ^
>> >
>> > vim +/cl_lock_key +379 drivers/staging/lustre/lustre/obdclass/cl_lock.c
>> >
>> > 373 lockdep_set_class(&lock->cll_guard, &cl_lock_guard_class);
>> > 374 init_waitqueue_head(&lock->cll_wq);
>> > 375 head = obj->co_lu.lo_header;
>> > 376 CS_LOCKSTATE_INC(obj, CLS_NEW);
>> > 377 CS_LOCK_INC(obj, total);
>> > 378 CS_LOCK_INC(obj, create);
>> > > 379 lockdep_set_class_and_name(lock, &cl_lock_key, "EXT");
>> > 380 list_for_each_entry(obj, &head->loh_layers,
>> > 381 co_lu.lo_linkage) {
>> > 382 int err;
>> >
>> > ---
>> > 0-DAY kernel test infrastructure Open Source Technology Center
>> > https://lists.01.org/pipermail/kbuild-all Intel Corporation
>>
>> Hi all,
>>
>> I'm not getting any of these errors at compilation. I've checked
>> thrice. Could you please tell what am I doing wrong so that I can
>> avoid introducing errors in future patches?
>
> Use the .config provided, odds are you have lockdep enabled.
Thanks Greg.
I tried that. Still no errors. Any other suggestion?
^ permalink raw reply [flat|nested] 17+ messages in thread* [lustre-devel] [PATCH] staging: lustre: cl_lock: Remove cl_lock_lockdep_init wrapper
2015-11-11 17:33 ` Shivani Bhardwaj
@ 2015-11-13 13:03 ` Sudip Mukherjee
-1 siblings, 0 replies; 17+ messages in thread
From: Sudip Mukherjee @ 2015-11-13 13:03 UTC (permalink / raw)
To: lustre-devel
On Wed, Nov 11, 2015 at 11:03:34PM +0530, Shivani Bhardwaj wrote:
> On Wed, Nov 11, 2015 at 11:01 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Wed, Nov 11, 2015 at 10:51:36PM +0530, Shivani Bhardwaj wrote:
> >> On Wed, Nov 11, 2015 at 4:24 PM, kbuild test robot <lkp@intel.com> wrote:
<snip>
> >>
> >> I'm not getting any of these errors at compilation. I've checked
> >> thrice. Could you please tell what am I doing wrong so that I can
> >> avoid introducing errors in future patches?
> >
> > Use the .config provided, odds are you have lockdep enabled.
>
> Thanks Greg.
> I tried that. Still no errors. Any other suggestion?
while removing the wrapper you missed that cl_lock_lockdep_init() is:
static void cl_lock_lockdep_init(struct cl_lock *lock)
{
lockdep_set_class_and_name(lock, &cl_lock_key, "EXT");
}
if CONFIG_LOCKDEP is defined.
and if CONFIG_LOCKDEP is not defined then:
static void cl_lock_lockdep_init(struct cl_lock *lock)
{}
your patch is using lockdep_set_class_and_name() in both cases.
regards
sudip
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PATCH] staging: lustre: cl_lock: Remove cl_lock_lockdep_init wrapper
@ 2015-11-13 13:03 ` Sudip Mukherjee
0 siblings, 0 replies; 17+ messages in thread
From: Sudip Mukherjee @ 2015-11-13 13:03 UTC (permalink / raw)
To: Shivani Bhardwaj
Cc: Greg KH, devel, Dilger, Andreas, linux-kernel, Drokin, Oleg,
kbuild-all, lustre-devel
On Wed, Nov 11, 2015 at 11:03:34PM +0530, Shivani Bhardwaj wrote:
> On Wed, Nov 11, 2015 at 11:01 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Wed, Nov 11, 2015 at 10:51:36PM +0530, Shivani Bhardwaj wrote:
> >> On Wed, Nov 11, 2015 at 4:24 PM, kbuild test robot <lkp@intel.com> wrote:
<snip>
> >>
> >> I'm not getting any of these errors at compilation. I've checked
> >> thrice. Could you please tell what am I doing wrong so that I can
> >> avoid introducing errors in future patches?
> >
> > Use the .config provided, odds are you have lockdep enabled.
>
> Thanks Greg.
> I tried that. Still no errors. Any other suggestion?
while removing the wrapper you missed that cl_lock_lockdep_init() is:
static void cl_lock_lockdep_init(struct cl_lock *lock)
{
lockdep_set_class_and_name(lock, &cl_lock_key, "EXT");
}
if CONFIG_LOCKDEP is defined.
and if CONFIG_LOCKDEP is not defined then:
static void cl_lock_lockdep_init(struct cl_lock *lock)
{}
your patch is using lockdep_set_class_and_name() in both cases.
regards
sudip
^ permalink raw reply [flat|nested] 17+ messages in thread* [lustre-devel] [PATCH] staging: lustre: cl_lock: Remove cl_lock_lockdep_init wrapper
2015-11-13 13:03 ` Sudip Mukherjee
@ 2015-11-13 13:06 ` Shivani Bhardwaj
-1 siblings, 0 replies; 17+ messages in thread
From: Shivani Bhardwaj @ 2015-11-13 13:06 UTC (permalink / raw)
To: lustre-devel
On Fri, Nov 13, 2015 at 6:33 PM, Sudip Mukherjee
<sudipm.mukherjee@gmail.com> wrote:
>
> On Wed, Nov 11, 2015 at 11:03:34PM +0530, Shivani Bhardwaj wrote:
> > On Wed, Nov 11, 2015 at 11:01 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > > On Wed, Nov 11, 2015 at 10:51:36PM +0530, Shivani Bhardwaj wrote:
> > >> On Wed, Nov 11, 2015 at 4:24 PM, kbuild test robot <lkp@intel.com> wrote:
> <snip>
> > >>
> > >> I'm not getting any of these errors at compilation. I've checked
> > >> thrice. Could you please tell what am I doing wrong so that I can
> > >> avoid introducing errors in future patches?
> > >
> > > Use the .config provided, odds are you have lockdep enabled.
> >
> > Thanks Greg.
> > I tried that. Still no errors. Any other suggestion?
>
> while removing the wrapper you missed that cl_lock_lockdep_init() is:
>
> static void cl_lock_lockdep_init(struct cl_lock *lock)
> {
> lockdep_set_class_and_name(lock, &cl_lock_key, "EXT");
> }
>
> if CONFIG_LOCKDEP is defined.
> and if CONFIG_LOCKDEP is not defined then:
>
> static void cl_lock_lockdep_init(struct cl_lock *lock)
> {}
>
> your patch is using lockdep_set_class_and_name() in both cases.
>
Yes! This is the problem.
Thank you Sudip.
> regards
> sudip
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PATCH] staging: lustre: cl_lock: Remove cl_lock_lockdep_init wrapper
@ 2015-11-13 13:06 ` Shivani Bhardwaj
0 siblings, 0 replies; 17+ messages in thread
From: Shivani Bhardwaj @ 2015-11-13 13:06 UTC (permalink / raw)
To: Sudip Mukherjee
Cc: Greg KH, devel, Dilger, Andreas, linux-kernel, Drokin, Oleg,
kbuild-all, lustre-devel
On Fri, Nov 13, 2015 at 6:33 PM, Sudip Mukherjee
<sudipm.mukherjee@gmail.com> wrote:
>
> On Wed, Nov 11, 2015 at 11:03:34PM +0530, Shivani Bhardwaj wrote:
> > On Wed, Nov 11, 2015 at 11:01 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > > On Wed, Nov 11, 2015 at 10:51:36PM +0530, Shivani Bhardwaj wrote:
> > >> On Wed, Nov 11, 2015 at 4:24 PM, kbuild test robot <lkp@intel.com> wrote:
> <snip>
> > >>
> > >> I'm not getting any of these errors at compilation. I've checked
> > >> thrice. Could you please tell what am I doing wrong so that I can
> > >> avoid introducing errors in future patches?
> > >
> > > Use the .config provided, odds are you have lockdep enabled.
> >
> > Thanks Greg.
> > I tried that. Still no errors. Any other suggestion?
>
> while removing the wrapper you missed that cl_lock_lockdep_init() is:
>
> static void cl_lock_lockdep_init(struct cl_lock *lock)
> {
> lockdep_set_class_and_name(lock, &cl_lock_key, "EXT");
> }
>
> if CONFIG_LOCKDEP is defined.
> and if CONFIG_LOCKDEP is not defined then:
>
> static void cl_lock_lockdep_init(struct cl_lock *lock)
> {}
>
> your patch is using lockdep_set_class_and_name() in both cases.
>
Yes! This is the problem.
Thank you Sudip.
> regards
> sudip
^ permalink raw reply [flat|nested] 17+ messages in thread
* [lustre-devel] [PATCH] staging: lustre: cl_lock: Remove cl_lock_lockdep_init wrapper
2015-11-11 17:21 ` Shivani Bhardwaj
@ 2015-11-13 0:59 ` Dilger, Andreas
-1 siblings, 0 replies; 17+ messages in thread
From: Dilger, Andreas @ 2015-11-13 0:59 UTC (permalink / raw)
To: lustre-devel
On 2015/11/11, 10:21, "lustre-devel on behalf of Shivani Bhardwaj"
<lustre-devel-bounces at lists.lustre.org on behalf of shivanib134@gmail.com>
wrote:
>On Wed, Nov 11, 2015 at 4:24 PM, kbuild test robot <lkp@intel.com> wrote:
>> Hi Shivani,
>>
>> [auto build test ERROR on staging/staging-testing]
>> [also build test ERROR on v4.3 next-20151111]
>>
>> url:
>>https://github.com/0day-ci/linux/commits/Shivani-Bhardwaj/staging-lustre-
>>cl_lock-Remove-cl_lock_lockdep_init-wrapper/20151111-182452
>> config: m68k-allyesconfig (attached as .config)
>> reproduce:
>> wget
>>https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin
>>/make.cross -O ~/bin/make.cross
>> chmod +x ~/bin/make.cross
>> # save the attached .config to linux build tree
>> make.cross ARCH=m68k
>>
>> All errors (new ones prefixed by >>):
>>
>> In file included from include/linux/spinlock_types.h:18:0,
>> from include/linux/spinlock.h:81,
>> from include/linux/mmzone.h:7,
>> from include/linux/gfp.h:5,
>> from include/linux/slab.h:14,
>> from
>>drivers/staging/lustre/lustre/obdclass/../include/obd_support.h:40,
>> from
>>drivers/staging/lustre/lustre/obdclass/../include/obd_class.h:39,
>> from
>>drivers/staging/lustre/lustre/obdclass/cl_lock.c:43:
>> drivers/staging/lustre/lustre/obdclass/cl_lock.c: In function
>>'cl_lock_alloc':
>>>> drivers/staging/lustre/lustre/obdclass/cl_lock.c:379:37: error:
>>>>'cl_lock_key' undeclared (first use in this function)
>> lockdep_set_class_and_name(lock, &cl_lock_key, "EXT");
>> ^
>> include/linux/lockdep.h:401:15: note: in definition of macro
>>'lockdep_set_class_and_name'
>> do { (void)(key); (void)(name); } while (0)
>> ^
>> drivers/staging/lustre/lustre/obdclass/cl_lock.c:379:37: note: each
>>undeclared identifier is reported only once for each function it appears
>>in
>> lockdep_set_class_and_name(lock, &cl_lock_key, "EXT");
>> ^
>> include/linux/lockdep.h:401:15: note: in definition of macro
>>'lockdep_set_class_and_name'
>> do { (void)(key); (void)(name); } while (0)
>> ^
>> drivers/staging/lustre/lustre/obdclass/cl_lock.c: At top level:
>> drivers/staging/lustre/lustre/obdclass/cl_lock.c:166:13: warning:
>>'cl_lock_lockdep_init' defined but not used [-Wunused-function]
>> static void cl_lock_lockdep_init(struct cl_lock *lock)
>> ^
>>
>> vim +/cl_lock_key +379 drivers/staging/lustre/lustre/obdclass/cl_lock.c
>>
>> 373 lockdep_set_class(&lock->cll_guard,
>>&cl_lock_guard_class);
>> 374 init_waitqueue_head(&lock->cll_wq);
>> 375 head = obj->co_lu.lo_header;
>> 376 CS_LOCKSTATE_INC(obj, CLS_NEW);
>> 377 CS_LOCK_INC(obj, total);
>> 378 CS_LOCK_INC(obj, create);
>> > 379 lockdep_set_class_and_name(lock, &cl_lock_key,
>>"EXT");
>> 380 list_for_each_entry(obj, &head->loh_layers,
>> 381 co_lu.lo_linkage) {
>> 382 int err;
>>
>> ---
>> 0-DAY kernel test infrastructure Open Source Technology
>>Center
>> https://lists.01.org/pipermail/kbuild-all Intel
>>Corporation
>
>Hi all,
>
>I'm not getting any of these errors at compilation. I've checked
>thrice. Could you please tell what am I doing wrong so that I can
>avoid introducing errors in future patches?
You need to have CONFIG_LOCKDEP_SUPPORT=y in your kernel .config file.
Cheers, Andreas
--
Andreas Dilger
Lustre Principal Engineer
Intel High Performance Data Division
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [lustre-devel] [PATCH] staging: lustre: cl_lock: Remove cl_lock_lockdep_init wrapper
@ 2015-11-13 0:59 ` Dilger, Andreas
0 siblings, 0 replies; 17+ messages in thread
From: Dilger, Andreas @ 2015-11-13 0:59 UTC (permalink / raw)
To: Shivani Bhardwaj, lkp
Cc: devel@driverdev.osuosl.org, Greg KH, linux-kernel@vger.kernel.org,
Drokin, Oleg, kbuild-all@01.org, lustre-devel@lists.lustre.org
On 2015/11/11, 10:21, "lustre-devel on behalf of Shivani Bhardwaj"
<lustre-devel-bounces@lists.lustre.org on behalf of shivanib134@gmail.com>
wrote:
>On Wed, Nov 11, 2015 at 4:24 PM, kbuild test robot <lkp@intel.com> wrote:
>> Hi Shivani,
>>
>> [auto build test ERROR on staging/staging-testing]
>> [also build test ERROR on v4.3 next-20151111]
>>
>> url:
>>https://github.com/0day-ci/linux/commits/Shivani-Bhardwaj/staging-lustre-
>>cl_lock-Remove-cl_lock_lockdep_init-wrapper/20151111-182452
>> config: m68k-allyesconfig (attached as .config)
>> reproduce:
>> wget
>>https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin
>>/make.cross -O ~/bin/make.cross
>> chmod +x ~/bin/make.cross
>> # save the attached .config to linux build tree
>> make.cross ARCH=m68k
>>
>> All errors (new ones prefixed by >>):
>>
>> In file included from include/linux/spinlock_types.h:18:0,
>> from include/linux/spinlock.h:81,
>> from include/linux/mmzone.h:7,
>> from include/linux/gfp.h:5,
>> from include/linux/slab.h:14,
>> from
>>drivers/staging/lustre/lustre/obdclass/../include/obd_support.h:40,
>> from
>>drivers/staging/lustre/lustre/obdclass/../include/obd_class.h:39,
>> from
>>drivers/staging/lustre/lustre/obdclass/cl_lock.c:43:
>> drivers/staging/lustre/lustre/obdclass/cl_lock.c: In function
>>'cl_lock_alloc':
>>>> drivers/staging/lustre/lustre/obdclass/cl_lock.c:379:37: error:
>>>>'cl_lock_key' undeclared (first use in this function)
>> lockdep_set_class_and_name(lock, &cl_lock_key, "EXT");
>> ^
>> include/linux/lockdep.h:401:15: note: in definition of macro
>>'lockdep_set_class_and_name'
>> do { (void)(key); (void)(name); } while (0)
>> ^
>> drivers/staging/lustre/lustre/obdclass/cl_lock.c:379:37: note: each
>>undeclared identifier is reported only once for each function it appears
>>in
>> lockdep_set_class_and_name(lock, &cl_lock_key, "EXT");
>> ^
>> include/linux/lockdep.h:401:15: note: in definition of macro
>>'lockdep_set_class_and_name'
>> do { (void)(key); (void)(name); } while (0)
>> ^
>> drivers/staging/lustre/lustre/obdclass/cl_lock.c: At top level:
>> drivers/staging/lustre/lustre/obdclass/cl_lock.c:166:13: warning:
>>'cl_lock_lockdep_init' defined but not used [-Wunused-function]
>> static void cl_lock_lockdep_init(struct cl_lock *lock)
>> ^
>>
>> vim +/cl_lock_key +379 drivers/staging/lustre/lustre/obdclass/cl_lock.c
>>
>> 373 lockdep_set_class(&lock->cll_guard,
>>&cl_lock_guard_class);
>> 374 init_waitqueue_head(&lock->cll_wq);
>> 375 head = obj->co_lu.lo_header;
>> 376 CS_LOCKSTATE_INC(obj, CLS_NEW);
>> 377 CS_LOCK_INC(obj, total);
>> 378 CS_LOCK_INC(obj, create);
>> > 379 lockdep_set_class_and_name(lock, &cl_lock_key,
>>"EXT");
>> 380 list_for_each_entry(obj, &head->loh_layers,
>> 381 co_lu.lo_linkage) {
>> 382 int err;
>>
>> ---
>> 0-DAY kernel test infrastructure Open Source Technology
>>Center
>> https://lists.01.org/pipermail/kbuild-all Intel
>>Corporation
>
>Hi all,
>
>I'm not getting any of these errors at compilation. I've checked
>thrice. Could you please tell what am I doing wrong so that I can
>avoid introducing errors in future patches?
You need to have CONFIG_LOCKDEP_SUPPORT=y in your kernel .config file.
Cheers, Andreas
--
Andreas Dilger
Lustre Principal Engineer
Intel High Performance Data Division
^ permalink raw reply [flat|nested] 17+ messages in thread* [lustre-devel] [PATCH] staging: lustre: cl_lock: Remove cl_lock_lockdep_init wrapper
2015-11-13 0:59 ` Dilger, Andreas
(?)
@ 2015-11-13 5:14 ` Shivani Bhardwaj
-1 siblings, 0 replies; 17+ messages in thread
From: Shivani Bhardwaj @ 2015-11-13 5:14 UTC (permalink / raw)
To: lustre-devel
On Fri, Nov 13, 2015 at 6:29 AM, Dilger, Andreas <andreas.dilger@intel.com>
wrote:
> On 2015/11/11, 10:21, "lustre-devel on behalf of Shivani Bhardwaj"
> <lustre-devel-bounces at lists.lustre.org on behalf of shivanib134@gmail.com>
> wrote:
>
> >On Wed, Nov 11, 2015 at 4:24 PM, kbuild test robot <lkp@intel.com> wrote:
> >> Hi Shivani,
> >>
> >> [auto build test ERROR on staging/staging-testing]
> >> [also build test ERROR on v4.3 next-20151111]
> >>
> >> url:
> >>
> https://github.com/0day-ci/linux/commits/Shivani-Bhardwaj/staging-lustre-
> >>cl_lock-Remove-cl_lock_lockdep_init-wrapper/20151111-182452
> >> config: m68k-allyesconfig (attached as .config)
> >> reproduce:
> >> wget
> >>
> https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin
> >>/make.cross -O ~/bin/make.cross
> >> chmod +x ~/bin/make.cross
> >> # save the attached .config to linux build tree
> >> make.cross ARCH=m68k
> >>
> >> All errors (new ones prefixed by >>):
> >>
> >> In file included from include/linux/spinlock_types.h:18:0,
> >> from include/linux/spinlock.h:81,
> >> from include/linux/mmzone.h:7,
> >> from include/linux/gfp.h:5,
> >> from include/linux/slab.h:14,
> >> from
> >>drivers/staging/lustre/lustre/obdclass/../include/obd_support.h:40,
> >> from
> >>drivers/staging/lustre/lustre/obdclass/../include/obd_class.h:39,
> >> from
> >>drivers/staging/lustre/lustre/obdclass/cl_lock.c:43:
> >> drivers/staging/lustre/lustre/obdclass/cl_lock.c: In function
> >>'cl_lock_alloc':
> >>>> drivers/staging/lustre/lustre/obdclass/cl_lock.c:379:37: error:
> >>>>'cl_lock_key' undeclared (first use in this function)
> >> lockdep_set_class_and_name(lock, &cl_lock_key, "EXT");
> >> ^
> >> include/linux/lockdep.h:401:15: note: in definition of macro
> >>'lockdep_set_class_and_name'
> >> do { (void)(key); (void)(name); } while (0)
> >> ^
> >> drivers/staging/lustre/lustre/obdclass/cl_lock.c:379:37: note: each
> >>undeclared identifier is reported only once for each function it appears
> >>in
> >> lockdep_set_class_and_name(lock, &cl_lock_key, "EXT");
> >> ^
> >> include/linux/lockdep.h:401:15: note: in definition of macro
> >>'lockdep_set_class_and_name'
> >> do { (void)(key); (void)(name); } while (0)
> >> ^
> >> drivers/staging/lustre/lustre/obdclass/cl_lock.c: At top level:
> >> drivers/staging/lustre/lustre/obdclass/cl_lock.c:166:13: warning:
> >>'cl_lock_lockdep_init' defined but not used [-Wunused-function]
> >> static void cl_lock_lockdep_init(struct cl_lock *lock)
> >> ^
> >>
> >> vim +/cl_lock_key +379 drivers/staging/lustre/lustre/obdclass/cl_lock.c
> >>
> >> 373 lockdep_set_class(&lock->cll_guard,
> >>&cl_lock_guard_class);
> >> 374 init_waitqueue_head(&lock->cll_wq);
> >> 375 head = obj->co_lu.lo_header;
> >> 376 CS_LOCKSTATE_INC(obj, CLS_NEW);
> >> 377 CS_LOCK_INC(obj, total);
> >> 378 CS_LOCK_INC(obj, create);
> >> > 379 lockdep_set_class_and_name(lock, &cl_lock_key,
> >>"EXT");
> >> 380 list_for_each_entry(obj, &head->loh_layers,
> >> 381 co_lu.lo_linkage) {
> >> 382 int err;
> >>
> >> ---
> >> 0-DAY kernel test infrastructure Open Source Technology
> >>Center
> >> https://lists.01.org/pipermail/kbuild-all Intel
> >>Corporation
> >
> >Hi all,
> >
> >I'm not getting any of these errors at compilation. I've checked
> >thrice. Could you please tell what am I doing wrong so that I can
> >avoid introducing errors in future patches?
>
> You need to have CONFIG_LOCKDEP_SUPPORT=y in your kernel .config file.
>
>
Thanks Andreas
It is already set to 'y'. I still do not get any errors. Can there be any
other cause?
> Cheers, Andreas
> --
> Andreas Dilger
>
> Lustre Principal Engineer
> Intel High Performance Data Division
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lustre.org/pipermail/lustre-devel-lustre.org/attachments/20151113/d646fb13/attachment.htm>
^ permalink raw reply [flat|nested] 17+ messages in thread