From: Mike Snitzer <snitzer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Cc: Mike Christie <michaelc-hcNo3dDEHLuVc3sceRu5cw@public.gmane.org>,
linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
device-mapper development
<dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org
Subject: Re: [RFC PATCH 00/32] separate operations from flags in the bio/request structs
Date: Wed, 11 Nov 2015 12:37:20 -0500 [thread overview]
Message-ID: <20151111173719.GB12236@redhat.com> (raw)
In-Reply-To: <20151111112846.GA358-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
On Wed, Nov 11 2015 at 6:28am -0500,
Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org> wrote:
> On Wed, Nov 11, 2015 at 01:53:24AM -0600, Mike Christie wrote:
> > We no longer have the bvec merge functions so the original reason given
> > in the thread/patch Bart referenced is no longer valid.
> >
> > Offlist it was suggested that dropping the argument from submit_bio
> > might still improve performance, but I modified xfs and dm and did some
> > testing and did not see anything.
> >
> > So the change is not needed, and it would only be done because people
> > feel it would improve the interface.
>
> I would defintively prefer the changed interface, and to me it also
> looks like it would make your overall patch simpler. If you disagree
> feel free to keep it as-is for now and I'll do another pass later.
The less churn the better. But honestly, not quite following the logic
on why all this flag-day churn is needed. BUT if it needs to happen,
because we'll soon hit a wall on supported operations via REQ_*, now is
as good a time as any -- but best to limit the change to the flags IMHO.
WARNING: multiple messages have this Message-ID (diff)
From: Mike Snitzer <snitzer@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Mike Christie <michaelc@cs.wisc.edu>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-raid@vger.kernel.org,
device-mapper development <dm-devel@redhat.com>,
linux-fsdevel@vger.kernel.org, drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] [RFC PATCH 00/32] separate operations from flags in the bio/request structs
Date: Wed, 11 Nov 2015 12:37:20 -0500 [thread overview]
Message-ID: <20151111173719.GB12236@redhat.com> (raw)
In-Reply-To: <20151111112846.GA358@infradead.org>
On Wed, Nov 11 2015 at 6:28am -0500,
Christoph Hellwig <hch@infradead.org> wrote:
> On Wed, Nov 11, 2015 at 01:53:24AM -0600, Mike Christie wrote:
> > We no longer have the bvec merge functions so the original reason given
> > in the thread/patch Bart referenced is no longer valid.
> >
> > Offlist it was suggested that dropping the argument from submit_bio
> > might still improve performance, but I modified xfs and dm and did some
> > testing and did not see anything.
> >
> > So the change is not needed, and it would only be done because people
> > feel it would improve the interface.
>
> I would defintively prefer the changed interface, and to me it also
> looks like it would make your overall patch simpler. If you disagree
> feel free to keep it as-is for now and I'll do another pass later.
The less churn the better. But honestly, not quite following the logic
on why all this flag-day churn is needed. BUT if it needs to happen,
because we'll soon hit a wall on supported operations via REQ_*, now is
as good a time as any -- but best to limit the change to the flags IMHO.
WARNING: multiple messages have this Message-ID (diff)
From: Mike Snitzer <snitzer@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Mike Christie <michaelc@cs.wisc.edu>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-raid@vger.kernel.org,
device-mapper development <dm-devel@redhat.com>,
linux-fsdevel@vger.kernel.org,
Bart Van Assche <bart.vanassche@sandisk.com>,
drbd-dev@lists.linbit.com
Subject: Re: [RFC PATCH 00/32] separate operations from flags in the bio/request structs
Date: Wed, 11 Nov 2015 12:37:20 -0500 [thread overview]
Message-ID: <20151111173719.GB12236@redhat.com> (raw)
In-Reply-To: <20151111112846.GA358@infradead.org>
On Wed, Nov 11 2015 at 6:28am -0500,
Christoph Hellwig <hch@infradead.org> wrote:
> On Wed, Nov 11, 2015 at 01:53:24AM -0600, Mike Christie wrote:
> > We no longer have the bvec merge functions so the original reason given
> > in the thread/patch Bart referenced is no longer valid.
> >
> > Offlist it was suggested that dropping the argument from submit_bio
> > might still improve performance, but I modified xfs and dm and did some
> > testing and did not see anything.
> >
> > So the change is not needed, and it would only be done because people
> > feel it would improve the interface.
>
> I would defintively prefer the changed interface, and to me it also
> looks like it would make your overall patch simpler. If you disagree
> feel free to keep it as-is for now and I'll do another pass later.
The less churn the better. But honestly, not quite following the logic
on why all this flag-day churn is needed. BUT if it needs to happen,
because we'll soon hit a wall on supported operations via REQ_*, now is
as good a time as any -- but best to limit the change to the flags IMHO.
next prev parent reply other threads:[~2015-11-11 17:37 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-04 16:32 [RFC PATCH 00/32] separate operations from flags in the bio/request structs mchristi
2015-11-04 16:32 ` [Drbd-dev] " mchristi
2015-11-04 16:32 ` [PATCH 01/32] block/fs: add REQ_OP definitions mchristi
2015-11-04 16:32 ` [Drbd-dev] " mchristi
2015-11-04 16:32 ` [PATCH 02/32] block/fs/mm: prepare submit_bio_wait users for bi_rw split mchristi
2015-11-04 16:32 ` [Drbd-dev] " mchristi
2015-11-04 16:32 ` [PATCH 03/32] dio/btrfs: prep dio->submit_bio " mchristi
2015-11-04 16:32 ` [Drbd-dev] " mchristi
2015-11-04 16:32 ` [PATCH 04/32] block: prepare blkdev_issue_discard " mchristi
2015-11-04 16:32 ` [Drbd-dev] " mchristi
2015-11-04 16:33 ` [PATCH 05/32] drbd: prepare drbd " mchristi
2015-11-04 16:33 ` [Drbd-dev] " mchristi
2015-11-04 16:33 ` [PATCH 06/32] xen blkback: prepare " mchristi
2015-11-04 16:33 ` [Drbd-dev] " mchristi
2015-11-04 16:33 ` [PATCH 07/32] dm: " mchristi
2015-11-04 16:33 ` [Drbd-dev] " mchristi
2015-11-04 16:33 ` [PATCH 08/32] target: " mchristi
2015-11-04 16:33 ` [Drbd-dev] " mchristi
2015-11-04 16:33 ` [PATCH 09/32] btrfs: " mchristi
2015-11-04 16:33 ` [Drbd-dev] " mchristi
2015-11-04 16:49 ` [dm-devel] [RFC PATCH 00/32] separate operations from flags in the bio/request structs Bart Van Assche
2015-11-04 16:49 ` Bart Van Assche
2015-11-04 16:49 ` [Drbd-dev] " Bart Van Assche
2015-11-04 16:53 ` Mike Christie
[not found] ` <563A3813.5010604-hcNo3dDEHLuVc3sceRu5cw@public.gmane.org>
2015-11-07 10:23 ` Christoph Hellwig
2015-11-07 10:23 ` Christoph Hellwig
2015-11-07 10:23 ` [Drbd-dev] " Christoph Hellwig
2015-11-11 7:53 ` Mike Christie
[not found] ` <5642F3F4.2060007-hcNo3dDEHLuVc3sceRu5cw@public.gmane.org>
2015-11-11 11:28 ` Christoph Hellwig
2015-11-11 11:28 ` Christoph Hellwig
2015-11-11 11:28 ` [Drbd-dev] " Christoph Hellwig
[not found] ` <20151111112846.GA358-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-11-11 17:37 ` Mike Snitzer [this message]
2015-11-11 17:37 ` Mike Snitzer
2015-11-11 17:37 ` [Drbd-dev] " Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151111173719.GB12236@redhat.com \
--to=snitzer-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org \
--cc=hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=michaelc-hcNo3dDEHLuVc3sceRu5cw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.