From: Vinod Koul <vinod.koul@intel.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: dmaengine@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>,
linux-kernel@vger.kernel.org,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
linux-arm-kernel@lists.infradead.org,
Sekhar Nori <nsekhar@ti.com>,
Kevin Hilman <khilman@deeprootsystems.com>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH] dmaengine: edma: fix build without CONFIG_OF
Date: Mon, 16 Nov 2015 09:06:07 +0530 [thread overview]
Message-ID: <20151116033607.GV25173@localhost> (raw)
In-Reply-To: <17811472.bY8CqmdEVy@wuerfel>
On Tue, Nov 03, 2015 at 03:00:57PM +0100, Arnd Bergmann wrote:
> During the edma rework, a build error was introduced for the
> case that CONFIG_OF is disabled:
>
> drivers/built-in.o: In function `edma_tc_set_pm_state':
> :(.text+0x43bf0): undefined reference to `of_find_device_by_node'
>
> As the edma_tc_set_pm_state() function does nothing in case
> we are running without OF, this adds an IS_ENABLED() check
> that turns the function into an empty stub then and avoids the
> link error.
Applied, thanks
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dmaengine: edma: fix build without CONFIG_OF
Date: Mon, 16 Nov 2015 09:06:07 +0530 [thread overview]
Message-ID: <20151116033607.GV25173@localhost> (raw)
In-Reply-To: <17811472.bY8CqmdEVy@wuerfel>
On Tue, Nov 03, 2015 at 03:00:57PM +0100, Arnd Bergmann wrote:
> During the edma rework, a build error was introduced for the
> case that CONFIG_OF is disabled:
>
> drivers/built-in.o: In function `edma_tc_set_pm_state':
> :(.text+0x43bf0): undefined reference to `of_find_device_by_node'
>
> As the edma_tc_set_pm_state() function does nothing in case
> we are running without OF, this adds an IS_ENABLED() check
> that turns the function into an empty stub then and avoids the
> link error.
Applied, thanks
--
~Vinod
next prev parent reply other threads:[~2015-11-16 3:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-03 14:00 [PATCH] dmaengine: edma: fix build without CONFIG_OF Arnd Bergmann
2015-11-03 14:00 ` Arnd Bergmann
2015-11-04 7:42 ` Peter Ujfalusi
2015-11-04 7:42 ` Peter Ujfalusi
2015-11-04 7:42 ` Peter Ujfalusi
2015-11-04 8:46 ` Arnd Bergmann
2015-11-04 8:46 ` Arnd Bergmann
2015-11-04 9:05 ` Peter Ujfalusi
2015-11-04 9:05 ` Peter Ujfalusi
2015-11-04 9:05 ` Peter Ujfalusi
2015-11-04 10:29 ` Arnd Bergmann
2015-11-04 10:29 ` Arnd Bergmann
2015-11-16 3:36 ` Vinod Koul [this message]
2015-11-16 3:36 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151116033607.GV25173@localhost \
--to=vinod.koul@intel.com \
--cc=arnd@arndb.de \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=khilman@deeprootsystems.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.